Allow max stack checking to be used with -flto build by determining top

dhalbert · tannewt · commit 5d509ecace76 · 2017-08-05T17:48:16.000-07:00
of stack in a different way.
diff --git a/atmel-samd/Makefile b/atmel-samd/Makefile
@@ -132,6 +132,7 @@ CFLAGS = $(INC) -Wall -Werror -std=gnu11 -nostdlib $(CFLAGS_CORTEX_M0) $(CFLAGS_
 ifeq ($(DEBUG), 1)
 # NDEBUG disables assert() statements. This reduces code size pretty dramatically, per tannewt.
 # Turn on Python modules useful for debugging (e.g. uheap, ustack).
+# -DMICROPY_DEBUG_MODULES may also be added to an -flto build, if you wish.
 CFLAGS += -Os -ggdb -DNDEBUG -DENABLE_MICRO_TRACE_BUFFER -DMICROPY_DEBUG_MODULES
 else
 CFLAGS += -Os -DNDEBUG -flto
diff --git a/py/stackctrl.c b/py/stackctrl.c
@@ -77,14 +77,27 @@ void mp_stack_set_bottom(void* stack_bottom) {
     MP_STATE_THREAD(stack_bottom) = stack_bottom;
 }
 
+// Return the current frame pointer. This can be used as an
+// approximation for the stack pointer of the _calling_ function.
+// This routine must not be inlined.  This method is
+// architecture-independent, as opposed to using asm("sp") or similar.
+//
+// The stack_dummy approach used elsewhere in this file is not safe in
+// all cases. That value may be below the actual top of the stack.
+static void* approx_stack_pointer(void){ 
+     __asm volatile ("");
+    return __builtin_frame_address(0);
+}
+
 // Fill stack space down toward the stack limit with a known unusual value.
 void mp_stack_fill_with_sentinel(void) {
     // Force routine to not be inlined. Better guarantee than MP_NOINLINE for -flto.
     __asm volatile ("");
-    volatile char* volatile p;
-    // Start filling stack just below the last variable in the current stack frame, which is p.
-    // Continue until we've hit the bottom of the stack (lowest address, logical "ceiling" of stack).
-    p = (char *) (&p - 1);
+    // Start filling stack just below the current stack frame.
+    // Continue until we've hit the bottom of the stack (lowest address,
+    // logical "ceiling" of stack).
+    char* p = (char *) approx_stack_pointer() - 1;
+    
     while(p >= MP_STATE_THREAD(stack_bottom)) {
 	*p-- = MP_MAX_STACK_USAGE_SENTINEL_BYTE;
     }
