Add TODO comments for future maintenance.

yfakariya · yfakariya · commit 2468df2bcb4d · 2016-05-15T18:50:18.000+09:00
diff --git a/src/MsgPack/Serialization/CollectionSerializers/CollectionMessagePackSerializer`2.cs b/src/MsgPack/Serialization/CollectionSerializers/CollectionMessagePackSerializer`2.cs
@@ -90,6 +90,7 @@ protected override void AddItem( TCollection collection, TItem item )
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityCollectionMessagePackSerializer : UnityEnumerableMessagePackSerializerBase
 	{
 		private readonly MethodInfo _getCount;
diff --git a/src/MsgPack/Serialization/CollectionSerializers/DictionaryMessagePackSerializer`3.cs b/src/MsgPack/Serialization/CollectionSerializers/DictionaryMessagePackSerializer`3.cs
@@ -43,6 +43,7 @@ namespace MsgPack.Serialization.CollectionSerializers
 	public abstract class DictionaryMessagePackSerializer<TDictionary, TKey, TValue> : DictionaryMessagePackSerializerBase<TDictionary, TKey, TValue>
 		where TDictionary : IDictionary<TKey, TValue>
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 		, IEnumerable<KeyValuePair<TKey, TValue>> // This is obvious from IDictionary<TKey, TValue>, but Unity compiler cannot recognize this.
 #endif // UNITY
 	{
@@ -99,6 +100,7 @@ protected override void AddItem( TDictionary dictionary, TKey key, TValue value
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityDictionaryMessagePackSerializer : NonGenericMessagePackSerializer,
 		ICollectionInstanceFactory
 	{
diff --git a/src/MsgPack/Serialization/CollectionSerializers/EnumerableMessagePackSerializer`2.cs b/src/MsgPack/Serialization/CollectionSerializers/EnumerableMessagePackSerializer`2.cs
@@ -126,6 +126,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti
 #endif // FEATURE_TAP
 	}
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityEnumerableMessagePackSerializer : UnityEnumerableMessagePackSerializerBase
 	{
 		private readonly MethodInfo _getCount;
diff --git a/src/MsgPack/Serialization/CollectionSerializers/NonGenericCollectionMessagePackSerializer`1.cs b/src/MsgPack/Serialization/CollectionSerializers/NonGenericCollectionMessagePackSerializer`1.cs
@@ -107,6 +107,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityNonGenericCollectionMessagePackSerializer : UnityNonGenericEnumerableMessagePackSerializerBase
 	{
 		protected UnityNonGenericCollectionMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )
diff --git a/src/MsgPack/Serialization/CollectionSerializers/NonGenericDictionaryMessagePackSerializer`1.cs b/src/MsgPack/Serialization/CollectionSerializers/NonGenericDictionaryMessagePackSerializer`1.cs
@@ -373,6 +373,7 @@ private async Task<TDictionary> UnpackToAsyncCore( Unpacker unpacker, TDictionar
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityNonGenericDictionaryMessagePackSerializer : NonGenericMessagePackSerializer, ICollectionInstanceFactory
 	{
 		private readonly MessagePackSerializer _keySerializer;
diff --git a/src/MsgPack/Serialization/CollectionSerializers/NonGenericEnumerableMessagePackSerializerBase`1.cs b/src/MsgPack/Serialization/CollectionSerializers/NonGenericEnumerableMessagePackSerializerBase`1.cs
@@ -245,6 +245,7 @@ protected virtual void AddItem( TCollection collection, object item )
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityNonGenericEnumerableMessagePackSerializerBase : NonGenericMessagePackSerializer, ICollectionInstanceFactory
 	{
 		private readonly MessagePackSerializer _itemSerializer;
diff --git a/src/MsgPack/Serialization/CollectionSerializers/NonGenericEnumerableMessagePackSerializer`1.cs b/src/MsgPack/Serialization/CollectionSerializers/NonGenericEnumerableMessagePackSerializer`1.cs
@@ -118,6 +118,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityNonGenericEnumerableMessagePackSerializer : UnityNonGenericEnumerableMessagePackSerializerBase
 	{
 		protected UnityNonGenericEnumerableMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )
diff --git a/src/MsgPack/Serialization/CollectionSerializers/NonGenericListMessagePackSerializer`1.cs b/src/MsgPack/Serialization/CollectionSerializers/NonGenericListMessagePackSerializer`1.cs
@@ -150,6 +150,7 @@ protected override void AddItem( TList collection, object item )
 	}
 
 #if UNITY
+#warning TODO: Remove if possible for maintenancibility.
 	internal abstract class UnityNonGenericListMessagePackSerializer : UnityNonGenericCollectionMessagePackSerializer
 	{
 		protected UnityNonGenericListMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractCollectionMessagePackSerializer`2.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractCollectionMessagePackSerializer`2.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractCollectionMessagePackSerializer<TCollection, TItem> : CollectionMessagePackSerializer<TCollection, TItem>
 		where TCollection : ICollection<TItem>
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractCollectionMessagePackSerializer : UnityCollectionMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractDictionaryMessagePackSerializer`3.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractDictionaryMessagePackSerializer`3.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractDictionaryMessagePackSerializer<TDictionary, TKey, TValue> : DictionaryMessagePackSerializer<TDictionary, TKey, TValue>
 		where TDictionary : IDictionary<TKey, TValue>
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractDictionaryMessagePackSerializer : UnityDictionaryMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractEnumerableMessagePackSerializer`2.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractEnumerableMessagePackSerializer`2.cs
@@ -38,6 +38,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractEnumerableMessagePackSerializer<TCollection, TItem> : EnumerableMessagePackSerializer<TCollection, TItem>
 		where TCollection : IEnumerable<TItem>
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractEnumerableMessagePackSerializer : UnityEnumerableMessagePackSerializer
 #endif
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericCollectionMessagePackSerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericCollectionMessagePackSerializer`1.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractNonGenericCollectionMessagePackSerializer<TCollection> : NonGenericCollectionMessagePackSerializer<TCollection>
 		where TCollection : ICollection
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractNonGenericCollectionMessagePackSerializer : UnityNonGenericCollectionMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericDictionaryMessagePackSerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericDictionaryMessagePackSerializer`1.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractNonGenericDictionaryMessagePackSerializer<TDictionary> : NonGenericDictionaryMessagePackSerializer<TDictionary>
 		where TDictionary : IDictionary
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractNonGenericDictionaryMessagePackSerializer : UnityNonGenericDictionaryMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericEnumerableMessagePackSerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericEnumerableMessagePackSerializer`1.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractNonGenericEnumerableMessagePackSerializer<TCollection> : NonGenericEnumerableMessagePackSerializer<TCollection>
 		where TCollection : IEnumerable
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractNonGenericEnumerableMessagePackSerializer : UnityNonGenericEnumerableMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericListMessagePackSerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/AbstractNonGenericListMessagePackSerializer`1.cs
@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 	internal sealed class AbstractNonGenericListMessagePackSerializer<TCollection> : NonGenericListMessagePackSerializer<TCollection>
 		where TCollection : IList
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class AbstractNonGenericListMessagePackSerializer : UnityNonGenericListMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/ArraySerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/ArraySerializer`1.cs
@@ -36,6 +36,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 #if !UNITY
 	internal sealed class ArraySerializer<T> : MessagePackSerializer<T[]>
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class UnityArraySerializer : NonGenericMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/MultidimensionalArraySerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/MultidimensionalArraySerializer`1.cs
@@ -35,6 +35,7 @@ namespace MsgPack.Serialization.DefaultSerializers
 #if !UNITY
 	internal sealed class MultidimensionalArraySerializer<TArray, TItem> : MessagePackSerializer<TArray>
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal sealed class UnityMultidimensionalArraySerializer : NonGenericMessagePackSerializer
 #endif // !UNITY
 	{
diff --git a/src/MsgPack/Serialization/DefaultSerializers/NullableMessagePackSerializer`1.cs b/src/MsgPack/Serialization/DefaultSerializers/NullableMessagePackSerializer`1.cs
@@ -99,6 +99,7 @@ protected internal override Task PackToAsyncCore( Packer packer, T? objectTree,
 
 	}
 #else
+#warning TODO: Use generic collection if possible for maintenancibility.
 	internal class NullableMessagePackSerializer : NonGenericMessagePackSerializer
 	{
 		private readonly MessagePackSerializer _valueSerializer;

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ protected override void AddItem( TCollection collection, TItem item )`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`#if UNITY`
	`93`	`+#warning TODO: Remove if possible for maintenancibility.`
`93`	`94`	`internal abstract class UnityCollectionMessagePackSerializer : UnityEnumerableMessagePackSerializerBase`
`94`	`95`	`{`
`95`	`96`	`private readonly MethodInfo _getCount;`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ namespace MsgPack.Serialization.CollectionSerializers`
`43`	`43`	`public abstract class DictionaryMessagePackSerializer<TDictionary, TKey, TValue> : DictionaryMessagePackSerializerBase<TDictionary, TKey, TValue>`
`44`	`44`	`where TDictionary : IDictionary<TKey, TValue>`
`45`	`45`	`#if UNITY`
	`46`	`+#warning TODO: Remove if possible for maintenancibility.`
`46`	`47`	`, IEnumerable<KeyValuePair<TKey, TValue>> // This is obvious from IDictionary<TKey, TValue>, but Unity compiler cannot recognize this.`
`47`	`48`	`#endif // UNITY`
`48`	`49`	`{`
`@@ -99,6 +100,7 @@ protected override void AddItem( TDictionary dictionary, TKey key, TValue value`
`99`	`100`	`}`
`100`	`101`
`101`	`102`	`#if UNITY`
	`103`	`+#warning TODO: Remove if possible for maintenancibility.`
`102`	`104`	`internal abstract class UnityDictionaryMessagePackSerializer : NonGenericMessagePackSerializer,`
`103`	`105`	`ICollectionInstanceFactory`
`104`	`106`	`{`
Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti`
`126`	`126`	`#endif // FEATURE_TAP`
`127`	`127`	`}`
`128`	`128`	`#if UNITY`
	`129`	`+#warning TODO: Remove if possible for maintenancibility.`
`129`	`130`	`internal abstract class UnityEnumerableMessagePackSerializer : UnityEnumerableMessagePackSerializerBase`
`130`	`131`	`{`
`131`	`132`	`private readonly MethodInfo _getCount;`
Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`#if UNITY`
	`110`	`+#warning TODO: Remove if possible for maintenancibility.`
`110`	`111`	`internal abstract class UnityNonGenericCollectionMessagePackSerializer : UnityNonGenericEnumerableMessagePackSerializerBase`
`111`	`112`	`{`
`112`	`113`	`protected UnityNonGenericCollectionMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )`
Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,7 @@ private async Task<TDictionary> UnpackToAsyncCore( Unpacker unpacker, TDictionar`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`#if UNITY`
	`376`	`+#warning TODO: Remove if possible for maintenancibility.`
`376`	`377`	`internal abstract class UnityNonGenericDictionaryMessagePackSerializer : NonGenericMessagePackSerializer, ICollectionInstanceFactory`
`377`	`378`	`{`
`378`	`379`	`private readonly MessagePackSerializer _keySerializer;`
Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,7 @@ protected virtual void AddItem( TCollection collection, object item )`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`#if UNITY`
	`248`	`+#warning TODO: Remove if possible for maintenancibility.`
`248`	`249`	`internal abstract class UnityNonGenericEnumerableMessagePackSerializerBase : NonGenericMessagePackSerializer, ICollectionInstanceFactory`
`249`	`250`	`{`
`250`	`251`	`private readonly MessagePackSerializer _itemSerializer;`
Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ protected internal override async Task PackToAsyncCore( Packer packer, TCollecti`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`#if UNITY`
	`121`	`+#warning TODO: Remove if possible for maintenancibility.`
`121`	`122`	`internal abstract class UnityNonGenericEnumerableMessagePackSerializer : UnityNonGenericEnumerableMessagePackSerializerBase`
`122`	`123`	`{`
`123`	`124`	`protected UnityNonGenericEnumerableMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )`
Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,7 @@ protected override void AddItem( TList collection, object item )`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`#if UNITY`
	`153`	`+#warning TODO: Remove if possible for maintenancibility.`
`153`	`154`	`internal abstract class UnityNonGenericListMessagePackSerializer : UnityNonGenericCollectionMessagePackSerializer`
`154`	`155`	`{`
`155`	`156`	`protected UnityNonGenericListMessagePackSerializer( SerializationContext ownerContext, Type targetType, PolymorphismSchema schema )`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ namespace MsgPack.Serialization.DefaultSerializers`
`40`	`40`	`internal sealed class AbstractCollectionMessagePackSerializer<TCollection, TItem> : CollectionMessagePackSerializer<TCollection, TItem>`
`41`	`41`	`where TCollection : ICollection<TItem>`
`42`	`42`	`#else`
	`43`	`+#warning TODO: Use generic collection if possible for maintenancibility.`
`43`	`44`	`internal sealed class AbstractCollectionMessagePackSerializer : UnityCollectionMessagePackSerializer`
`44`	`45`	`#endif // !UNITY`
`45`	`46`	`{`