Clean code

wherewhere · wherewhere · commit a76fb583e27a · 2022-09-27T12:26:17.000+08:00
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml
@@ -47,7 +47,7 @@ body:
         - ".NET Framework 4.5.x"
         - ".NET Framework 4.6.x"
         - ".NET Framework 4.7.x"
-        - ".NET Framework 4.8"
+        - ".NET Framework 4.8.x"
         - ".NET Standard 1.x"
         - ".NET Standard 2.x"
         - ".NET Core App 1.x"
@@ -66,7 +66,6 @@ body:
         - "Windows"
         - "Linux"
         - "MacOS"
-        - "UWP"
         - "Others"
   - type: textarea
     attributes:
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -14,11 +14,8 @@ env:
 jobs:
   build-and-test:
 
-    name: build-and-test-${{matrix.os}}
-    runs-on: ${{matrix.os}}
-    strategy:
-      matrix:
-        os: [windows-latest]
+    name: build-and-test
+    runs-on: windows-latest
 
     steps:
     - uses: actions/checkout@v2
diff --git a/AdvancedSharpAdbClient.Tests/Extensions/UtilitiesTests.cs b/AdvancedSharpAdbClient.Tests/Extensions/UtilitiesTests.cs
@@ -11,8 +11,7 @@ public class UtilitiesTests
         [Fact]
         public void TryParseTest()
         {
-            DeviceState result;
-            Assert.True(Utilities.TryParse("BootLoader", false, out result));
+            Assert.True(Utilities.TryParse("BootLoader", false, out DeviceState result));
             Assert.Equal(DeviceState.BootLoader, result);
             Assert.True(Utilities.TryParse("Bootloader", true, out result));
             Assert.Equal(DeviceState.BootLoader, result);
diff --git a/AdvancedSharpAdbClient/AdbClient.cs b/AdvancedSharpAdbClient/AdbClient.cs
@@ -29,7 +29,7 @@ namespace AdvancedSharpAdbClient
     ///     call the <see cref="GetDevices"/> method.
     /// </para>
     /// <para>
-    ///     To run a command on a device, you can use the <see cref="ExecuteRemoteCommandAsync(string, DeviceData, IShellOutputReceiver, CancellationToken, int)"/>
+    ///     To run a command on a device, you can use the <see cref="ExecuteRemoteCommandAsync(string, DeviceData, IShellOutputReceiver, CancellationToken)"/>
     ///     method.
     /// </para>
     /// </summary>
diff --git a/AdvancedSharpAdbClient/Extensions/Utilities.cs b/AdvancedSharpAdbClient/Extensions/Utilities.cs
@@ -2,7 +2,6 @@
 using System.IO;
 using System.Net.Sockets;
 using System.Threading.Tasks;
-using System.Xml;
 
 namespace AdvancedSharpAdbClient
 {
@@ -62,7 +61,7 @@ public static long ToUnixTimeSeconds(this DateTimeOffset dateTimeOffset) =>
 #endif
 
 #if NETSTANDARD1_3
-        public static IAsyncResult BeginReceive(this Socket socket,byte[] buffer, int offset, int size, SocketFlags socketFlags, AsyncCallback? callback, object? state)
+        public static IAsyncResult BeginReceive(this Socket socket, byte[] buffer, int offset, int size, SocketFlags socketFlags, AsyncCallback? callback, object? state)
         {
             return TaskToApm.Begin(socket.ReceiveAsync(buffer, offset, size, socketFlags, default), callback, state);
         }
diff --git a/README.md b/README.md
@@ -29,8 +29,8 @@ Added important features.
 - .NET Framework 4.5.2
 - .NET Framework 4.6.2
 - .NET Framework 4.7.2
-- .NET Framework 4.8
-- .NET Standard 1.3 (Not full supports)
+- .NET Framework 4.8.1
+- .NET Standard 1.3 (Not fully supported)
 - .NET Standard 2.0 (Support UWP if you don't use unsupport api like Process)
 - .NET Core App 3.1
 - .NET 6.0
@@ -437,7 +437,7 @@ static async void Main(string[] args)
 ```
 
 ### Encoding
-Default encoding is UTF8,if you want to change it, use
+Default encoding is UTF8, if you want to change it, use
 
 ```c#
 AdvancedAdbClient.SetEncoding(Encoding.ASCII);

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`using System.IO;`
`3`	`3`	`using System.Net.Sockets;`
`4`	`4`	`using System.Threading.Tasks;`
`5`		`-using System.Xml;`
`6`	`5`
`7`	`6`	`namespace AdvancedSharpAdbClient`
`8`	`7`	`{`
`@@ -62,7 +61,7 @@ public static long ToUnixTimeSeconds(this DateTimeOffset dateTimeOffset) =>`
`62`	`61`	`#endif`
`63`	`62`
`64`	`63`	`#if NETSTANDARD1_3`
`65`		`- public static IAsyncResult BeginReceive(this Socket socket,byte[] buffer, int offset, int size, SocketFlags socketFlags, AsyncCallback? callback, object? state)`
	`64`	`+ public static IAsyncResult BeginReceive(this Socket socket, byte[] buffer, int offset, int size, SocketFlags socketFlags, AsyncCallback? callback, object? state)`
`66`	`65`	`{`
`67`	`66`	`return TaskToApm.Begin(socket.ReceiveAsync(buffer, offset, size, socketFlags, default), callback, state);`
`68`	`67`	`}`