/*

* Cppcheck - A tool for static C/C++ code analysis

* Copyright (C) 2007-2021 Cppcheck team.

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 3 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

#include "checkio.h"

#include "platform.h"

#include "settings.h"

#include "testsuite.h"

#include "tokenize.h"

class TestIO : public TestFixture {

public:

TestIO() : TestFixture("TestIO") {}

private:

Settings settings;

void run() OVERRIDE {

LOAD_LIB_2(settings.library, "std.cfg");

LOAD_LIB_2(settings.library, "windows.cfg");

LOAD_LIB_2(settings.library, "qt.cfg");

TEST_CASE(coutCerrMisusage);

TEST_CASE(wrongMode_simple);

TEST_CASE(wrongMode_complex);

TEST_CASE(useClosedFile);

TEST_CASE(fileIOwithoutPositioning);

TEST_CASE(seekOnAppendedFile);

TEST_CASE(fflushOnInputStream);

TEST_CASE(incompatibleFileOpen);

TEST_CASE(testScanf1); // Scanf without field limiters

TEST_CASE(testScanf2);

TEST_CASE(testScanf3); // #3494

TEST_CASE(testScanf4); // #ticket 2553

TEST_CASE(testScanfArgument);

TEST_CASE(testPrintfArgument);

TEST_CASE(testPrintfArgumentVariables);

TEST_CASE(testPosixPrintfScanfParameterPosition); // #4900

TEST_CASE(testMicrosoftPrintfArgument); // ticket #4902

TEST_CASE(testMicrosoftScanfArgument);

TEST_CASE(testMicrosoftCStringFormatArguments); // ticket #4920

TEST_CASE(testMicrosoftSecurePrintfArgument);

TEST_CASE(testMicrosoftSecureScanfArgument);

TEST_CASE(testQStringFormatArguments);

TEST_CASE(testTernary); // ticket #6182

TEST_CASE(testUnsignedConst); // ticket #6132

TEST_CASE(testAstType); // #7014

TEST_CASE(testPrintf0WithSuffix); // ticket #7069

TEST_CASE(testReturnValueTypeStdLib);

TEST_CASE(testPrintfTypeAlias1);

TEST_CASE(testPrintfAuto); // #8992

TEST_CASE(testPrintfParenthesis); // #8489

TEST_CASE(testStdDistance); // #10304

}

void check(const char* code, bool inconclusive = false, bool portability = false, Settings::PlatformType platform = Settings::Unspecified, bool onlyFormatStr = false) {

// Clear the error buffer..

errout.str("");

settings.severity.clear();

settings.severity.enable(Severity::warning);

settings.severity.enable(Severity::style);

if (portability)

settings.severity.enable(Severity::portability);

settings.certainty.setEnabled(Certainty::inconclusive, inconclusive);

settings.platform(platform);

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

// Check..

CheckIO checkIO(&tokenizer, &settings, this);

checkIO.checkWrongPrintfScanfArguments();

if (!onlyFormatStr) {

checkIO.checkCoutCerrMisusage();

checkIO.checkFileUsage();

checkIO.invalidScanf();

}

}

void coutCerrMisusage() {

check(

"void foo() {\n"

" std::cout << std::cout;\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid usage of output stream: '<< std::cout'.\n", errout.str());

check(

"void foo() {\n"

" std::cout << (std::cout);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid usage of output stream: '<< std::cout'.\n", errout.str());

check(

"void foo() {\n"

" std::cout << \"xyz\" << std::cout;\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid usage of output stream: '<< std::cout'.\n", errout.str());

check(

"void foo(int i) {\n"

" std::cout << i << std::cerr;\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) Invalid usage of output stream: '<< std::cerr'.\n", errout.str());

check(

"void foo() {\n"

" std::cout << \"xyz\";\n"

" std::cout << \"xyz\";\n"

"}");

ASSERT_EQUALS("", errout.str());

check(

"void foo() {\n"

" std::cout << std::cout.good();\n"

"}");

ASSERT_EQUALS("", errout.str());

check(

"void foo() {\n"

" unknownObject << std::cout;\n"

"}");

ASSERT_EQUALS("", errout.str());

check(

"void foo() {\n"

" MACRO(std::cout <<, << std::cout)\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void wrongMode_simple() {

// Read mode

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"r\");\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _wfopen(name, L\"r\");\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfopen(name, _T(\"r\"));\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfopen(name, _T(\"r\"));\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" _wfopen_s(&f, name, L\"r\");\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" _tfopen_s(&f, name, _T(\"r\"));\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" _tfopen_s(&f, name, _T(\"r\"));\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:5]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"r+\");\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = _wfopen(name, L\"r+\");\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfopen(name, _T(\"r+\"));\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfopen(name, _T(\"r+\"));\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" _wfopen_s(&f, name, L\"r+\");\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" _tfopen_s(&f, name, _T(\"r+\"));\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" _tfopen_s(&f, name, _T(\"r+\"));\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = tmpfile();\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("", errout.str());

// Write mode

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"w\");\n"

" fwrite(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Read operation on a file that was opened only for writing.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"w+\");\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = tmpfile();\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

// Append mode

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"a\");\n"

" fwrite(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (warning) Repositioning operation performed on a file opened in append mode has no effect.\n"

"[test.cpp:5]: (error) Read operation on a file that was opened only for writing.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"a+\");\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

// Variable declared locally

check("void foo() {\n"

" FILE* f = fopen(name, \"r\");\n"

" fwrite(buffer, 5, 6, f);\n"

" fclose(f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

// Call unknown function

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"a\");\n"

" fwrite(buffer, 5, 6, f);\n"

" bar(f);\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

// freopen and tmpfile

check("void foo(FILE*& f) {\n"

" f = freopen(name, \"r\", f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _wfreopen(name, L\"r\", f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfreopen(name, _T(\"r\"), f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfreopen(name, _T(\"r\"), f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _wfreopen_s(&f, name, L\"r\", f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfreopen_s(&f, name, _T(\"r\"), f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32A);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = _tfreopen_s(&f, name, _T(\"r\"), f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}", false, false, Settings::Win32W);

ASSERT_EQUALS("[test.cpp:3]: (error) Write operation on a file that was opened only for reading.\n", errout.str());

// Crash tests

check("void foo(FILE*& f) {\n"

" f = fopen(name, mode);\n" // No assertion failure (#3830)

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void fopen(std::string const &filepath, std::string const &mode);"); // #3832

}

void wrongMode_complex() {

check("void foo(FILE* f) {\n"

" if(a) f = fopen(name, \"w\");\n"

" else f = fopen(name, \"r\");\n"

" if(a) fwrite(buffer, 5, 6, f);\n"

" else fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" FILE* f;\n"

" if(a) f = fopen(name, \"w\");\n"

" else f = fopen(name, \"r\");\n"

" if(a) fwrite(buffer, 5, 6, f);\n"

" else fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" FILE* f = fopen(name, \"w\");\n"

" if(a) fwrite(buffer, 5, 6, f);\n"

" else fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) Read operation on a file that was opened only for writing.\n", errout.str());

}

void useClosedFile() {

check("void foo(FILE*& f) {\n"

" fclose(f);\n"

" fwrite(buffer, 5, 6, f);\n"

" clearerr(f);\n"

" fread(buffer, 5, 6, f);\n"

" ungetc('a', f);\n"

" ungetwc(L'a', f);\n"

" rewind(f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Used file that is not opened.\n"

"[test.cpp:4]: (error) Used file that is not opened.\n"

"[test.cpp:5]: (error) Used file that is not opened.\n"

"[test.cpp:6]: (error) Used file that is not opened.\n"

"[test.cpp:7]: (error) Used file that is not opened.\n"

"[test.cpp:8]: (error) Used file that is not opened.\n", errout.str());

check("void foo(FILE*& f) {\n"

" if(!ferror(f)) {\n"

" fclose(f);\n"

" return;"

" }\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" fclose(f);\n"

" f = fopen(name, \"r\");\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(name, \"r\");\n"

" f = g;\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" FILE* f;\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Used file that is not opened.\n", errout.str());

check("void foo() {\n"

" FILE* f(stdout);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n" // #3965

" FILE* f[3];\n"

" f[0] = fopen(name, mode);\n"

" fclose(f[0]);\n"

"}");

ASSERT_EQUALS("", errout.str());

// #4368: multiple functions

check("static FILE *fp = NULL;\n"

"\n"

"void close()\n"

"{\n"

" fclose(fp);\n"

"}\n"

"\n"

"void dump()\n"

"{\n"

" if (fp == NULL) return;\n"

" fprintf(fp, \"Here's the output.\\n\");\n"

"}\n"

"\n"

"int main()\n"

"{\n"

" fp = fopen(\"test.txt\", \"w\");\n"

" dump();\n"

" close();\n"

" return 0;\n"

"}");

ASSERT_EQUALS("", errout.str());

check("static FILE *fp = NULL;\n"

"\n"

"void close()\n"

"{\n"

" fclose(fp);\n"

"}\n"

"\n"

"void dump()\n"

"{\n"

" fclose(fp);\n"

" fprintf(fp, \"Here's the output.\\n\");\n"

"}");

ASSERT_EQUALS("[test.cpp:11]: (error) Used file that is not opened.\n", errout.str());

// #4466

check("void chdcd_parse_nero(FILE *infile) {\n"

" switch (mode) {\n"

" case 0x0300:\n"

" fclose(infile);\n"

" return;\n"

" case 0x0500:\n"

" fclose(infile);\n"

" return;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void chdcd_parse_nero(FILE *infile) {\n"

" switch (mode) {\n"

" case 0x0300:\n"

" fclose(infile);\n"

" exit(0);\n"

" case 0x0500:\n"

" fclose(infile);\n"

" return;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

// #4649

check("void foo() {\n"

" struct {FILE *f1; FILE *f2;} a;\n"

" a.f1 = fopen(name,mode);\n"

" a.f2 = fopen(name,mode);\n"

" fclose(a.f1);\n"

" fclose(a.f2);\n"

"}");

ASSERT_EQUALS("", errout.str());

// #1473

check("void foo() {\n"

" FILE *a = fopen(\"aa\", \"r\");\n"

" while (fclose(a)) {}\n"

"}");

TODO_ASSERT_EQUALS("[test.cpp:3]: (error) Used file that is not opened.\n", "", errout.str());

// #6823

check("void foo() {\n"

" FILE f[2];\n"

" f[0] = fopen(\"1\", \"w\");\n"

" f[1] = fopen(\"2\", \"w\");\n"

" fclose(f[0]);\n"

" fclose(f[1]);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void fileIOwithoutPositioning() {

check("void foo(FILE* f) {\n"

" fwrite(buffer, 5, 6, f);\n"

" fread(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.\n", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.\n", errout.str());

check("void foo(FILE* f, bool read) {\n"

" if(read)\n"

" fread(buffer, 5, 6, f);\n"

" else\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" fflush(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" rewind(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" fsetpos(f, pos);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" fseek(f, 0, SEEK_SET);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo(FILE* f) {\n"

" fread(buffer, 5, 6, f);\n"

" long pos = ftell(f);\n"

" fwrite(buffer, 5, 6, f);\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.\n", errout.str());

// #6452 - member functions

check("class FileStream {\n"

" void insert(const ByteVector &data, ulong start);\n"

" void seek(long offset, Position p);\n"

" FileStreamPrivate *d;\n"

"};\n"

"void FileStream::insert(const ByteVector &data, ulong start) {\n"

" int bytesRead = fread(aboutToOverwrite.data(), 1, bufferLength, d->file);\n"

" seek(writePosition);\n"

" fwrite(buffer.data(), sizeof(char), buffer.size(), d->file);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("class FileStream {\n"

" void insert(const ByteVector &data, ulong start);\n"

" FileStreamPrivate *d;\n"

"};\n"

"void FileStream::insert(const ByteVector &data, ulong start) {\n"

" int bytesRead = fread(aboutToOverwrite.data(), 1, bufferLength, d->file);\n"

" unknown(writePosition);\n"

" fwrite(buffer.data(), sizeof(char), buffer.size(), d->file);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("class FileStream {\n"

" void insert(const ByteVector &data, ulong start);\n"

" FileStreamPrivate *d;\n"

"};\n"

"void known(int);\n"

"void FileStream::insert(const ByteVector &data, ulong start) {\n"

" int bytesRead = fread(aboutToOverwrite.data(), 1, bufferLength, d->file);\n"

" known(writePosition);\n"

" fwrite(buffer.data(), sizeof(char), buffer.size(), d->file);\n"

"}");

ASSERT_EQUALS("[test.cpp:9]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.\n", errout.str());

check("class FileStream {\n"

" void insert(const ByteVector &data, ulong start);\n"

" FileStreamPrivate *d;\n"

"};\n"

"void known(int);\n"

"void FileStream::insert(const ByteVector &data, ulong start) {\n"

" int bytesRead = fread(X::data(), 1, bufferLength, d->file);\n"

" known(writePosition);\n"

" fwrite(X::data(), sizeof(char), buffer.size(), d->file);\n"

"}");

ASSERT_EQUALS("[test.cpp:9]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.\n", errout.str());

}

void seekOnAppendedFile() {

check("void foo() {\n"

" FILE* f = fopen(\"\", \"a+\");\n"

" fseek(f, 0, SEEK_SET);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" FILE* f = fopen(\"\", \"w\");\n"

" fseek(f, 0, SEEK_SET);\n"

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" FILE* f = fopen(\"\", \"a\");\n"

" fseek(f, 0, SEEK_SET);\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) Repositioning operation performed on a file opened in append mode has no effect.\n", errout.str());

check("void foo() {\n"

" FILE* f = fopen(\"\", \"a\");\n"

" fflush(f);\n"

"}");

ASSERT_EQUALS("", errout.str()); // #5578

check("void foo() {\n"

" FILE* f = fopen(\"\", \"a\");\n"

" fclose(f);\n"

" f = fopen(\"\", \"r\");\n"

" fseek(f, 0, SEEK_SET);\n"

"}");

ASSERT_EQUALS("", errout.str()); // #6566

}

void fflushOnInputStream() {

check("void foo()\n"

"{\n"

" fflush(stdin);\n"

"}", false, true);

ASSERT_EQUALS("[test.cpp:3]: (portability) fflush() called on input stream 'stdin' may result in undefined behaviour on non-linux systems.\n", errout.str());

check("void foo()\n"

"{\n"

" fflush(stdout);\n"

"}", false, true);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(path, \"r\");\n"

" fflush(f);\n"

"}", false, true);

ASSERT_EQUALS("[test.cpp:3]: (portability) fflush() called on input stream 'f' may result in undefined behaviour on non-linux systems.\n", errout.str());

check("void foo(FILE*& f) {\n"

" f = fopen(path, \"w\");\n"

" fflush(f);\n"

"}", false, true);

ASSERT_EQUALS("", errout.str());

check("void foo(FILE*& f) {\n"

" fflush(f);\n"

"}", false, true);

ASSERT_EQUALS("", errout.str());

}

void incompatibleFileOpen() {

check("void foo() {\n"

" FILE *f1 = fopen(\"tmp\", \"wt\");\n"

" FILE *f2 = fopen(\"tmp\", \"rt\");\n"

"}");

ASSERT_EQUALS("[test.cpp:3]: (warning) The file '\"tmp\"' is opened for read and write access at the same time on different streams\n", errout.str());

}

void testScanf1() {

check("void foo() {\n"

" int a, b;\n"

" FILE *file = fopen(\"test\", \"r\");\n"

" a = fscanf(file, \"aa %s\", bar);\n"

" b = scanf(\"aa %S\", bar);\n"

" b = scanf(\"aa %ls\", bar);\n"

" sscanf(foo, \"%[^~]\", bar);\n"

" scanf(\"%dx%s\", &b, bar);\n"

" fclose(file);\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (warning) fscanf() without field width limits can crash with huge input data.\n"

"[test.cpp:5]: (warning) scanf() without field width limits can crash with huge input data.\n"

"[test.cpp:6]: (warning) scanf() without field width limits can crash with huge input data.\n"

"[test.cpp:7]: (warning) sscanf() without field width limits can crash with huge input data.\n"

"[test.cpp:8]: (warning) scanf() without field width limits can crash with huge input data.\n", errout.str());

}

void testScanf2() {

check("void foo() {\n"

" scanf(\"%5s\", bar);\n" // Width specifier given

" scanf(\"%5[^~]\", bar);\n" // Width specifier given

" scanf(\"aa%%s\", bar);\n" // No %s

" scanf(\"aa%d\", &a);\n" // No %s

" scanf(\"aa%ld\", &a);\n" // No %s

" scanf(\"%*[^~]\");\n" // Ignore input

"}");

ASSERT_EQUALS("[test.cpp:4]: (warning) scanf format string requires 0 parameters but 1 is given.\n", errout.str());

}

void testScanf3() { // ticket #3494

check("void f() {\n"

" char str[8];\n"

" scanf(\"%7c\", str);\n"

" scanf(\"%8c\", str);\n"

" scanf(\"%9c\", str);\n"

"}");

ASSERT_EQUALS("[test.cpp:5]: (error) Width 9 given in format string (no. 1) is larger than destination buffer 'str[8]', use %8c to prevent overflowing it.\n", errout.str());

}

void testScanf4() { // ticket #2553

check("void f()\n"

"{\n"

" char str [8];\n"

" scanf (\"%70s\",str);\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) Width 70 given in format string (no. 1) is larger than destination buffer 'str[8]', use %7s to prevent overflowing it.\n", errout.str());

}

#define TEST_SCANF_CODE(format, type) \

"void f(){" type " x; scanf(\"" format "\", &x);}"

#define TEST_SCANF_ERR(format, formatStr, type) \

"[test.cpp:1]: (warning) " format " in format string (no. 1) requires '" formatStr " *' but the argument type is '" type " *'.\n"

#define TEST_SCANF_ERR_AKA(format, formatStr, type, akaType) \

"[test.cpp:1]: (portability) " format " in format string (no. 1) requires '" formatStr " *' but the argument type is '" type " * {aka " akaType " *}'.\n"

#define TEST_PRINTF_CODE(format, type) \

"void f(" type " x){printf(\"" format "\", x);}"

#define TEST_PRINTF_ERR(format, requiredType, actualType) \

"[test.cpp:1]: (warning) " format " in format string (no. 1) requires '" requiredType "' but the argument type is '" actualType "'.\n"

#define TEST_PRINTF_ERR_AKA(format, requiredType, actualType, akaType) \

"[test.cpp:1]: (portability) " format " in format string (no. 1) requires '" requiredType "' but the argument type is '" actualType " {aka " akaType "}'.\n"

void testFormatStrNoWarn(const char *filename, unsigned int linenr, const char* code) {

check(code, true, false, Settings::Unix32, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, false, Settings::Unix64, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, false, Settings::Win32A, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, false, Settings::Win64, true);

assertEquals(filename, linenr, emptyString, errout.str());

}

void testFormatStrWarn(const char *filename, unsigned int linenr,

const char* code, const char* testScanfErrString) {

check(code, true, false, Settings::Unix32, true);

assertEquals(filename, linenr, testScanfErrString, errout.str());

check(code, true, false, Settings::Unix64, true);

assertEquals(filename, linenr, testScanfErrString, errout.str());

check(code, true, false, Settings::Win32A, true);

assertEquals(filename, linenr, testScanfErrString, errout.str());

check(code, true, false, Settings::Win64, true);

assertEquals(filename, linenr, testScanfErrString, errout.str());

}

void testFormatStrWarnAka(const char *filename, unsigned int linenr,

const char* code, const char* testScanfErrAkaString, const char* testScanfErrAkaWin64String) {

check(code, true, true, Settings::Unix32, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Unix64, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Win32A, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Win64, true);

assertEquals(filename, linenr, testScanfErrAkaWin64String, errout.str());

}

void testFormatStrWarnAkaWin64(const char *filename, unsigned int linenr,

const char* code, const char* testScanfErrAkaWin64String) {

check(code, true, true, Settings::Unix32, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, true, Settings::Unix64, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, true, Settings::Win32A, true);

assertEquals(filename, linenr, emptyString, errout.str());

check(code, true, true, Settings::Win64, true);

assertEquals(filename, linenr, testScanfErrAkaWin64String, errout.str());

}

void testFormatStrWarnAkaWin32(const char *filename, unsigned int linenr,

const char* code, const char* testScanfErrAkaString) {

check(code, true, true, Settings::Unix32, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Unix64, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Win32A, true);

assertEquals(filename, linenr, testScanfErrAkaString, errout.str());

check(code, true, true, Settings::Win64, true);

assertEquals(filename, linenr, emptyString, errout.str());

}

#define TEST_SCANF_NOWARN(FORMAT, FORMATSTR, TYPE) \

testFormatStrNoWarn(__FILE__, __LINE__, TEST_SCANF_CODE(FORMAT, TYPE))

#define TEST_SCANF_WARN(FORMAT, FORMATSTR, TYPE) \

testFormatStrWarn(__FILE__, __LINE__, TEST_SCANF_CODE(FORMAT, TYPE), TEST_SCANF_ERR(FORMAT, FORMATSTR, TYPE))

#define TEST_SCANF_WARN_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE, AKATYPE_WIN64) \

testFormatStrWarnAka(__FILE__, __LINE__, TEST_SCANF_CODE(FORMAT, TYPE), TEST_SCANF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE), TEST_SCANF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64))

#define TEST_SCANF_WARN_AKA_WIN64(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64) \

testFormatStrWarnAkaWin64(__FILE__, __LINE__, TEST_SCANF_CODE(FORMAT, TYPE), TEST_SCANF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64))

#define TEST_SCANF_WARN_AKA_WIN32(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN32) \

testFormatStrWarnAkaWin32(__FILE__, __LINE__, TEST_SCANF_CODE(FORMAT, TYPE), TEST_SCANF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN32))

#define TEST_PRINTF_NOWARN(FORMAT, FORMATSTR, TYPE) \

testFormatStrNoWarn(__FILE__, __LINE__, TEST_PRINTF_CODE(FORMAT, TYPE))

#define TEST_PRINTF_WARN(FORMAT, FORMATSTR, TYPE) \

testFormatStrWarn(__FILE__, __LINE__, TEST_PRINTF_CODE(FORMAT, TYPE), TEST_PRINTF_ERR(FORMAT, FORMATSTR, TYPE))

#define TEST_PRINTF_WARN_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE, AKATYPE_WIN64) \

testFormatStrWarnAka(__FILE__, __LINE__, TEST_PRINTF_CODE(FORMAT, TYPE), TEST_PRINTF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE), TEST_PRINTF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64))

#define TEST_PRINTF_WARN_AKA_WIN64(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64) \

testFormatStrWarnAkaWin64(__FILE__, __LINE__, TEST_PRINTF_CODE(FORMAT, TYPE), TEST_PRINTF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN64))

#define TEST_PRINTF_WARN_AKA_WIN32(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN32) \

testFormatStrWarnAkaWin32(__FILE__, __LINE__, TEST_PRINTF_CODE(FORMAT, TYPE), TEST_PRINTF_ERR_AKA(FORMAT, FORMATSTR, TYPE, AKATYPE_WIN32))

void testScanfArgument() {

check("void foo() {\n"

" scanf(\"%1d\", &foo);\n"

" sscanf(bar, \"%1d\", &foo);\n"

" scanf(\"%1u%1u\", &foo, bar());\n"

" scanf(\"%*1x %1x %29s\", &count, KeyName);\n" // #3373

" fscanf(f, \"%7ms\", &ref);\n" // #3461

" sscanf(ip_port, \"%*[^:]:%4d\", &port);\n" // #3468

"}");

ASSERT_EQUALS("", errout.str());

check("void foo() {\n"

" scanf(\"\", &foo);\n"

" scanf(\"%1d\", &foo, &bar);\n"

" fscanf(bar, \"%1d\", &foo, &bar);\n"

" scanf(\"%*1x %1x %29s\", &count, KeyName, foo);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (warning) scanf format string requires 0 parameters but 1 is given.\n"

"[test.cpp:3]: (warning) scanf format string requires 1 parameter but 2 are given.\n"

"[test.cpp:4]: (warning) fscanf format string requires 1 parameter but 2 are given.\n"

"[test.cpp:5]: (warning) scanf format string requires 2 parameters but 3 are given.\n", errout.str());

check("void foo() {\n"

" scanf(\"%1d\");\n"

" scanf(\"%1u%1u\", bar());\n"

" sscanf(bar, \"%1d%1d\", &foo);\n"

" scanf(\"%*1x %1x %29s\", &count);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (error) scanf format string requires 1 parameter but only 0 are given.\n"

"[test.cpp:3]: (error) scanf format string requires 2 parameters but only 1 is given.\n"

"[test.cpp:4]: (error) sscanf format string requires 2 parameters but only 1 is given.\n"

"[test.cpp:5]: (error) scanf format string requires 2 parameters but only 1 is given.\n", errout.str());

check("void foo() {\n"

" char input[10];\n"

" char output[5];\n"

" sscanf(input, \"%3s\", output);\n"

" sscanf(input, \"%4s\", output);\n"

" sscanf(input, \"%5s\", output);\n"

"}", false);

ASSERT_EQUALS("[test.cpp:6]: (error) Width 5 given in format string (no. 1) is larger than destination buffer 'output[5]', use %4s to prevent overflowing it.\n", errout.str());

check("void foo() {\n"

" char input[10];\n"

" char output[5];\n"

" sscanf(input, \"%s\", output);\n"

" sscanf(input, \"%3s\", output);\n"

" sscanf(input, \"%4s\", output);\n"

" sscanf(input, \"%5s\", output);\n"

"}", true);

ASSERT_EQUALS("[test.cpp:5]: (warning, inconclusive) Width 3 given in format string (no. 1) is smaller than destination buffer 'output[5]'.\n"

"[test.cpp:7]: (error) Width 5 given in format string (no. 1) is larger than destination buffer 'output[5]', use %4s to prevent overflowing it.\n"

"[test.cpp:4]: (warning) sscanf() without field width limits can crash with huge input data.\n", errout.str());

check("void foo() {\n"

" const size_t BUFLENGTH(2048);\n"

" typedef char bufT[BUFLENGTH];\n"

" bufT line= {0};\n"

" bufT projectId= {0};\n"

" const int scanrc=sscanf(line, \"Project(\\\"{%36s}\\\")\", projectId);\n"

" sscanf(input, \"%5s\", output);\n"

"}", true);

ASSERT_EQUALS("[test.cpp:6]: (warning, inconclusive) Width 36 given in format string (no. 1) is smaller than destination buffer 'projectId[2048]'.\n", errout.str());

check("void foo(unsigned int i) {\n"

" scanf(\"%h\", &i);\n"

" scanf(\"%hh\", &i);\n"

" scanf(\"%l\", &i);\n"

" scanf(\"%ll\", &i);\n"

" scanf(\"%j\", &i);\n"

" scanf(\"%z\", &i);\n"

" scanf(\"%t\", &i);\n"

" scanf(\"%L\", &i);\n"

" scanf(\"%I\", &i);\n"

"}");

ASSERT_EQUALS("[test.cpp:2]: (warning) 'h' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:3]: (warning) 'hh' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:4]: (warning) 'l' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:5]: (warning) 'll' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:6]: (warning) 'j' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:7]: (warning) 'z' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:8]: (warning) 't' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:9]: (warning) 'L' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n"

"[test.cpp:10]: (warning) 'I' in format string (no. 1) is a length modifier and cannot be used without a conversion specifier.\n", errout.str());

// Unrecognized (and non-existent in standard library) specifiers.

// Perhaps should emit warnings

TEST_SCANF_NOWARN("%jb", "intmax_t", "intmax_t");

TEST_SCANF_NOWARN("%jw", "uintmax_t", "uintmax_t");

TEST_SCANF_NOWARN("%zr", "size_t", "size_t");

TEST_SCANF_NOWARN("%tm", "ptrdiff_t", "ptrdiff_t");

TEST_SCANF_NOWARN("%La", "long double", "long double");

TEST_SCANF_NOWARN("%zv", "std::size_t", "std::size_t");

TEST_SCANF_NOWARN("%tp", "std::ptrdiff_t", "std::ptrdiff_t");

TEST_SCANF_WARN("%u", "unsigned int", "bool");

TEST_SCANF_WARN("%u", "unsigned int", "char");

TEST_SCANF_WARN("%u", "unsigned int", "signed char");

TEST_SCANF_WARN("%u", "unsigned int", "unsigned char");

TEST_SCANF_WARN("%u", "unsigned int", "signed short");

TEST_SCANF_WARN("%u", "unsigned int", "unsigned short");

TEST_SCANF_WARN("%u", "unsigned int", "signed int");

TEST_SCANF_NOWARN("%u", "unsigned int", "unsigned int");

TEST_SCANF_WARN("%u", "unsigned int", "signed long");

TEST_SCANF_WARN("%u", "unsigned int", "unsigned long");

TEST_SCANF_WARN("%u", "unsigned int", "signed long long");

TEST_SCANF_WARN("%u", "unsigned int", "unsigned long long");

TEST_SCANF_WARN("%u", "unsigned int", "float");

TEST_SCANF_WARN("%u", "unsigned int", "double");

TEST_SCANF_WARN("%u", "unsigned int", "long double");

TEST_SCANF_WARN("%u", "unsigned int", "void *");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "size_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "ssize_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "ptrdiff_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "unsigned ptrdiff_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "intmax_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "uintmax_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "intptr_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "uintptr_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::size_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::ssize_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::ptrdiff_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::intmax_t", "signed long", "signed long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::uintmax_t", "unsigned long", "unsigned long long");

TEST_SCANF_WARN_AKA("%u", "unsigned int", "std::intptr_t", "signed long", "signed long long");