added BitCount method

bangbite · bangbite · commit b24783e014d2 · 2013-06-05T16:06:57.000+02:00
diff --git a/src/ServiceStack.Redis/Commands.cs b/src/ServiceStack.Redis/Commands.cs
@@ -78,6 +78,7 @@ public static class Commands
         public readonly static byte[] SetRange = "SETRANGE".ToUtf8Bytes();
         public readonly static byte[] GetBit = "GETBIT".ToUtf8Bytes();
         public readonly static byte[] SetBit = "SETBIT".ToUtf8Bytes();
+        public readonly static byte[] BitCount = "BITCOUNT".ToUtf8Bytes();
 
         public readonly static byte[] RPush = "RPUSH".ToUtf8Bytes();
         public readonly static byte[] LPush = "LPUSH".ToUtf8Bytes();
diff --git a/src/ServiceStack.Redis/Generic/RedisTypedTransaction.cs b/src/ServiceStack.Redis/Generic/RedisTypedTransaction.cs
@@ -101,7 +101,7 @@ public bool Commit()
                     queuedCommand.ProcessResult();
                 }
             }
-            catch (RedisTransactionFailedException e)
+            catch (RedisTransactionFailedException)
             {
                 rc = false;
             }
diff --git a/src/ServiceStack.Redis/RedisNativeClient.cs b/src/ServiceStack.Redis/RedisNativeClient.cs
@@ -546,6 +546,14 @@ public long SetBit(string key, int offset, int value)
             return SendExpectLong(Commands.SetBit, key.ToUtf8Bytes(), offset.ToUtf8Bytes(), value.ToUtf8Bytes());
         }
 
+        public long BitCount(string key)
+        {
+            if (key == null)
+                throw new ArgumentNullException("key");
+
+            return SendExpectLong(Commands.BitCount, key.ToUtf8Bytes());
+        }
+
         public string RandomKey()
         {
             return SendExpectData(Commands.RandomKey).FromUtf8Bytes();
diff --git a/src/ServiceStack.Redis/Transaction/RedisTransaction.cs b/src/ServiceStack.Redis/Transaction/RedisTransaction.cs
@@ -100,7 +100,7 @@ public bool Commit()
                     queuedCommand.ProcessResult();
                 }
             }
-            catch (RedisTransactionFailedException e)
+            catch (RedisTransactionFailedException)
             {
                 rc = false;
             }
diff --git a/tests/ServiceStack.Redis.Tests/Generic/RedisClientTests.cs b/tests/ServiceStack.Redis.Tests/Generic/RedisClientTests.cs
@@ -116,12 +116,13 @@ public void Can_StoreAll_RedisTypedClient()
 		}
         
         [Test]
-        public void Can_SetBit_And_GetBit()
+        public void Can_SetBit_And_GetBit_And_BitCount()
         {
             const string key = "BitKey";
             const int offset = 100;
             Redis.SetBit(key, offset, 1);
             Assert.AreEqual(1, Redis.GetBit(key,offset));
+            Assert.AreEqual(1, Redis.BitCount(key));
         }
 
 		[Test, Explicit]

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public bool Commit()`
`101`	`101`	`queuedCommand.ProcessResult();`
`102`	`102`	`}`
`103`	`103`	`}`
`104`		`- catch (RedisTransactionFailedException e)`
	`104`	`+ catch (RedisTransactionFailedException)`
`105`	`105`	`{`
`106`	`106`	`rc = false;`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -546,6 +546,14 @@ public long SetBit(string key, int offset, int value)`
`546`	`546`	`return SendExpectLong(Commands.SetBit, key.ToUtf8Bytes(), offset.ToUtf8Bytes(), value.ToUtf8Bytes());`
`547`	`547`	`}`
`548`	`548`
	`549`	`+ public long BitCount(string key)`
	`550`	`+ {`
	`551`	`+ if (key == null)`
	`552`	`+ throw new ArgumentNullException("key");`
	`553`	`+`
	`554`	`+ return SendExpectLong(Commands.BitCount, key.ToUtf8Bytes());`
	`555`	`+ }`
	`556`	`+`
`549`	`557`	`public string RandomKey()`
`550`	`558`	`{`
`551`	`559`	`return SendExpectData(Commands.RandomKey).FromUtf8Bytes();`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public bool Commit()`
`100`	`100`	`queuedCommand.ProcessResult();`
`101`	`101`	`}`
`102`	`102`	`}`
`103`		`- catch (RedisTransactionFailedException e)`
	`103`	`+ catch (RedisTransactionFailedException)`
`104`	`104`	`{`
`105`	`105`	`rc = false;`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -116,12 +116,13 @@ public void Can_StoreAll_RedisTypedClient()`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`[Test]`
`119`		`- public void Can_SetBit_And_GetBit()`
	`119`	`+ public void Can_SetBit_And_GetBit_And_BitCount()`
`120`	`120`	`{`
`121`	`121`	`const string key = "BitKey";`
`122`	`122`	`const int offset = 100;`
`123`	`123`	`Redis.SetBit(key, offset, 1);`
`124`	`124`	`Assert.AreEqual(1, Redis.GetBit(key,offset));`
	`125`	`+ Assert.AreEqual(1, Redis.BitCount(key));`
`125`	`126`	`}`
`126`	`127`
`127`	`128`	`[Test, Explicit]`