Fix redis 3.2 error when INCR empty key

xplicit · xplicit · commit 49a82afd9303 · 2016-11-07T13:43:23.000+07:00
Since 3.2 redis raises error when client tries to use INCR on empty key. So `SET test=""; INCR test;` does no longer work, but RedisClient saves integers as empty strings if the value of integer is "0".  This commit always sets integer value to the key despite of the integer value.
diff --git a/src/ServiceStack.Redis/RedisClient.ICacheClient.cs b/src/ServiceStack.Redis/RedisClient.ICacheClient.cs
@@ -52,10 +52,22 @@ public T Get<T>(string key)
             );
         }
 
+        //Looking up Dictionary<Type,bool> for type is faster than HashSet<Type>.
+        private static Dictionary<Type, bool> integralTypes = new Dictionary<Type, bool> {
+            { typeof(byte), true },
+            { typeof(sbyte), true},
+            { typeof(short), true},
+            { typeof(ushort), true},
+            { typeof(int), true},
+            { typeof(uint), true },
+            { typeof(long), true},
+            { typeof(ulong), true},
+        };
+
         private static byte[] ToBytes<T>(T value)
         {
             var bytesValue = value as byte[];
-            if (bytesValue == null && !Equals(value, default(T)))
+            if (bytesValue == null && (integralTypes.ContainsKey(typeof(T)) || !Equals(value, default(T))))
                 bytesValue = value.ToJson().ToUtf8Bytes();
             return bytesValue;
         }
diff --git a/tests/ServiceStack.Redis.Tests/RedisCacheClientTests.cs b/tests/ServiceStack.Redis.Tests/RedisCacheClientTests.cs
@@ -124,5 +124,16 @@ public void Can_GetTimeToLive()
             ttl = cacheClient.GetTimeToLive(key);
             Assert.That(ttl, Is.Null);
         }
+
+        [Test]
+        public void Can_increment_and_reset_values()
+        {
+            using (var client = new RedisManagerPool(TestConfig.SingleHost).GetCacheClient())
+            {
+                Assert.That(client.Increment("incr:counter", 10), Is.EqualTo(10));
+                client.Set("incr:counter", 0);
+                Assert.That(client.Increment("incr:counter", 10), Is.EqualTo(10));
+            }
+        }
     }
 }
diff --git a/tests/ServiceStack.Redis.Tests/project.json b/tests/ServiceStack.Redis.Tests/project.json
@@ -21,7 +21,7 @@
       "type": "platform",
       "version": "1.0.0"
     },
-    "NUnitLite" : "3.2.1",
+    "NUnitLite" : "3.5",
     "ServiceStack.Redis" : "1.0.*",
     "ServiceStack.Interfaces" : "1.0.*",
     "ServiceStack.Text" : "1.0.*",

Original file line number	Diff line number	Diff line change
`@@ -124,5 +124,16 @@ public void Can_GetTimeToLive()`
`124`	`124`	`ttl = cacheClient.GetTimeToLive(key);`
`125`	`125`	`Assert.That(ttl, Is.Null);`
`126`	`126`	`}`
	`127`	`+`
	`128`	`+ [Test]`
	`129`	`+ public void Can_increment_and_reset_values()`
	`130`	`+ {`
	`131`	`+ using (var client = new RedisManagerPool(TestConfig.SingleHost).GetCacheClient())`
	`132`	`+ {`
	`133`	`+ Assert.That(client.Increment("incr:counter", 10), Is.EqualTo(10));`
	`134`	`+ client.Set("incr:counter", 0);`
	`135`	`+ Assert.That(client.Increment("incr:counter", 10), Is.EqualTo(10));`
	`136`	`+ }`
	`137`	`+ }`
`127`	`138`	`}`
`128`	`139`	`}`