Log error message in MQ Handler

mythz · mythz · commit 7edcd505a36f · 2024-01-12T20:22:42.000+08:00
diff --git a/ServiceStack/src/ServiceStack/Messaging/MessageHandler.cs b/ServiceStack/src/ServiceStack/Messaging/MessageHandler.cs
@@ -52,7 +52,7 @@ public MessageHandler(IMessageService messageService,
         this.processInExceptionFn = processInExceptionFn ?? DefaultInExceptionHandler;
         this.retryCount = retryCount;
         this.ReplyClientFactory = ClientFactory.Create;
-        this.ProcessQueueNames = new[] { QueueNames<T>.Priority, QueueNames<T>.In };
+        this.ProcessQueueNames = [QueueNames<T>.Priority, QueueNames<T>.In];
     }
 
     public Type MessageType => typeof(T);
@@ -157,6 +157,7 @@ public void ProcessMessage(IMessageQueueClient mqClient, IMessage<T> message)
                 var isError = responseStatus?.ErrorCode != null;
                 if (isError)
                 {
+                    Log.ErrorFormat("Failed to process MQ message {0}: {1} {2}", typeof(T).Name, responseStatus.ErrorCode, responseStatus.Message);
                     responseEx = new MessagingException(responseStatus, response);
                 }
             }
@@ -265,8 +266,7 @@ public void ProcessMessage(IMessageQueueClient mqClient, IMessage<T> message)
                 }
 
                 //Otherwise send to our trusty response Queue (inc if replyClient fails)
-                if (responseMessage == null)
-                    responseMessage = MessageFactory.Create(response);
+                responseMessage ??= MessageFactory.Create(response);
 
                 responseMessage.ReplyId = message.Id;
                 Diagnostics.ServiceStack.WriteMqRequestPublish(id, mqClient, responseMessage.ReplyId.ToString(), response);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public MessageHandler(IMessageService messageService,`
`52`	`52`	`this.processInExceptionFn = processInExceptionFn ?? DefaultInExceptionHandler;`
`53`	`53`	`this.retryCount = retryCount;`
`54`	`54`	`this.ReplyClientFactory = ClientFactory.Create;`
`55`		`- this.ProcessQueueNames = new[] { QueueNames<T>.Priority, QueueNames<T>.In };`
	`55`	`+ this.ProcessQueueNames = [QueueNames<T>.Priority, QueueNames<T>.In];`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`public Type MessageType => typeof(T);`
`@@ -157,6 +157,7 @@ public void ProcessMessage(IMessageQueueClient mqClient, IMessage<T> message)`
`157`	`157`	`var isError = responseStatus?.ErrorCode != null;`
`158`	`158`	`if (isError)`
`159`	`159`	`{`
	`160`	`+ Log.ErrorFormat("Failed to process MQ message {0}: {1} {2}", typeof(T).Name, responseStatus.ErrorCode, responseStatus.Message);`
`160`	`161`	`responseEx = new MessagingException(responseStatus, response);`
`161`	`162`	`}`
`162`	`163`	`}`
`@@ -265,8 +266,7 @@ public void ProcessMessage(IMessageQueueClient mqClient, IMessage<T> message)`
`265`	`266`	`}`
`266`	`267`
`267`	`268`	`//Otherwise send to our trusty response Queue (inc if replyClient fails)`
`268`		`- if (responseMessage == null)`
`269`		`- responseMessage = MessageFactory.Create(response);`
	`269`	`+ responseMessage ??= MessageFactory.Create(response);`
`270`	`270`
`271`	`271`	`responseMessage.ReplyId = message.Id;`
`272`	`272`	`Diagnostics.ServiceStack.WriteMqRequestPublish(id, mqClient, responseMessage.ReplyId.ToString(), response);`