Skip to content

Commit 389461a

Browse files
ivoanjobmoffatt
ivoanjo
authored and
bmoffatt
committed
Add missing xml namespace declarations to POM files (aws#97)
Without these declarations, the XML file cannot be validated correctly. See examples: * <https://maven.apache.org/pom.html#Quick_Overview> * <https://github.com/aws/aws-sdk-java-v2/blob/master/aws-sdk-java/pom.xml> The tool I'm using actually tries to validate these before using them (<https://tiny.amazon.com/ibdzmlln/paste> -- Amazon internal link), so that's why I ran into issues. I'm assuming most tools don't have the validation enabled, so this is why others haven't reported this before. The same issue can be easily replicated by pasting the current POM files in <https://www.w3schools.com/xml/xml_validator.asp> as well as just trying to open them with Firefox. (P.s: Hello there Lambda team! We recently met in your Dublin office!)
1 parent b45419d commit 389461a

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

‎aws-lambda-java-core/pom.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0"
2+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
24
<modelVersion>4.0.0</modelVersion>
35

46
<groupId>com.amazonaws</groupId>

‎aws-lambda-java-events/pom.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0"
2+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
24
<modelVersion>4.0.0</modelVersion>
35

46
<groupId>com.amazonaws</groupId>

‎aws-lambda-java-log4j/pom.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0"
2+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
24
<modelVersion>4.0.0</modelVersion>
35

46
<groupId>com.amazonaws</groupId>

‎aws-lambda-java-log4j2/pom.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0"
2+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
24
<modelVersion>4.0.0</modelVersion>
35

46
<groupId>com.amazonaws</groupId>

0 commit comments

Comments
 (0)