Fixed sapi/tests (maybe needs some run-test.php people's reviewing)

laruence · laruence · commit c17029315fa3 · 2015-05-27T17:37:34.000+08:00
diff --git a/run-tests.php b/run-tests.php
@@ -1662,9 +1662,15 @@ function run_test($php, $file, $env)
 	}
 
 	$env['REDIRECT_STATUS'] = '1';
-	$env['QUERY_STRING']    = $query_string;
-	$env['PATH_TRANSLATED'] = $test_file;
-	$env['SCRIPT_FILENAME'] = $test_file;
+	if (empty($env['QUERY_STRING'])) {
+		$env['QUERY_STRING']    = $query_string;
+	}
+	if (empty($env['PATH_TRANSLATED'])) {
+		$env['PATH_TRANSLATED'] = $test_file;
+	}
+	if (empty($env['SCRIPT_FILENAME'])) {
+		$env['SCRIPT_FILENAME'] = $test_file;
+	}
 
 	if (array_key_exists('COOKIE', $section_text)) {
 		$env['HTTP_COOKIE'] = trim($section_text['COOKIE']);
@@ -1745,12 +1751,18 @@ function run_test($php, $file, $env)
 	} else if (array_key_exists('POST', $section_text) && !empty($section_text['POST'])) {
 
 		$post = trim($section_text['POST']);
-		save_text($tmp_post, $post);
+		file_put_contents("/tmp/post", $post);
 		$content_length = strlen($post);
+		save_text($tmp_post, $post);
 
 		$env['REQUEST_METHOD'] = 'POST';
-		$env['CONTENT_TYPE']   = 'application/x-www-form-urlencoded';
-		$env['CONTENT_LENGTH'] = $content_length;
+		if (empty($env['CONTENT_TYPE'])) {
+			$env['CONTENT_TYPE']   = 'application/x-www-form-urlencoded';
+		}
+
+		if (empty($env['CONTENT_LENGTH'])) {
+			$env['CONTENT_LENGTH'] = $content_length;
+		}
 
 		$cmd = "$php $pass_options $ini_settings -f \"$test_file\" 2>&1 < \"$tmp_post\"";
 
diff --git a/sapi/tests/test005.phpt b/sapi/tests/test005.phpt
@@ -22,6 +22,6 @@ END;
     echo "HELLO";
 ?>
 --EXPECTHEADERS--
-Status: 404
+Status: 404 Not Found
 --EXPECT--
-No input file specified.
+No input file specified.
diff --git a/sapi/tests/test006.phpt b/sapi/tests/test006.phpt
@@ -67,7 +67,7 @@ Array
             [type] => application/octet-stream
             [tmp_name] => %s
             [error] => 0
-            [size] => 21
+            [size] => 19
         )
 
 )

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ Array`
`67`	`67`	`[type] => application/octet-stream`
`68`	`68`	`[tmp_name] => %s`
`69`	`69`	`[error] => 0`
`70`		`- [size] => 21`
	`70`	`+ [size] => 19`
`71`	`71`	`)`
`72`	`72`
`73`	`73`	`)`