COM Host - Invalid compute of default value string length (dotnet#45728)

AaronRobinsonMSFT · web-flow · commit 8636dc8a76d6 · 2020-12-07T21:08:58.000-08:00
Incorrectly compute the length of the default string value
    for a registry key. This doesn't impact the actual COM
    registration but does impact tooling that helps with COM
    registration.
diff --git a/src/installer/corehost/cli/comhost/comhost.cpp b/src/installer/corehost/cli/comhost/comhost.cpp
@@ -269,7 +269,7 @@ namespace
             0,
             REG_SZ,
             reinterpret_cast<const BYTE*>(entry.type.c_str()),
-            static_cast<DWORD>(sizeof(entry.type.size() + 1) * sizeof(entry.type[0])));
+            static_cast<DWORD>((entry.type.size() + 1) * sizeof(entry.type[0])));
         if (res != ERROR_SUCCESS)
             return __HRESULT_FROM_WIN32(res);
 
@@ -346,7 +346,7 @@ namespace
             0,
             REG_SZ,
             reinterpret_cast<const BYTE*>(defServerName),
-            static_cast<DWORD>(sizeof(defServerName) * sizeof(defServerName[0])));
+            static_cast<DWORD>(sizeof(defServerName)));
         if (res != ERROR_SUCCESS)
             return __HRESULT_FROM_WIN32(res);
 
