Fix for inverse update on delete

aothms · aothms · commit 1c2587ba1984 · 2018-07-12T11:37:23.000+02:00
diff --git a/src/ifcparse/IfcParse.cpp b/src/ifcparse/IfcParse.cpp
@@ -1732,7 +1732,8 @@ void IfcFile::removeEntity(IfcUtil::IfcBaseClass* entity) {
 			entities_by_ref_t::iterator byref_it = byref.find(name);
 			if (byref_it != byref.end()) {
 				std::vector<unsigned>& ids = byref_it->second;
-				std::remove(ids.begin(), ids.end(), name);
+				std::vector<unsigned>::const_iterator removed_from = std::remove(ids.begin(), ids.end(), id);
+				ids.erase(removed_from, ids.end());
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1732,7 +1732,8 @@ void IfcFile::removeEntity(IfcUtil::IfcBaseClass* entity) {`
`1732`	`1732`	`entities_by_ref_t::iterator byref_it = byref.find(name);`
`1733`	`1733`	`if (byref_it != byref.end()) {`
`1734`	`1734`	`std::vector<unsigned>& ids = byref_it->second;`
`1735`		`- std::remove(ids.begin(), ids.end(), name);`
	`1735`	`+ std::vector<unsigned>::const_iterator removed_from = std::remove(ids.begin(), ids.end(), id);`
	`1736`	`+ ids.erase(removed_from, ids.end());`
`1736`	`1737`	`}`
`1737`	`1738`	`}`
`1738`	`1739`	`}`