Skip to content

Commit c21f6fc

Browse files
rchiodorchiodo
authored
Update icons (#7298)
1 parent 0d598e4 commit c21f6fc

37 files changed

Lines changed: 106 additions & 288 deletions

‎news/2 Fixes/7261.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update icons to newer look.

‎package-lock.json‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/datascience-ui/interactive-common/cell.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ export class Cell extends React.Component<ICellProps, ICellState> {
548548
extraButton = (
549549
<div className='plot-open-button'>
550550
<ImageButton baseTheme={this.props.baseTheme} tooltip={getLocString('DataScience.plotOpen', 'Expand image')} onClick={openClick}>
551-
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.OpenInNewWindow} />
551+
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.OpenPlot} />
552552
</ImageButton>
553553
</div>
554554
);

‎src/datascience-ui/native-editor/nativeEditor.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ export class NativeEditor extends React.Component<INativeEditorProps, IMainState
570570
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={switchImage} />
571571
</ImageButton>
572572
<ImageButton baseTheme={this.props.baseTheme} onClick={deleteCell} tooltip={getLocString('DataScience.deleteCell', 'Delete cell')}>
573-
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.Cancel} />
573+
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.Delete} />
574574
</ImageButton>
575575
</Flyout>
576576
</div>;

‎src/datascience-ui/plot/toolbar.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class Toolbar extends React.Component<IToolbarProps> {
4848
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.SaveAs}/>
4949
</ImageButton>
5050
<ImageButton baseTheme={this.props.baseTheme} onClick={this.props.deleteButtonClicked} disabled={!this.props.deleteButtonClicked} tooltip={getLocString('DataScience.deletePlot', 'Remove')}>
51-
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.Cancel}/>
51+
<Image baseTheme={this.props.baseTheme} class='image-button-image' image={ImageName.Delete}/>
5252
</ImageButton>
5353
</div>
5454
);

‎src/datascience-ui/react-common/image.tsx‎

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ export enum ImageName {
3737
InsertAbove,
3838
InsertBelow,
3939
SwitchToCode,
40-
SwitchToMarkdown
40+
SwitchToMarkdown,
41+
OpenPlot,
42+
RunAll,
43+
Delete
4144
}
4245

4346
// All of the images must be 'require' so that webpack doesn't rewrite the import as requiring a .default.
@@ -60,8 +63,8 @@ const images: { [key: string] : { light: string; dark: string } } = {
6063
},
6164
GatherCode:
6265
{
63-
light: require('./images/GatherCode/GatherCode_16x_vscode.svg'),
64-
dark : require('./images/GatherCode/GatherCode_16x_vscode.svg')
66+
light: require('./images/GatherCode/gather_light.svg'),
67+
dark : require('./images/GatherCode/gather_dark.svg')
6568
},
6669
GoToSourceCode:
6770
{
@@ -184,6 +187,21 @@ const images: { [key: string] : { light: string; dark: string } } = {
184187
{
185188
light: require('./images/SwitchToMarkdown/switchtomarkdown.svg'),
186189
dark : require('./images/SwitchToMarkdown/switchtomarkdown-inverse.svg')
190+
},
191+
OpenPlot:
192+
{
193+
light: require('./images/OpenPlot/plot_light.svg'),
194+
dark : require('./images/OpenPlot/plot_dark.svg')
195+
},
196+
RunAll:
197+
{
198+
light: require('./images/RunAll/run_all_light.svg'),
199+
dark : require('./images/RunAll/run_all_dark.svg')
200+
},
201+
Delete:
202+
{
203+
light: require('./images/Delete/delete_light.svg'),
204+
dark : require('./images/Delete/delete_dark.svg')
187205
}
188206
};
189207

‎src/datascience-ui/react-common/images/Cancel/Cancel_16xMD_vscode.svg‎

Lines changed: 3 additions & 1 deletion
Loading

‎src/datascience-ui/react-common/images/Cancel/Cancel_16xMD_vscode_dark.svg‎

Lines changed: 3 additions & 1 deletion
Loading

‎src/datascience-ui/react-common/images/Delete/delete_dark.svg‎

Lines changed: 3 additions & 0 deletions
Loading

‎src/datascience-ui/react-common/images/Delete/delete_light.svg‎

Lines changed: 4 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)