forked from coder/coder
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathwebsocket_internal_test.go
More file actions
360 lines (290 loc) · 10.8 KB
/
Copy pathwebsocket_internal_test.go
File metadata and controls
360 lines (290 loc) · 10.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
package httpapi
import (
"context"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/prometheus/client_golang/prometheus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"cdr.dev/slog/v3"
"github.com/coder/coder/v2/testutil"
"github.com/coder/quartz"
"github.com/coder/websocket"
)
// websocketPair sets up an httptest server with a websocket endpoint and
// returns the server-side conn. The server handler stays alive until ctx
// is done.
func websocketPair(ctx context.Context, t *testing.T) *websocket.Conn {
t.Helper()
serverConnCh := make(chan *websocket.Conn, 1)
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
conn, err := websocket.Accept(w, r, nil)
if err != nil {
return
}
serverConnCh <- conn
// Keep the handler alive so the HTTP server doesn't close
// the connection from under us.
<-ctx.Done()
}))
t.Cleanup(srv.Close)
//nolint:bodyclose
clientConn, _, err := websocket.Dial(ctx, srv.URL, nil)
require.NoError(t, err)
_ = clientConn.CloseRead(ctx) // Needed to handle pings/pongs.
t.Cleanup(func() {
_ = clientConn.Close(websocket.StatusNormalClosure, "test cleanup")
})
select {
case sc := <-serverConnCh:
_ = sc.CloseRead(ctx) // Needed to handle pings/pongs.
return sc
case <-ctx.Done():
t.Fatal("timed out waiting for server websocket accept")
return nil
}
}
// probeRecorder is a simple wrapper around a channel used to record probe results.
type probeRecorder struct {
T testing.TB
C chan ProbeResult
}
func (r *probeRecorder) record(_ context.Context, result ProbeResult) {
select {
case r.C <- result:
default:
r.T.Errorf("probeRecorder.C is full, dropping result %s", result)
}
}
func TestWSWatcher(t *testing.T) {
t.Parallel()
t.Run("ServerSideClose", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
mClock := quartz.NewMock(t)
rec := &probeRecorder{T: t, C: make(chan ProbeResult, 1)}
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
serverConn := websocketPair(ctx, t)
w := &WSWatcher{rec: rec.record, clk: mClock, interval: time.Second}
watchCtx := w.Watch(ctx, logger, serverConn)
// Wait for the ticker to be created, then release.
trap.MustWait(ctx).MustRelease(ctx)
// Close the server-side connection before the tick fires.
// The next ping will get a close/net.ErrClosed error.
_ = serverConn.Close(websocket.StatusGoingAway, "simulated teardown")
// Advance clock to trigger the tick.
mClock.Advance(time.Second).MustWait(ctx)
// The watch context should be canceled after probe failure.
select {
case <-watchCtx.Done():
case <-ctx.Done():
t.Fatal("timed out waiting for watch context to be canceled")
}
gotRes := testutil.RequireReceive(ctx, t, rec.C)
assert.Equal(t, ProbePeerClosed, gotRes, "expected ProbePeerClosed result")
// A closed connection is a normal shutdown condition. The
// error should be logged at Debug, not Error.
errorEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelError })
assert.Empty(t, errorEntries,
"closed connection should not produce error-level logs, got: %+v", errorEntries)
debugEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelDebug })
assert.NotEmpty(t, debugEntries,
"expected a debug-level log entry for the closed connection")
})
t.Run("ContextCanceled", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
mClock := quartz.NewMock(t)
rec := &probeRecorder{T: t, C: make(chan ProbeResult, 1)}
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
serverCtx, serverCancel := context.WithCancel(ctx)
serverConn := websocketPair(ctx, t)
w := &WSWatcher{rec: rec.record, clk: mClock, interval: time.Second}
watchCtx := w.Watch(serverCtx, logger, serverConn)
trap.MustWait(ctx).MustRelease(ctx)
// Cancel the parent context. The watcher should exit via
// the <-ctx.Done() branch without closing the conn.
serverCancel()
select {
case <-watchCtx.Done():
case <-ctx.Done():
t.Fatal("timed out waiting for watch context to be canceled")
}
errorEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelError })
assert.Empty(t, errorEntries,
"context cancellation should not produce error-level logs, got: %+v", errorEntries)
assert.Empty(t, rec.C, "expected no probes when context is canceled before tick")
})
t.Run("PingSucceeds", func(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithCancel(testutil.Context(t, testutil.WaitShort))
defer cancel()
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
mClock := quartz.NewMock(t)
rec := &probeRecorder{T: t, C: make(chan ProbeResult, 3)}
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
serverConn := websocketPair(ctx, t)
w := &WSWatcher{rec: rec.record, clk: mClock, interval: time.Second}
watchCtx := w.Watch(ctx, logger, serverConn)
t.Cleanup(func() {
<-watchCtx.Done()
})
trap.MustWait(ctx).MustRelease(ctx)
// Fire several ticks; pings should succeed each time.
for i := range 3 {
mClock.Advance(time.Second).MustWait(ctx)
gotRes := testutil.RequireReceive(ctx, t, rec.C)
assert.Equal(t, ProbeOK, gotRes, "expected probe result to be ProbeOK at tick %d", i+1)
}
// No logs should be emitted during normal operation.
errorEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelError })
assert.Empty(t, errorEntries,
"successful pings should not produce error-level logs, got: %+v", errorEntries)
debugEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelDebug })
assert.Empty(t, debugEntries,
"successful pings should not produce debug-level logs, got: %+v", debugEntries)
})
t.Run("RecordsPrometheusCounter", func(t *testing.T) {
t.Parallel()
// Use a real prometheus registry to verify end-to-end metric recording.
registry := prometheus.NewRegistry()
probes := prometheus.NewCounterVec(prometheus.CounterOpts{
Namespace: "coderd",
Subsystem: "api",
Name: "websocket_probes_total",
Help: "test",
}, []string{"path", "result"})
registry.MustRegister(probes)
recorder := func(ctx context.Context, r ProbeResult) {
probes.WithLabelValues("/test/path", string(r)).Inc()
}
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
mClock := quartz.NewMock(t)
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
ctx, cancel := context.WithCancel(testutil.Context(t, testutil.WaitShort))
defer cancel()
serverConn := websocketPair(ctx, t)
w := &WSWatcher{rec: recorder, clk: mClock, interval: time.Second}
watchCtx := w.Watch(ctx, logger, serverConn)
t.Cleanup(func() {
<-watchCtx.Done()
})
trap.MustWait(ctx).MustRelease(ctx)
mClock.Advance(time.Second).MustWait(ctx)
testutil.Eventually(ctx, t, func(context.Context) bool {
select {
case <-watchCtx.Done():
t.Fatal("watch context should not be canceled when pings succeed")
default:
}
metrics, err := registry.Gather()
require.NoError(t, err)
return testutil.PromCounterHasValue(t, metrics, 1,
"coderd_api_websocket_probes_total", "/test/path", "ok")
}, testutil.IntervalFast, "probe counter not incremented")
})
t.Run("ProbeTimeout", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
mClock := quartz.NewMock(t)
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
rec := &probeRecorder{T: t, C: make(chan ProbeResult, 1)}
pingCh := make(chan struct{})
closeCodeCh := make(chan websocket.StatusCode, 1)
fConn := &fakePingCloser{
pingFn: func(context.Context) error {
t.Log("ping")
close(pingCh)
// Determinism tradeoff: by returning DeadlineExceeded directly
// we lose coverage of the WithTimeout path in probe().
return context.DeadlineExceeded
},
closeFn: func(code websocket.StatusCode, _ string) error {
closeCodeCh <- code
return nil
},
}
w := &WSWatcher{rec: rec.record, clk: mClock, interval: time.Second}
watchCtx := w.Watch(ctx, logger, fConn)
trap.MustWait(ctx).MustRelease(ctx)
mClock.Advance(time.Second).MustWait(ctx)
_, _ = testutil.SoftTryReceive(ctx, t, pingCh)
select {
case <-watchCtx.Done():
case <-ctx.Done():
t.Fatal("timed out waiting for watch context to be canceled")
}
gotRes := testutil.RequireReceive(ctx, t, rec.C)
assert.Equal(t, ProbeTimeout, gotRes, "expected ProbeTimeout result")
gotCode := testutil.RequireReceive(ctx, t, closeCodeCh)
assert.Equal(t, websocket.StatusGoingAway, gotCode, "expected StatusGoingAway code")
// Timeout is an expected condition, should be Debug not Error.
errorEntries := sink.Entries(func(e slog.SinkEntry) bool { return e.Level == slog.LevelError })
assert.Empty(t, errorEntries,
"probe timeout should not produce error-level logs, got: %+v", errorEntries)
})
t.Run("ProbeError", func(t *testing.T) {
t.Parallel()
sink := testutil.NewFakeSink(t)
logger := sink.Logger()
mClock := quartz.NewMock(t)
trap := mClock.Trap().NewTicker("WSWatcher")
defer trap.Close()
rec := &probeRecorder{T: t, C: make(chan ProbeResult, 1)}
closeCodeCh := make(chan websocket.StatusCode, 1)
fConn := &fakePingCloser{
pingFn: func(context.Context) error {
return assert.AnError
},
closeFn: func(code websocket.StatusCode, _ string) error {
t.Log("close error", code)
closeCodeCh <- code
return nil
},
}
w := &WSWatcher{rec: rec.record, clk: mClock, interval: time.Second}
ctx, cancel := context.WithCancel(testutil.Context(t, testutil.WaitShort))
defer cancel()
watchCtx := w.Watch(ctx, logger, fConn)
t.Cleanup(func() {
<-watchCtx.Done()
})
trap.MustWait(ctx).MustRelease(ctx)
mClock.Advance(time.Second).MustWait(ctx)
gotRes := testutil.RequireReceive(ctx, t, rec.C)
assert.Equal(t, ProbeError, gotRes, "expected ProbeError result")
gotCode := testutil.RequireReceive(ctx, t, closeCodeCh)
assert.Equal(t, websocket.StatusGoingAway, gotCode)
// ProbeError should log at Error level (unlike other failures).
errorEntries := sink.Entries(func(e slog.SinkEntry) bool {
return e.Level == slog.LevelError
})
assert.NotEmpty(t, errorEntries, "ProbeError should produce error-level log")
})
}
// fakePingCloser is a test double for the pingCloser interface.
type fakePingCloser struct {
pingFn func(context.Context) error
closeFn func(websocket.StatusCode, string) error
}
func (f *fakePingCloser) Ping(ctx context.Context) error {
return f.pingFn(ctx)
}
func (f *fakePingCloser) Close(code websocket.StatusCode, reason string) error {
return f.closeFn(code, reason)
}