CLOUDSTACK-4048:[GSLB] Failed to assign more than one LB rule to a GSLB rule that is

murali-reddy · murali-reddy · commit cb6ff00ef6f4 · 2013-08-05T19:33:35.000+05:30
created with gslbmethod=leastconn

Netscaler nitro api to add gslb virtual servers fails for some reason if
both netmask and round robin methods are specified. So working around
with settign netmask to be null while updating vserver.
diff --git a/plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b/plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
@@ -1134,10 +1134,9 @@ private static void createVirtualServer(nitro_service client, String vserverName
                 vserver.set_cookietimeout(null);
                 vserver.set_domainname(null);
                 if (isUpdateSite) {
-                    if ("roundrobin".equalsIgnoreCase(lbMethod)) {
-                        vserver.set_netmask(null);
-                        vserver.set_v6netmasklen(null);
-                    }
+                    // both netmask and LB method can not be specified while update so set to null
+                    vserver.set_netmask(null);
+                    vserver.set_v6netmasklen(null);
                     gslbvserver.update(client, vserver);
                 } else {
                     gslbvserver.add(client, vserver);
