CLOUDSTACK-6020 ipv4 address can be a larger number then

DaanHoogland · DaanHoogland · commit b3829e54d6b7 · 2014-02-04T18:40:18.000+01:00
Interger.MAX_VALUE
diff --git a/utils/src/com/cloud/utils/net/Ip.java b/utils/src/com/cloud/utils/net/Ip.java
@@ -56,7 +56,7 @@ public String toString() {
     }
 
     public boolean isIp4() {
-        return ip < Integer.MAX_VALUE;
+        return ip <= 2L * Integer.MAX_VALUE + 1;
     }
 
     public boolean isIp6() {
diff --git a/utils/test/com/cloud/utils/net/IpTest.java b/utils/test/com/cloud/utils/net/IpTest.java
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.utils.net;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.Test;
+
+public class IpTest {
+
+    @Test
+    public void testUltimate() {
+        Ip max = new Ip(2L * Integer.MAX_VALUE +1 );
+        assertEquals("Maximal address not created", "255.255.255.255", max.addr());
+    }
+    @Test
+    public void testTurningOfTheCentury() {
+        Ip eve = new Ip(Integer.MAX_VALUE);
+        assertEquals("Minimal address not created", "127.255.255.255", eve.addr());
+        Ip dawn = new Ip(Integer.MAX_VALUE + 1L);
+        assertEquals("Minimal address not created", "128.0.0.0", dawn.addr());
+    }
+    @Test
+    public void testStart() {
+        Ip min = new Ip(0);
+        assertEquals("Minimal address not created", "0.0.0.0", min.addr());
+    }
+
+}

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public String toString() {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`public boolean isIp4() {`
`59`		`- return ip < Integer.MAX_VALUE;`
	`59`	`+ return ip <= 2L * Integer.MAX_VALUE + 1;`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`public boolean isIp6() {`