Add support for unquoting JSV keys to make it more JSON compatible

mythz · mythz · commit c9be909797fc · 2025-08-02T11:00:25.000+08:00
diff --git a/ServiceStack.Text/src/ServiceStack.Text/Jsv/JsvTypeSerializer.cs b/ServiceStack.Text/src/ServiceStack.Text/Jsv/JsvTypeSerializer.cs
@@ -360,7 +360,10 @@ public ReadOnlySpan<char> EatMapKey(ReadOnlySpan<char> value, ref int i)
                     if (!isLiteralQuote)
                         break;
                 }
-                return value.Slice(tokenStartPos, i - tokenStartPos);
+                var key = value.Slice(tokenStartPos, i - tokenStartPos);
+                if (key.Length > 2 && key[0] == JsWriter.QuoteChar) // Don't unquote empty keys
+                    key = key.Slice(1, key.Length - 2);
+                return key;
 
             //Is Type/Map, i.e. {...}
             case JsWriter.MapStartChar:
diff --git a/ServiceStack.Text/tests/ServiceStack.Text.Tests/JsvTests/JsvCollectionTests.cs b/ServiceStack.Text/tests/ServiceStack.Text.Tests/JsvTests/JsvCollectionTests.cs
@@ -58,5 +58,15 @@ public void Can_serialize_empty_collections()
 
             collection.PrintDump();
         }
+
+        [Test]
+        public void Can_deserialize_quoted_keys()
+        {
+            var itemArray = "[{\"key\":\"KEY\",\"value\":\"VAL\"}]";
+            var items = TypeSerializer.DeserializeFromString<Item[]>(itemArray);
+            var item = items[0];
+            Assert.That(item.Key, Is.EqualTo("KEY"));
+            Assert.That(item.Value, Is.EqualTo("VAL"));
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -58,5 +58,15 @@ public void Can_serialize_empty_collections()`
`58`	`58`
`59`	`59`	`collection.PrintDump();`
`60`	`60`	`}`
	`61`	`+`
	`62`	`+ [Test]`
	`63`	`+ public void Can_deserialize_quoted_keys()`
	`64`	`+ {`
	`65`	`+ var itemArray = "[{\"key\":\"KEY\",\"value\":\"VAL\"}]";`
	`66`	`+ var items = TypeSerializer.DeserializeFromString<Item[]>(itemArray);`
	`67`	`+ var item = items[0];`
	`68`	`+ Assert.That(item.Key, Is.EqualTo("KEY"));`
	`69`	`+ Assert.That(item.Value, Is.EqualTo("VAL"));`
	`70`	`+ }`
`61`	`71`	`}`
`62`	`72`	`}`