dts: fix build of the external device tree

patrickdelaunay · ashishverma2691 · commit 2cb607c1e848 · 2024-10-25T06:29:34.000+02:00
Return false on Makefile error to detect error as soon as possible. Without this patch, the Makefile error is displayed but U-Boot compilation continue and binary files are generated. Fixes: b702eab ("dts: update Makefile to build the external device tree") Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Change-Id: I995a4423a01a8c27ec9cab307af6457baec7584a Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/u-boot/+/413607 ACI: CIBUILD <MDG-smet-aci-builds@list.st.com> Tested-by: Amit MITTAL <amit.mittal@st.com> ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
diff --git a/dts/Makefile b/dts/Makefile
@@ -45,11 +45,12 @@ arch-dtbs:
 
 PHONY += arch-ext-dtbs
 arch-ext-dtbs: arch-dtbs
-	$(Q)test -e $(EXT_DTS) && (\
-		echo "  EXT_DTS in $(EXT_DTS)";\
+	$(Q)if [ -e $(EXT_DTS) ]; then \
+		echo "  EXT_DTS in $(EXT_DTS)"; \
 		$(MAKE) $(build)=$(EXT_DTS) dtbs && \
-		cp $(EXT_DTS)/*.dtb arch/$(ARCH)/dts/ || \
-		/bin/true) || /bin/true
+		(cp $(EXT_DTS)/*.dtb arch/$(ARCH)/dts/ || \
+		/bin/true) || /bin/false; \
+	else /bin/true; fi
 
 ifeq ($(CONFIG_SPL_BUILD),y)
 obj-$(CONFIG_OF_EMBED) := dt-spl.dtb.o
