Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: STMicroelectronics/linux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.6-stm32mp-r1
Choose a base ref
...
head repository: STMicroelectronics/linux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.6-stm32mp-r1.1
Choose a head ref
  • 16 commits
  • 12 files changed
  • 1 contributor

Commits on Dec 3, 2024

  1. media: dcmipp: fix pixel pipes capture device 

    Make the dcmipp_start_capture function a void function since
it always return 0.

Change-Id: I65d75e0f5ea319754ac23f460c4cdff562c844a0
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422026
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    dd863fc View commit details
    Browse the repository at this point in the history

  2. media: stm32: dcmipp: fix correct pixelproc/pixelcap mbus 

    Don't check vpix pointer in start_streaming function since the
video capture pixelformat is guaranteed to be valid since it is
set by the s_fmt function before.

Change-Id: I5c74a6143c52597d32951cc6babe299f7f293bbd
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422027
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f40c699 View commit details
    Browse the repository at this point in the history

  3. media: stm32: dcmipp: avoid vb2 buffer check at start_streaming 

    vb2 framework guarantee that we have a minimum amount of buffer
available when start_streaming is called hence there is no need
to check for buffer availability at this time.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Change-Id: I9dd44d149e9fb0ee124f9fa1eb5de3ed3053548d
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422028
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    4155cc6 View commit details
    Browse the repository at this point in the history

  4. media: stm32: dcmipp: pixelcap: protect start_streaming with irqlock 

    Protect end of start_streaming function with the irqlock to ensure
that interrupts are not handled before the end of initialization.
Moreover adjust the call ordering with what is done in bytecap.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Change-Id: Id88ebec41e17d767a849e706db80c39324818a20
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422029
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6c9545b View commit details
    Browse the repository at this point in the history

  5. Revert "media: stm32: dcmipp: avoid calling s_stream if state already… 

    … correct"

This reverts commit 74e563ab7038a47d30f6273fefb5cb0215b3f130.

Remove this method as it doesn't fix entirely the problem of multiple calls
to the v4l2_s_stream and doesn't allow to have correct concurrent access
handling to protect cases when multiple pipes are being used in parallel.

Change-Id: Ibd332754d56f13c5dc3e87db7e965bfef50f2d54
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/421287
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9d4b711 View commit details
    Browse the repository at this point in the history

  6. Revert "media: v4l: Don't turn on privacy LED if streamon fails" 

    This reverts commit 9a496f7.

Revert of this commit in order to remove the WARN_ON introduced
within the call_s_stream function.

Change-Id: Iddac8b39a469bbe6b610665585e018531ec8cc1c
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/421288
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f9dee51 View commit details
    Browse the repository at this point in the history

  7. Revert "media: v4l2-subdev: Document and enforce .s_stream() requirem… 

    …ents"

This reverts commit 35556d0.

Revert the commit introducing the WARN_ON within call_s_stream function
since current dcmipp driver behavior current requires to call s_stream
several times.  Preference is to remove this WARN_ON while waiting for
moving to the proper enable_streams / disable_streams ops within the
dcmipp driver.

Change-Id: I425d6b41551a0fb58bb0524adba97c5b97472404
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/421289
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    7fdd5f7 View commit details
    Browse the repository at this point in the history

  8. media: stm32: dcmipp: fix dcmipp_isp usecnt 

    Correct way usecnt is done within the dcmipp_isp by adding
a mutex to protect concurrent accesses from multiple capture
devices.

Change-Id: I908d0300ab3413c20d6da0a1e03b4d3dd9d24253
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/421290
Tested-by: Alain VOLMAT <alain.volmat@st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    1634411 View commit details
    Browse the repository at this point in the history

  9. media: stm32: dcmipp: add s_stream ref counting on dcmipp_input 

    In order to prevent calling s_stream several times on the source
subdev, count the number of time s_stream has been called from the
sink subdeves.

Change-Id: I7d36084712f9465590c83d0ae99cdaffe2dd250f
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/421291
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Hugues FRUCHET <hugues.fruchet@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    844922c View commit details
    Browse the repository at this point in the history

  10. media: i2c: gc2145: addition of RAW8 formats support 

    Adds support for RAW8 formats (BGGR/RGGB/RBRG/BRBG).

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil: fix typo: colospace -> colorspace]
(cherry picked from commit 24d76ba)

Change-Id: Iac355cd1e927eb61809d8c167877c04c06997905
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/416884
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    1d37206 View commit details
    Browse the repository at this point in the history

  11. media: stm32: dcmipp: fix TPG (test pattern generator) subdev 

    The YUV422 format given by the TPG is actually mapped on the CSI-2 YUV422
format, that is UYVY.

Change-Id: I1e829c9c67cd57e4491384d165f3900c0a005b8f
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422107
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    0e028d6 View commit details
    Browse the repository at this point in the history

  12. media: stm32: dcmipp: fix advertise aux pixelproc sink formats 

    Remove 2 duplicate YUV422 2X8 formats and only keep UYVY8_1X16
for csi input since that's the only one supported by the DCMIPP
to ensure correct behavior of the whole pipe.
Regarding parallel interface based pixelproc input, the pixel pipe
needs a YUYV8_2X8, aka 4 cycles, Y / U / Y / V hence removing the
other formats as input.

Change-Id: If40b96640a28ae4a39b9bd50a82de66633c9ed18
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422108
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    809bf8e View commit details
    Browse the repository at this point in the history

  13. media: dcmipp: fix dcmipp-isp subdev 

    The dcmipp pixel pipes expects one type of YUV422.
For CSI input, that is UYVY8_1X16, hence only keep this one
to ensure correct behavior of the whole pipe.
Regarding parallel interface input, the pixel pipe
needs a YUYV8_2X8, aka 4 cycles, Y / U / Y / V hence removing the
other formats as input.

Change-Id: I964e9f63148f50adbb0fd908790cd4010ec885a7
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422109
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    392c982 View commit details
    Browse the repository at this point in the history

  14. media: dcmipp: correct swap in YUYV data with parallel input 

    When used with parallel input, the DCMIPP is expecting data to come
in YUYV order (for all DUMP/MAIN and AUX pipes).  Not doing so will
lead to bad color generated by the pipes when processing is done.
The DUMP pipe is also doing by default a swap since, while it accepts
YUYV data, it will by default generate UYVY data.

Current implementation is not correct for parallel input since it is
performing a cycle swap on the input side and since the dump pipe is
also internally doing a swap, the data captured from the dump pipe are
correct, while the data captured from the main / aux pipes are not.

To correct this, only perform cycle swap when it is necessary, hence
changing from YUYV to UYVY for example, and for all parallel YUV MBUS,
add the P0PPCR based SWAPYUV to put back the data into the ordering of
the input.

Change-Id: I6e45570a58fb65dc8f55215fd0e24385e0f882c6
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422110
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    44ea73b View commit details
    Browse the repository at this point in the history

  15. media: stm32: dcmipp: fix RGB888 format support overall 

    Correct the swap cycle for the RGB888.  RGB888 is a 3 cycles format
in parallel, which cannot be swapped (and it is not necessary).
Performing cycle swap here was ignored by the HW.

Change-Id: Ic3f86f6aaddfcd6911d14aa91a52c1f40215cad6
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422111
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9c4c8db View commit details
    Browse the repository at this point in the history

  16. media: stm32: dcmipp: fix 32bit RGB format in pixelcap 

    Correct mapping between the V4L2 PIX format and DCMIPP formats.

Change-Id: Ie38561b1817f32fd8d8bc37565e7ccd24633018f
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/422112
Tested-by: Alain VOLMAT <alain.volmat@st.com>
Domain-Review: Philippe CORNU <philippe.cornu@foss.st.com>
Reviewed-by: Philippe CORNU <philippe.cornu@foss.st.com>
ACI: CITOOLS <MDG-smet-aci-reviews@list.st.com>
Reviewed-by: Alain VOLMAT <alain.volmat@st.com>
    @fourmone
    Alain Volmat authored and fourmone committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f1d0da4 View commit details
    Browse the repository at this point in the history
Loading