Skip to content

Commit e1800be

Browse files
authored
Merge pull request #11 from ruke47/jul-logger
Use JUL logger instead of System.{out,err}.println
2 parents 5fc7c60 + 5ee2b78 commit e1800be

2 files changed

Lines changed: 27 additions & 21 deletions

File tree

src/main/java/org/mitre/stix/ValidationErrorHandler.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,23 @@
88
import org.xml.sax.SAXParseException;
99
import org.xml.sax.SAXException;
1010

11+
import java.util.logging.Logger;
12+
1113
/**
1214
* Parsing and validating error handler
1315
*
1416
* @author nemonik (Michael Joseph Walsh <github.com@nemonik.com>) *
1517
*/
1618
public class ValidationErrorHandler implements ErrorHandler {
17-
19+
private static final Logger LOGGER = Logger.getLogger(ValidationErrorHandler.class.getName());
20+
1821
private void log(String type, SAXParseException e) {
19-
System.err.println("SAXParseException " + type);
20-
System.err.println("\tPublic ID: " + e.getPublicId());
21-
System.err.println("\tSystem ID: " + e.getSystemId());
22-
System.err.println("\tLine : " + e.getLineNumber());
23-
System.err.println("\tColumn : " + e.getColumnNumber());
24-
System.err.println("\tMessage : " + e.getMessage());
22+
LOGGER.warning("SAXParseException " + type);
23+
LOGGER.warning("\tPublic ID: " + e.getPublicId());
24+
LOGGER.warning("\tSystem ID: " + e.getSystemId());
25+
LOGGER.warning("\tLine : " + e.getLineNumber());
26+
LOGGER.warning("\tColumn : " + e.getColumnNumber());
27+
LOGGER.warning("\tMessage : " + e.getMessage());
2528
}
2629

2730
/* (non-Javadoc)
@@ -50,4 +53,4 @@ public void warning(SAXParseException e) throws SAXException {
5053
log("WARNING", e);
5154
throw e;
5255
}
53-
}
56+
}

src/main/java/org/mitre/stix/ValidationEventHandler.java

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,29 @@
55
package org.mitre.stix;
66

77
import javax.xml.bind.ValidationEvent;
8+
import java.util.logging.Logger;
89

910
public class ValidationEventHandler implements javax.xml.bind.ValidationEventHandler {
11+
private static final Logger LOGGER = Logger.getLogger(ValidationErrorHandler.class.getName());
12+
1013
/* (non-Javadoc)
1114
* @see javax.xml.bind.ValidationEventHandler#handleEvent(javax.xml.bind.ValidationEvent)
1215
*/
1316
public boolean handleEvent(ValidationEvent event) {
14-
System.out.println("");
15-
System.out.println("EventT");
16-
System.out.println("\tSeverity: " + event.getSeverity());
17-
System.out.println("\tMessage: " + event.getMessage());
18-
System.out.println("\tLinked Excpetion: " + event.getLinkedException());
19-
System.out.println("\tLocator");
20-
System.out.println("\tLine Number: "
17+
LOGGER.info("");
18+
LOGGER.info("EventT");
19+
LOGGER.info("\tSeverity: " + event.getSeverity());
20+
LOGGER.info("\tMessage: " + event.getMessage());
21+
LOGGER.info("\tLinked Excpetion: " + event.getLinkedException());
22+
LOGGER.info("\tLocator");
23+
LOGGER.info("\tLine Number: "
2124
+ event.getLocator().getLineNumber());
22-
System.out.println("\tColumn Number: "
25+
LOGGER.info("\tColumn Number: "
2326
+ event.getLocator().getColumnNumber());
24-
System.out.println("\tOffset: " + event.getLocator().getOffset());
25-
System.out.println("\tObject: " + event.getLocator().getObject());
26-
System.out.println("\tNode: " + event.getLocator().getNode());
27-
System.out.println("\tURL: " + event.getLocator().getURL());
27+
LOGGER.info("\tOffset: " + event.getLocator().getOffset());
28+
LOGGER.info("\tObject: " + event.getLocator().getObject());
29+
LOGGER.info("\tNode: " + event.getLocator().getNode());
30+
LOGGER.info("\tURL: " + event.getLocator().getURL());
2831
return true;
2932
}
30-
}
33+
}

0 commit comments

Comments
 (0)