Seal internal types in Microsoft.PowerShell.Commands.Management (PowerShell#25849)

xtqqczze · SIRMARGIN · commit ab03cf161b3f · 2025-12-11T03:33:19.000+02:00
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/CreateInstanceJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/CreateInstanceJob.cs
@@ -12,7 +12,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job wrapping invocation of a CreateInstance intrinsic CIM method.
     /// </summary>
-    internal class CreateInstanceJob : PropertySettingJob<CimInstance>
+    internal sealed class CreateInstanceJob : PropertySettingJob<CimInstance>
     {
         private CimInstance _resultFromCreateInstance;
         private CimInstance _resultFromGetInstance;
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/DeleteInstanceJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/DeleteInstanceJob.cs
@@ -12,7 +12,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job wrapping invocation of a DeleteInstance intrinsic CIM method.
     /// </summary>
-    internal class DeleteInstanceJob : MethodInvocationJobBase<object>
+    internal sealed class DeleteInstanceJob : MethodInvocationJobBase<object>
     {
         private readonly CimInstance _objectToDelete;
 
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/EnumerateAssociatedInstancesJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/EnumerateAssociatedInstancesJob.cs
@@ -14,7 +14,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job that handles executing a WQL (in the future CQL?) query on a remote CIM server.
     /// </summary>
-    internal class EnumerateAssociatedInstancesJob : QueryJobBase
+    internal sealed class EnumerateAssociatedInstancesJob : QueryJobBase
     {
         private readonly CimInstance _associatedObject;
         private readonly string _associationName;
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/InstanceMethodInvocationJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/InstanceMethodInvocationJob.cs
@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job wrapping invocation of an extrinsic CIM method.
     /// </summary>
-    internal class InstanceMethodInvocationJob : ExtrinsicMethodInvocationJob
+    internal sealed class InstanceMethodInvocationJob : ExtrinsicMethodInvocationJob
     {
         private readonly CimInstance _targetInstance;
 
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/ModifyInstanceJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/ModifyInstanceJob.cs
@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job wrapping invocation of a ModifyInstance intrinsic CIM method.
     /// </summary>
-    internal class ModifyInstanceJob : PropertySettingJob<CimInstance>
+    internal sealed class ModifyInstanceJob : PropertySettingJob<CimInstance>
     {
         private CimInstance _resultFromModifyInstance;
         private bool _resultFromModifyInstanceHasBeenPassedThru;
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/QueryJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/QueryJob.cs
@@ -14,7 +14,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job that handles executing a WQL (in the future CQL?) query on a remote CIM server.
     /// </summary>
-    internal class QueryInstancesJob : QueryJobBase
+    internal sealed class QueryInstancesJob : QueryJobBase
     {
         private readonly string _wqlQuery;
         private readonly bool _useEnumerateInstances;
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/StaticMethodInvocationJob.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/StaticMethodInvocationJob.cs
@@ -11,7 +11,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// Job wrapping invocation of a static CIM method.
     /// </summary>
-    internal class StaticMethodInvocationJob : ExtrinsicMethodInvocationJob
+    internal sealed class StaticMethodInvocationJob : ExtrinsicMethodInvocationJob
     {
         internal StaticMethodInvocationJob(CimJobContext jobContext, MethodInvocationInfo methodInvocationInfo)
                 : base(jobContext, false /* passThru */, jobContext.CmdletizationClassName, methodInvocationInfo)
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimCmdletDefinitionContext.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimCmdletDefinitionContext.cs
@@ -10,7 +10,7 @@
 
 namespace Microsoft.PowerShell.Cmdletization.Cim
 {
-    internal class CimCmdletDefinitionContext
+    internal sealed class CimCmdletDefinitionContext
     {
         internal CimCmdletDefinitionContext(
             string cmdletizationClassName,
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimCmdletInvocationContext.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimCmdletInvocationContext.cs
@@ -10,7 +10,7 @@
 
 namespace Microsoft.PowerShell.Cmdletization.Cim
 {
-    internal class CimCmdletInvocationContext
+    internal sealed class CimCmdletInvocationContext
     {
         internal CimCmdletInvocationContext(
             CimCmdletDefinitionContext cmdletDefinitionContext,
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimConverter.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimConverter.cs
@@ -24,7 +24,7 @@
 
 namespace Microsoft.PowerShell.Cim
 {
-    internal class CimSensitiveValueConverter : IDisposable
+    internal sealed class CimSensitiveValueConverter : IDisposable
     {
         private sealed class SensitiveString : IDisposable
         {
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimJobContext.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimJobContext.cs
@@ -9,7 +9,7 @@
 
 namespace Microsoft.PowerShell.Cmdletization.Cim
 {
-    internal class CimJobContext
+    internal sealed class CimJobContext
     {
         internal CimJobContext(
             CimCmdletInvocationContext cmdletInvocationContext,
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimQuery.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimQuery.cs
@@ -18,7 +18,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// <summary>
     /// CimQuery supports building of queries against CIM object model.
     /// </summary>
-    internal class CimQuery : QueryBuilder, ISessionBoundQueryBuilder<CimSession>
+    internal sealed class CimQuery : QueryBuilder, ISessionBoundQueryBuilder<CimSession>
     {
         private readonly StringBuilder _wqlCondition;
 
diff --git a/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/clientSideQuery.cs b/src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/clientSideQuery.cs
@@ -20,9 +20,9 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
     /// 1) filtering that cannot be translated into a server-side query (i.e. when CimQuery.WildcardToWqlLikeOperand reports that it cannot translate into WQL)
     /// 2) detecting if all expected results have been received and giving friendly user errors otherwise (i.e. could not find process with name='foo';  details in Windows 8 Bugs: #60926)
     /// </summary>
-    internal class ClientSideQuery : QueryBuilder
+    internal sealed class ClientSideQuery : QueryBuilder
     {
-        internal class NotFoundError
+        internal sealed class NotFoundError
         {
             public NotFoundError()
             {
@@ -530,7 +530,7 @@ private static bool WildcardEqual(string propertyName, object actualPropertyValu
             }
         }
 
-        internal class PropertyValueExcludeFilter : PropertyValueRegularFilter
+        internal sealed class PropertyValueExcludeFilter : PropertyValueRegularFilter
         {
             public PropertyValueExcludeFilter(string propertyName, object expectedPropertyValue, bool wildcardsEnabled, BehaviorOnNoMatch behaviorOnNoMatch)
                 : base(propertyName, expectedPropertyValue, wildcardsEnabled, behaviorOnNoMatch)
@@ -548,7 +548,7 @@ protected override bool IsMatchingValue(object actualPropertyValue)
             }
         }
 
-        internal class PropertyValueMinFilter : PropertyValueFilter
+        internal sealed class PropertyValueMinFilter : PropertyValueFilter
         {
             public PropertyValueMinFilter(string propertyName, object expectedPropertyValue, BehaviorOnNoMatch behaviorOnNoMatch)
                 : base(propertyName, expectedPropertyValue, behaviorOnNoMatch)
@@ -583,7 +583,7 @@ private static bool ActualValueGreaterThanOrEqualToExpectedValue(string property
             }
         }
 
-        internal class PropertyValueMaxFilter : PropertyValueFilter
+        internal sealed class PropertyValueMaxFilter : PropertyValueFilter
         {
             public PropertyValueMaxFilter(string propertyName, object expectedPropertyValue, BehaviorOnNoMatch behaviorOnNoMatch)
                 : base(propertyName, expectedPropertyValue, behaviorOnNoMatch)
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/ContentCommandBase.cs
@@ -244,7 +244,7 @@ internal void WriteContentObject(object content, long readCount, PathInfo pathIn
         /// as they get written to the pipeline. An instance of this cache class is
         /// only valid for a single path.
         /// </summary>
-        internal class ContentPathsCache
+        internal sealed class ContentPathsCache
         {
             /// <summary>
             /// Constructs a content cache item.

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim`
`12`	`12`	`/// <summary>`
`13`	`13`	`/// Job wrapping invocation of a CreateInstance intrinsic CIM method.`
`14`	`14`	`/// </summary>`
`15`		`- internal class CreateInstanceJob : PropertySettingJob<CimInstance>`
	`15`	`+ internal sealed class CreateInstanceJob : PropertySettingJob<CimInstance>`
`16`	`16`	`{`
`17`	`17`	`private CimInstance _resultFromCreateInstance;`
`18`	`18`	`private CimInstance _resultFromGetInstance;`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim`
`14`	`14`	`/// <summary>`
`15`	`15`	`/// Job that handles executing a WQL (in the future CQL?) query on a remote CIM server.`
`16`	`16`	`/// </summary>`
`17`		`- internal class EnumerateAssociatedInstancesJob : QueryJobBase`
	`17`	`+ internal sealed class EnumerateAssociatedInstancesJob : QueryJobBase`
`18`	`18`	`{`
`19`	`19`	`private readonly CimInstance _associatedObject;`
`20`	`20`	`private readonly string _associationName;`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim`
`13`	`13`	`/// <summary>`
`14`	`14`	`/// Job wrapping invocation of an extrinsic CIM method.`
`15`	`15`	`/// </summary>`
`16`		`- internal class InstanceMethodInvocationJob : ExtrinsicMethodInvocationJob`
	`16`	`+ internal sealed class InstanceMethodInvocationJob : ExtrinsicMethodInvocationJob`
`17`	`17`	`{`
`18`	`18`	`private readonly CimInstance _targetInstance;`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim`
`11`	`11`	`/// <summary>`
`12`	`12`	`/// Job wrapping invocation of a static CIM method.`
`13`	`13`	`/// </summary>`
`14`		`- internal class StaticMethodInvocationJob : ExtrinsicMethodInvocationJob`
	`14`	`+ internal sealed class StaticMethodInvocationJob : ExtrinsicMethodInvocationJob`
`15`	`15`	`{`
`16`	`16`	`internal StaticMethodInvocationJob(CimJobContext jobContext, MethodInvocationInfo methodInvocationInfo)`
`17`	`17`	`: base(jobContext, false /* passThru */, jobContext.CmdletizationClassName, methodInvocationInfo)`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`namespace Microsoft.PowerShell.Cmdletization.Cim`
`12`	`12`	`{`
`13`		`- internal class CimCmdletDefinitionContext`
	`13`	`+ internal sealed class CimCmdletDefinitionContext`
`14`	`14`	`{`
`15`	`15`	`internal CimCmdletDefinitionContext(`
`16`	`16`	`string cmdletizationClassName,`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`
`25`	`25`	`namespace Microsoft.PowerShell.Cim`
`26`	`26`	`{`
`27`		`- internal class CimSensitiveValueConverter : IDisposable`
	`27`	`+ internal sealed class CimSensitiveValueConverter : IDisposable`
`28`	`28`	`{`
`29`	`29`	`private sealed class SensitiveString : IDisposable`
`30`	`30`	`{`