Remove obsolete CA2233 rule suppression (PowerShell#25951)

xtqqczze · SIRMARGIN · commit 41be44fd2088 · 2025-12-11T03:33:23.000+02:00
diff --git a/src/System.Management.Automation/utils/perfCounters/CounterSetInstanceBase.cs b/src/System.Management.Automation/utils/perfCounters/CounterSetInstanceBase.cs
@@ -74,7 +74,6 @@ protected CounterSetInstanceBase(CounterSetRegistrarBase counterSetRegistrarInst
         /// But, if isNumerator is false, then a check is made on the input
         /// counter's type to ensure that denominator is indeed value for such a counter.
         /// </summary>
-        [SuppressMessage("Microsoft.Usage", "CA2233:OperationsShouldNotOverflow", Justification = "countId is validated as known denominator before it is incremented.")]
         protected bool RetrieveTargetCounterIdIfValid(int counterId, bool isNumerator, out int targetCounterId)
         {
             targetCounterId = counterId;

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ protected CounterSetInstanceBase(CounterSetRegistrarBase counterSetRegistrarInst`
`74`	`74`	`/// But, if isNumerator is false, then a check is made on the input`
`75`	`75`	`/// counter's type to ensure that denominator is indeed value for such a counter.`
`76`	`76`	`/// </summary>`
`77`		`- [SuppressMessage("Microsoft.Usage", "CA2233:OperationsShouldNotOverflow", Justification = "countId is validated as known denominator before it is incremented.")]`
`78`	`77`	`protected bool RetrieveTargetCounterIdIfValid(int counterId, bool isNumerator, out int targetCounterId)`
`79`	`78`	`{`
`80`	`79`	`targetCounterId = counterId;`