Update `test/support` to 3.14.5 by ShaharNaveh · Pull Request #7896 · RustPython/RustPython

ShaharNaveh · 2026-05-17T08:41:43Z

Summary by CodeRabbit

Chores
- Updated CI workflow test matrix configuration to explicitly include additional test cases (test_set) and clarify test skips for macOS, Ubuntu, and Windows builds.

coderabbitai · 2026-05-17T08:41:49Z

📝 Walkthrough

Walkthrough

This PR updates the CI test matrix configuration in the snippets_cpython job to explicitly declare env_polluting_tests to include test_set and set skips to an empty list for macOS, Ubuntu, and Windows entries.

Changes

CI Test Matrix Configuration

Layer / File(s)	Summary
Test matrix environment-polluting tests `.github/workflows/ci.yaml`	The `snippets_cpython` job matrix entries for macOS, Ubuntu, and Windows now include `test_set` in `env_polluting_tests` and explicitly set `skips` to `[]`, while preserving existing timeout and `extra_test_args` configurations.

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

youknowone

Poem

🐰 A rabbit hops through CI's hall,
Where tests must live, or skip them all,
test_set joins the matrix dance,
While skips stands empty—second chance!
Configuration tweaks with care,
Make workflows clean and bright and fair! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title refers to updating 'test/support' to version 3.14.5, but the actual changes are CI workflow configuration updates to the test matrix in .github/workflows/ci.yaml, which is unrelated.	Update the PR title to accurately describe the CI workflow changes, such as 'Update test matrix configuration for platform-specific test handling' or similar.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-17T08:42:31Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/io.py
[x] lib: cpython/Lib/_pyio.py
[ ] test: cpython/Lib/test/test_io.py (TODO: 14)
[x] test: cpython/Lib/test/test_bufio.py
[x] test: cpython/Lib/test/test_fileio.py (TODO: 1)
[ ] test: cpython/Lib/test/test_memoryio.py (TODO: 28)

dependencies:

io

dependent tests: (100 tests)

io: test__colorize test_android test_argparse test_ast test_asyncio test_base64 test_buffer test_bufio test_builtin test_bz2 test_calendar test_cmd test_cmd_line_script test_codecs test_compile test_compileall test_compiler_assemble test_concurrent_futures test_configparser test_contextlib test_csv test_dbm_dumb test_descr test_dis test_email test_enum test_file test_fileinput test_fileio test_ftplib test_getpass test_gzip test_hashlib test_http_cookiejar test_httplib test_httpservers test_importlib test_inspect test_io test_json test_largefile test_logging test_lzma test_mailbox test_marshal test_memoryio test_memoryview test_mimetypes test_minidom test_optparse test_pathlib test_pickle test_pickletools test_platform test_plistlib test_pprint test_print test_pty test_pulldom test_pydoc test_pyexpat test_quopri test_regrtest test_robotparser test_sax test_shlex test_shutil test_site test_smtplib test_socket test_socketserver test_subprocess test_support test_sys test_tarfile test_tempfile test_threadedtempfile test_timeit test_tokenize test_traceback test_types test_typing test_unittest test_univnewlines test_urllib test_urllib2 test_uuid test_wave test_webbrowser test_winconsoleio test_wsgiref test_xml_dom_xmlbuilder test_xml_etree test_xml_etree_c test_xmlrpc test_zipapp test_zipfile test_zipimport test_zoneinfo test_zstd

[x] test: cpython/Lib/test/test_iter.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on iter)

[x] test: cpython/Lib/test/test_str.py (TODO: 7)
[x] test: cpython/Lib/test/test_fstring.py (TODO: 19)
[x] test: cpython/Lib/test/test_string_literals.py (TODO: 4)

dependencies:

dependent tests: (no tests depend on str)

[x] test: cpython/Lib/test/test_module (TODO: 2)

dependencies:

dependent tests: (no tests depend on module)

[x] lib: cpython/Lib/threading.py
[x] lib: cpython/Lib/_threading_local.py
[ ] test: cpython/Lib/test/test_threading.py (TODO: 16)
[ ] test: cpython/Lib/test/test_threadedtempfile.py
[ ] test: cpython/Lib/test/test_threading_local.py (TODO: 3)

dependencies:

threading

dependent tests: (153 tests)

[x] test: cpython/Lib/test/test_dict.py (TODO: 6)
[x] test: cpython/Lib/test/test_dictcomps.py (TODO: 1)
[x] test: cpython/Lib/test/test_dictviews.py (TODO: 1)
[x] test: cpython/Lib/test/test_userdict.py
[x] test: cpython/Lib/test/mapping_tests.py

dependencies:

dependent tests: (no tests depend on dict)

[ ] lib: cpython/Lib/test/support
[x] test: cpython/Lib/test/test_support.py (TODO: 3)
[ ] test: cpython/Lib/test/test_script_helper.py

dependencies:

dependent tests: (1 tests)

support: test_pathlib

[ ] lib: cpython/Lib/collections
[x] lib: cpython/Lib/_collections_abc.py
[x] test: cpython/Lib/test/test_collections.py (TODO: 1)
[x] test: cpython/Lib/test/test_deque.py (TODO: 2)
[ ] test: cpython/Lib/test/test_defaultdict.py
[x] test: cpython/Lib/test/test_ordered_dict.py (TODO: 7)

dependencies:

collections

dependent tests: (305 tests)

[ ] lib: cpython/Lib/asyncio
[ ] test: cpython/Lib/test/test_asyncio (TODO: 28)

dependencies:

asyncio (native: _asyncio, _overlapped, _pyrepl.console, _pyrepl.main, _pyrepl.simple_interact, _remote_debugging, _winapi, asyncio.tools, base_events, collections.abc, concurrent.futures, coroutines, errno, events, exceptions, futures, graph, itertools, locks, log, math, msvcrt, protocols, queues, readline, runners, streams, sys, taskgroups, tasks, threads, time, timeouts, transports, unix_events, windows_events)
- site (native: _io, _pyrepl.main, _pyrepl.pager, _pyrepl.readline, _pyrepl.unix_console, _pyrepl.windows_console, atexit, builtins, errno, readline, sitecustomize, sys, usercustomize)
- collections, warnings
- _colorize, argparse, ast, contextlib, contextvars, dataclasses, enum, functools, heapq, inspect, io, linecache, logging, os, reprlib, rlcompleter, selectors, signal, socket, ssl, stat, struct, subprocess, threading, tokenize, traceback, types, weakref

dependent tests: (6 tests)

asyncio: test_asyncio test_inspect test_logging test_os test_sys_settrace test_unittest

[ ] test: cpython/Lib/test/test_array.py (TODO: 55)

dependencies:

dependent tests: (101 tests)

[ ] test: cpython/Lib/test/test_bytes.py (TODO: 22)

dependencies:

dependent tests: (no tests depend on bytes)

[x] test: cpython/Lib/test/test_descr.py (TODO: 34)
[ ] test: cpython/Lib/test/test_descrtut.py (TODO: 3)

dependencies:

dependent tests: (no tests depend on descr)

[ ] test: cpython/Lib/test/test_generators.py (TODO: 12)
[ ] test: cpython/Lib/test/test_genexps.py (TODO: 6)
[x] test: cpython/Lib/test/test_generator_stop.py
[x] test: cpython/Lib/test/test_yield_from.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on generator)

[x] lib: cpython/Lib/ast.py
[x] lib: cpython/Lib/_ast_unparse.py
[x] test: cpython/Lib/test/test_unparse.py
[x] test: cpython/Lib/test/test_type_comments.py (TODO: 15)

dependencies:

ast

dependent tests: (140 tests)

[x] test: cpython/Lib/test/test_slice.py

dependencies:

dependent tests: (no tests depend on slice)

[ ] test: cpython/Lib/test/test_set.py (TODO: 6)

dependencies:

dependent tests: (no tests depend on set)

[x] lib: cpython/Lib/xml
[x] test: cpython/Lib/test/test_xml_etree.py (TODO: 61)
[x] test: cpython/Lib/test/test_xml_etree_c.py
[x] test: cpython/Lib/test/test_minidom.py (TODO: 25)
[x] test: cpython/Lib/test/test_pulldom.py (TODO: 4)
[x] test: cpython/Lib/test/test_pyexpat.py (TODO: 30)
[x] test: cpython/Lib/test/test_sax.py (TODO: 39)
[x] test: cpython/Lib/test/test_xml_dom_minicompat.py
[x] test: cpython/Lib/test/test_xml_dom_xmlbuilder.py

dependencies:

xml

dependent tests: (35 tests)

xml: test_doctest test_minidom test_pulldom test_pydoc test_pyexpat test_regrtest test_sax test_typing test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml_etree
- plistlib: test_plistlib
  - platform: test__locale test__osx_support test_android test_asyncio test_baseexception test_builtin test_cmath test_ctypes test_fcntl test_math test_mimetypes test_os test_platform test_posix test_shutil test_socket test_ssl test_strptime test_sysconfig test_time test_winreg test_wsgiref
- xmlrpc.client: test_xmlrpc

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/ci.yaml (1)
293-294: ⚡ Quick win

Consider adding a brief inline comment explaining the test_set addition.

The addition of test_set to env_polluting_tests is correct—the test file itself contains a decorator (@unittest.skipIf("RUSTPYTHON_SKIP_ENV_POLLUTERS"...) at line 366) confirming it exhibits environment-polluting behavior. This aligns with commit 2896c983 ("Add test_set to env polluting tests"), which shows this was intentionally added during recent CPython version updates.

For clarity, consider adding an inline comment like # Pollutes environment—see test_set.py:366 to document why it appears in this matrix.

Also applies to: 300-301, 306-307
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yaml around lines 293 - 294, Add a short inline comment
next to the env_polluting_tests entry for test_set explaining why it is listed
(e.g., "Pollutes environment—see test_set.py:366") so future readers understand
it was intentionally added; update the three similar occurrences where test_set
is added to the matrix (the env_polluting_tests lists) and include the same
brief note and optional reference to commit 2896c983 for context.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/ci.yaml:
- Around line 293-294: Add a short inline comment next to the
env_polluting_tests entry for test_set explaining why it is listed (e.g.,
"Pollutes environment—see test_set.py:366") so future readers understand it was
intentionally added; update the three similar occurrences where test_set is
added to the matrix (the env_polluting_tests lists) and include the same brief
note and optional reference to commit 2896c983 for context.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ed1fd43d-1232-49cf-a7bc-e2560f52232d

📥 Commits

Reviewing files that changed from the base of the PR and between f4f0350 and 2896c98.

⛔ Files ignored due to path filters (37)

Lib/test/seq_tests.py is excluded by !Lib/**
Lib/test/support/__init__.py is excluded by !Lib/**
Lib/test/support/_hypothesis_stubs/__init__.py is excluded by !Lib/**
Lib/test/support/ast_helper.py is excluded by !Lib/**
Lib/test/support/asyncore.py is excluded by !Lib/**
Lib/test/support/bytecode_helper.py is excluded by !Lib/**
Lib/test/support/channels.py is excluded by !Lib/**
Lib/test/support/hashlib_helper.py is excluded by !Lib/**
Lib/test/support/hypothesis_helper.py is excluded by !Lib/**
Lib/test/support/i18n_helper.py is excluded by !Lib/**
Lib/test/support/logging_helper.py is excluded by !Lib/**
Lib/test/support/os_helper.py is excluded by !Lib/**
Lib/test/support/pty_helper.py is excluded by !Lib/**
Lib/test/support/script_helper.py is excluded by !Lib/**
Lib/test/support/smtpd.py is excluded by !Lib/**
Lib/test/support/socket_helper.py is excluded by !Lib/**
Lib/test/support/strace_helper.py is excluded by !Lib/**
Lib/test/support/threading_helper.py is excluded by !Lib/**
Lib/test/support/venv.py is excluded by !Lib/**
Lib/test/test_array.py is excluded by !Lib/**
Lib/test/test_ast/test_ast.py is excluded by !Lib/**
Lib/test/test_asyncio/test_sslproto.py is excluded by !Lib/**
Lib/test/test_asyncio/test_tasks.py is excluded by !Lib/**
Lib/test/test_bytes.py is excluded by !Lib/**
Lib/test/test_descr.py is excluded by !Lib/**
Lib/test/test_dict.py is excluded by !Lib/**
Lib/test/test_generators.py is excluded by !Lib/**
Lib/test/test_io.py is excluded by !Lib/**
Lib/test/test_iter.py is excluded by !Lib/**
Lib/test/test_module/__init__.py is excluded by !Lib/**
Lib/test/test_ordered_dict.py is excluded by !Lib/**
Lib/test/test_set.py is excluded by !Lib/**
Lib/test/test_slice.py is excluded by !Lib/**
Lib/test/test_str.py is excluded by !Lib/**
Lib/test/test_support.py is excluded by !Lib/**
Lib/test/test_threading_local.py is excluded by !Lib/**
Lib/test/test_xml_etree.py is excluded by !Lib/**

📒 Files selected for processing (1)

.github/workflows/ci.yaml

Update test/support to 3.14.5

c1058ca

ShaharNaveh added 4 commits May 17, 2026 13:27

Adjuat test markers

03bf499

Merge remote-tracking branch 'upstream/main' into update-support

5b92c7a

Merge remote-tracking branch 'upstream/main' into update-support

d015e06

Add test_set to env polluting tests

2896c98

ShaharNaveh marked this pull request as ready for review May 17, 2026 12:54

coderabbitai Bot reviewed May 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `test/support` to 3.14.5#7896

Update `test/support` to 3.14.5#7896
ShaharNaveh wants to merge 5 commits into
RustPython:mainfrom
ShaharNaveh:update-support

ShaharNaveh commented May 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 17, 2026 •

edited

Loading

Walkthrough

Changes

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ShaharNaveh commented May 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ShaharNaveh commented May 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 17, 2026 •

edited

Loading

github-actions Bot commented May 17, 2026 •

edited

Loading