From e0bf0f86f509bcef6502627e91e76d0411089427 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 10:17:04 +0100 Subject: [PATCH 1/6] Add actionlint step --- .github/workflows/ci.yaml | 1 + .github/workflows/pr-format.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d036d465d0f..cd5b7410b9c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -554,3 +554,4 @@ jobs: run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/extra_tests/snippets/stdlib_random.py - name: run cpython unittest run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/Lib/test/test_int.py + diff --git a/.github/workflows/pr-format.yaml b/.github/workflows/pr-format.yaml index 36a6487fb07..ece3dfbbf64 100644 --- a/.github/workflows/pr-format.yaml +++ b/.github/workflows/pr-format.yaml @@ -28,6 +28,8 @@ jobs: with: persist-credentials: false + - uses: reviewdog/action-actionlint@0d952c597ef8459f634d7145b0b044a9699e5e43 # v1.71.0 + - name: Setup Rust uses: dtolnay/rust-toolchain@stable with: From f04bf86f32de5b1105e748d9dcacb9d0827c07ec Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 10:33:03 +0100 Subject: [PATCH 2/6] Fix some lints --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index cd5b7410b9c..59f50877b19 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -411,7 +411,9 @@ jobs: - run: ruff format --check - name: install prettier - run: yarn global add prettier && echo "$(yarn global bin)" >>$GITHUB_PATH + run: | + yarn global add prettier + yarn global bin >> $GITHUB_PATH - name: check wasm code with prettier # prettier doesn't handle ignore files very well: https://github.com/prettier/prettier/issues/8506 From 06661df248ab4f0be895009c4de52814d8470955 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 10:34:10 +0100 Subject: [PATCH 3/6] Fix more lint --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 59f50877b19..9aba8bf14ce 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -489,7 +489,7 @@ jobs: cache-dependency-path: "wasm/demo/package-lock.json" - name: run test run: | - export PATH=$PATH:`pwd`/../../geckodriver + export PATH="$PATH:$(pwd)/../../geckodriver" npm install npm run test env: From 82ce530d6131737d113cab422e5d7ca32020d6b0 Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 10:35:24 +0100 Subject: [PATCH 4/6] More --- .github/workflows/ci.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9aba8bf14ce..300759a5b66 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -553,7 +553,6 @@ jobs: - name: build rustpython run: cargo build --release --target wasm32-wasip1 --features freeze-stdlib,stdlib --verbose - name: run snippets - run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/extra_tests/snippets/stdlib_random.py + run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/extra_tests/snippets/stdlib_random.py" - name: run cpython unittest - run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/Lib/test/test_int.py - + run: wasmer run --dir $(pwd) target/wasm32-wasip1/release/rustpython.wasm -- "$(pwd)/Lib/test/test_int.py" From 751c8ceed87a902d5fb0be27d2bf5fb283143c30 Mon Sep 17 00:00:00 2001 From: Shahar Naveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 10:54:07 +0100 Subject: [PATCH 5/6] Update .github/workflows/ci.yaml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 300759a5b66..5bcfd99e1a8 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -413,7 +413,7 @@ jobs: - name: install prettier run: | yarn global add prettier - yarn global bin >> $GITHUB_PATH + yarn global bin >> "$GITHUB_PATH" - name: check wasm code with prettier # prettier doesn't handle ignore files very well: https://github.com/prettier/prettier/issues/8506 From 9cb040072ec0ee96f7fe3c82e24bdcc0ce966d9d Mon Sep 17 00:00:00 2001 From: ShaharNaveh <50263213+ShaharNaveh@users.noreply.github.com> Date: Thu, 19 Mar 2026 12:20:57 +0100 Subject: [PATCH 6/6] More --- .github/workflows/ci.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5bcfd99e1a8..d2373dd03db 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -489,7 +489,8 @@ jobs: cache-dependency-path: "wasm/demo/package-lock.json" - name: run test run: | - export PATH="$PATH:$(pwd)/../../geckodriver" + driver_path="$(pwd)/../../geckodriver" + export PATH="$PATH:${driver_path}" npm install npm run test env: