Skip to content

mmap module for windows #3847

Closed
Closed

Description

@youknowone

we added linux mmap in #3755

adding initializer and a few tuning will let windows also run the module.

Activity

  1. eaeiv commented on Jul 11, 2022

    @eaeiv

    I would like to claim this issue. I'm currently reading through the relevant python docs, linked threads, and the src. If anyone has any suggestions at where to direct my attention, it would be greatly appreciated.

  2. youknowone commented on Jul 12, 2022

    @youknowone
    MemberAuthor

    Hello, I have rough steps but I don't have detailed descriptions.

    1. Try to change memmap2 in stdlib/Cargo.toml to cover windows.
    2. The major difference of windows version is constructor. We can start with constructor and try to solve other stuff later.
    3. Run test_mmap to check how it is going. cargo run Lib/test/test_mmap.py. You don't need to make everything working for single PR.

    @killme2008 do you have any advice?

  3. killme2008 commented on Jul 13, 2022

    @killme2008
    Contributor

    @youknowone I don't have more advice, it's a good guide to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions