Use stronger memory ordering for initialized flag synchronization

ever0de · ever0de · commit ece048d0be20 · 2025-11-22T21:04:05.000+09:00
Apply code review feedback to use Ordering::AcqRel for the swap operation
and Ordering::Release for the store operation to ensure proper
synchronization across threads when setting the initialized flag.
diff --git a/crates/stdlib/src/sqlite.rs b/crates/stdlib/src/sqlite.rs
@@ -903,7 +903,7 @@ mod _sqlite {
         type Args = ConnectArgs;
 
         fn init(zelf: PyRef<Self>, args: Self::Args, vm: &VirtualMachine) -> PyResult<()> {
-            let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::Relaxed);
+            let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::AcqRel);
 
             // Reset factories to their defaults, matching CPython's behavior.
             zelf.reset_factories(vm);
@@ -931,7 +931,7 @@ mod _sqlite {
 
             let mut guard = zelf.db.lock();
             *guard = Some(db);
-            Radium::store(&zelf.initialized, true, Ordering::Relaxed);
+            Radium::store(&zelf.initialized, true, Ordering::Release);
             Ok(())
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -903,7 +903,7 @@ mod _sqlite {`
`903`	`903`	`type Args = ConnectArgs;`
`904`	`904`
`905`	`905`	`fn init(zelf: PyRef<Self>, args: Self::Args, vm: &VirtualMachine) -> PyResult<()> {`
`906`		`- let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::Relaxed);`
	`906`	`+ let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::AcqRel);`
`907`	`907`
`908`	`908`	`// Reset factories to their defaults, matching CPython's behavior.`
`909`	`909`	`zelf.reset_factories(vm);`
`@@ -931,7 +931,7 @@ mod _sqlite {`
`931`	`931`
`932`	`932`	`let mut guard = zelf.db.lock();`
`933`	`933`	`*guard = Some(db);`
`934`		`- Radium::store(&zelf.initialized, true, Ordering::Relaxed);`
	`934`	`+ Radium::store(&zelf.initialized, true, Ordering::Release);`
`935`	`935`	`Ok(())`
`936`	`936`	`}`
`937`	`937`	`}`