Skip to content

Commit e079176

Browse files
youknowoneyouknowone
committed
adjust failing test markers
1 parent ef44a7e commit e079176

4 files changed

Lines changed: 10 additions & 12 deletions

File tree

‎Lib/test/test_htmlparser.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -754,8 +754,6 @@ def test_with_unquoted_attributes(self):
754754
]
755755
self._run_check(html, expected)
756756

757-
# TODO: RUSTPYTHON
758-
@unittest.expectedFailure
759757
def test_comma_between_attributes(self):
760758
# see bpo 41478
761759
# HTMLParser preserves duplicate attributes, leaving the task of

‎Lib/test/test_httplib.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,8 @@ def test_attributes(self):
16951695
h = client.HTTPSConnection(HOST, TimeoutTest.PORT, timeout=30)
16961696
self.assertEqual(h.timeout, 30)
16971697

1698+
# TODO: RUSTPYTHON
1699+
@unittest.expectedFailure
16981700
def test_networked(self):
16991701
# Default settings: requires a valid cert from a trusted CA
17001702
import ssl
@@ -1732,6 +1734,8 @@ def test_networked_trusted_by_default_cert(self):
17321734
h.close()
17331735
self.assertIn('text/html', content_type)
17341736

1737+
# TODO: RUSTPYTHON
1738+
@unittest.expectedFailure
17351739
def test_networked_good_cert(self):
17361740
# We feed the server's cert as a validating cert
17371741
import ssl
@@ -1765,6 +1769,8 @@ def test_networked_good_cert(self):
17651769
h.close()
17661770
self.assertIn('nginx', server_string)
17671771

1772+
# TODO: RUSTPYTHON
1773+
@unittest.expectedFailure
17681774
def test_networked_bad_cert(self):
17691775
# We feed a "CA" cert that is unrelated to the server's cert
17701776
import ssl
@@ -1777,6 +1783,8 @@ def test_networked_bad_cert(self):
17771783
h.request('GET', '/')
17781784
self.assertEqual(exc_info.exception.reason, 'CERTIFICATE_VERIFY_FAILED')
17791785

1786+
# TODO: RUSTPYTHON
1787+
@unittest.expectedFailure
17801788
def test_local_unknown_cert(self):
17811789
# The custom cert isn't known to the default trust bundle
17821790
import ssl
@@ -1799,6 +1807,8 @@ def test_local_good_hostname(self):
17991807
self.addCleanup(resp.close)
18001808
self.assertEqual(resp.status, 404)
18011809

1810+
# TODO: RUSTPYTHON
1811+
@unittest.expectedFailure
18021812
def test_local_bad_hostname(self):
18031813
# The (valid) cert doesn't validate the HTTP hostname
18041814
import ssl

‎Lib/test/test_urllib.py‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,6 @@ def test_willclose(self):
373373
finally:
374374
self.unfakehttp()
375375

376-
# TODO: RUSTPYTHON
377-
@unittest.expectedFailure
378376
@unittest.skipUnless(ssl, "ssl module required")
379377
def test_url_path_with_control_char_rejected(self):
380378
for char_no in list(range(0, 0x21)) + [0x7f]:
@@ -402,8 +400,6 @@ def test_url_path_with_control_char_rejected(self):
402400
finally:
403401
self.unfakehttp()
404402

405-
# TODO: RUSTPYTHON
406-
@unittest.expectedFailure
407403
@unittest.skipUnless(ssl, "ssl module required")
408404
def test_url_path_with_newline_header_injection_rejected(self):
409405
self.fakehttp(b"HTTP/1.1 200 OK\r\n\r\nHello.")
@@ -430,8 +426,6 @@ def test_url_path_with_newline_header_injection_rejected(self):
430426
finally:
431427
self.unfakehttp()
432428

433-
# TODO: RUSTPYTHON
434-
@unittest.expectedFailure
435429
@unittest.skipUnless(ssl, "ssl module required")
436430
def test_url_host_with_control_char_rejected(self):
437431
for char_no in list(range(0, 0x21)) + [0x7f]:
@@ -449,8 +443,6 @@ def test_url_host_with_control_char_rejected(self):
449443
finally:
450444
self.unfakehttp()
451445

452-
# TODO: RUSTPYTHON
453-
@unittest.expectedFailure
454446
@unittest.skipUnless(ssl, "ssl module required")
455447
def test_url_host_with_newline_header_injection_rejected(self):
456448
self.fakehttp(b"HTTP/1.1 200 OK\r\n\r\nHello.")

‎Lib/test/test_urllib2.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ def test_request_headers_methods(self):
141141
req.remove_header("Unredirected-spam")
142142
self.assertFalse(req.has_header("Unredirected-spam"))
143143

144-
# TODO: RUSTPYTHON, AssertionError: Tuples differ: ('foo', 'ni') != (None, None)
145-
@unittest.expectedFailure
146144
def test_password_manager(self):
147145
mgr = urllib.request.HTTPPasswordMgr()
148146
add = mgr.add_password

0 commit comments

Comments
 (0)