Skip to content

Commit c2acafd

Browse files
Copilotmoreal
andcommitted
Remove expectedFailure from test_missing_directory
The test now passes due to zipimport implicit directory support added in the 3.14.2 upgrade. Co-authored-by: moreal <26626194+moreal@users.noreply.github.com>
1 parent 40f81e2 commit c2acafd

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

Lib/test/test_importlib/test_namespace_pkgs.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,8 @@ def test_project3_succeeds(self):
288288
class ZipWithMissingDirectory(NamespacePackageTest):
289289
paths = ['missing_directory.zip']
290290

291-
@unittest.expectedFailure
292291
def test_missing_directory(self):
293-
# This will fail because missing_directory.zip contains:
292+
# This tests that missing_directory.zip contains:
294293
# Length Date Time Name
295294
# --------- ---------- ----- ----
296295
# 29 2012-05-03 18:13 foo/one.py
@@ -299,8 +298,8 @@ def test_missing_directory(self):
299298
# --------- -------
300299
# 67 3 files
301300

302-
# Because there is no 'foo/', the zipimporter currently doesn't
303-
# know that foo is a namespace package
301+
# Even though there is no 'foo/', the zipimporter now
302+
# supports implicit directories and knows foo is a namespace package
304303

305304
import foo.one
306305

0 commit comments

Comments
 (0)