Check nanosecond sign before duration bounds

Copilot · youknowone · Copilot · commit a781c0d9e80e · 2025-12-25T01:17:41.000Z
Co-authored-by: youknowone &lt;69878+youknowone@users.noreply.github.com&gt;
diff --git a/crates/vm/src/convert/try_from.rs b/crates/vm/src/convert/try_from.rs
@@ -162,11 +162,13 @@ fn duration_from_f64_floor(f: f64, vm: &VirtualMachine) -> PyResult<std::time::D
     }
 
     let total_nanos = (f * NANOS_PER_SEC).floor();
-    if !(0.0..=MAX_TOTAL_NANOS as f64).contains(&total_nanos) {
+    if total_nanos.is_sign_negative() {
         return Err(vm.new_value_error("value out of range"));
     }
-
     let total_nanos_u128 = total_nanos as u128;
+    if total_nanos_u128 > MAX_TOTAL_NANOS {
+        return Err(vm.new_value_error("value out of range"));
+    }
 
     let secs = (total_nanos_u128 / NANOS_PER_SEC_U128) as u64;
     let nanos = (total_nanos_u128 % NANOS_PER_SEC_U128) as u32;

Original file line number	Diff line number	Diff line change
`@@ -162,11 +162,13 @@ fn duration_from_f64_floor(f: f64, vm: &VirtualMachine) -> PyResult<std::time::D`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`let total_nanos = (f * NANOS_PER_SEC).floor();`
`165`		`- if !(0.0..=MAX_TOTAL_NANOS as f64).contains(&total_nanos) {`
	`165`	`+ if total_nanos.is_sign_negative() {`
`166`	`166`	`return Err(vm.new_value_error("value out of range"));`
`167`	`167`	`}`
`168`		`-`
`169`	`168`	`let total_nanos_u128 = total_nanos as u128;`
	`169`	`+ if total_nanos_u128 > MAX_TOTAL_NANOS {`
	`170`	`+ return Err(vm.new_value_error("value out of range"));`
	`171`	`+ }`
`170`	`172`
`171`	`173`	`let secs = (total_nanos_u128 / NANOS_PER_SEC_U128) as u64;`
`172`	`174`	`let nanos = (total_nanos_u128 % NANOS_PER_SEC_U128) as u32;`