fix matching args

Masorubka1 · Masorubka1 · commit a3c810b4fb9e · 2023-04-22T11:34:43.000Z
diff --git a/Lib/test/test_secrets.py b/Lib/test/test_secrets.py
@@ -44,7 +44,6 @@ def test_bad_types(self):
 
     def test_bool(self):
         # Test that compare_digest returns a bool.
-        print(secrets.compare_digest("abc", "abc"))
         self.assertIsInstance(secrets.compare_digest("abc", "abc"), bool)
         self.assertIsInstance(secrets.compare_digest("abc", "xyz"), bool)
 
diff --git a/stdlib/src/hashlib.rs b/stdlib/src/hashlib.rs
@@ -307,12 +307,17 @@ pub mod _hashlib {
         b: ArgStrOrBytesLike,
         vm: &VirtualMachine,
     ) -> PyResult<PyObjectRef> {
-        if a.get_enum_int() != b.get_enum_int() {
-            return Err(vm.new_type_error(format!(
-                "different types in compare_digest {} and {} ",
-                a.get_enum(),
-                b.get_enum()
-            )));
+
+        fn is_str(arg: &ArgStrOrBytesLike) -> bool {
+            matches!(arg, ArgStrOrBytesLike::Str(_))
+        }
+
+        if is_str(&a) != is_str(&b) {
+            let err_msg = format!(
+                "a bytes-like object is required, not '{}'",
+                b.as_object().class().name()
+            );
+            return Err(vm.new_type_error(err_msg));
         }
 
         let a_hash = a.borrow_bytes().to_vec();
