Fix CR comments

palaviv · palaviv · commit 88c477fb6c0c · 2019-12-30T21:31:36.000+02:00
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
@@ -1640,7 +1640,7 @@ def disable_gc():
     # finally:
     #     if have_gc:
     #         gc.enable()
-    pass
+    yield
 
 
 def python_is_optimized():
diff --git a/vm/src/stdlib/faulthandler.rs b/vm/src/stdlib/faulthandler.rs
@@ -2,7 +2,6 @@ use crate::frame::FrameRef;
 use crate::function::OptionalArg;
 use crate::pyobject::PyObjectRef;
 use crate::vm::VirtualMachine;
-use std::cell::Ref;
 
 fn dump_frame(frame: &FrameRef) {
     eprintln!(
@@ -16,11 +15,9 @@ fn dump_frame(frame: &FrameRef) {
 fn dump_traceback(_file: OptionalArg<i64>, _all_threads: OptionalArg<bool>, vm: &VirtualMachine) {
     eprintln!("Stack (most recent call first):");
 
-    Ref::map(vm.frames.borrow(), |frames| {
-        &for frame in frames {
-            dump_frame(frame);
-        }
-    });
+    for frame in vm.frames.borrow().iter() {
+        dump_frame(frame);
+    }
 }
 
 fn enable(_file: OptionalArg<i64>, _all_threads: OptionalArg<bool>, _vm: &VirtualMachine) {
diff --git a/vm/src/stdlib/time_module.rs b/vm/src/stdlib/time_module.rs
@@ -265,6 +265,6 @@ pub fn make_module(vm: &VirtualMachine) -> PyObjectRef {
         "sleep" => ctx.new_rustfunc(time_sleep),
         "struct_time" => struct_time_type,
         "time" => ctx.new_rustfunc(time_time),
-        "perf_counter" => ctx.new_rustfunc(time_time),
+        "perf_counter" => ctx.new_rustfunc(time_time), // TODO: fix
     })
 }

Original file line number	Diff line number	Diff line change
`@@ -265,6 +265,6 @@ pub fn make_module(vm: &VirtualMachine) -> PyObjectRef {`
`265`	`265`	`"sleep" => ctx.new_rustfunc(time_sleep),`
`266`	`266`	`"struct_time" => struct_time_type,`
`267`	`267`	`"time" => ctx.new_rustfunc(time_time),`
`268`		`- "perf_counter" => ctx.new_rustfunc(time_time),`
	`268`	`+ "perf_counter" => ctx.new_rustfunc(time_time), // TODO: fix`
`269`	`269`	`})`
`270`	`270`	`}`