Skip to content

Commit 7ba97f0

Browse files
youknowoneyouknowone
authored
Merge pull request #2443 from fanninpm/cleanup-skipped-tests
Cleanup skipped tests
2 parents 491af24 + d7ad4bf commit 7ba97f0

45 files changed

Lines changed: 249 additions & 167 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Lib/test/seq_tests.py‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def test_repeat(self):
321321
self.assertEqual(self.type2test(s)*(-4), self.type2test([]))
322322
self.assertEqual(id(s), id(s*1))
323323

324-
@unittest.skip("TODO: RUSTPYTHON")
324+
@unittest.skip("TODO: RUSTPYTHON, only works on 32-bit systems?")
325325
def test_bigrepeat(self):
326326
if sys.maxsize <= 2147483647:
327327
x = self.type2test([0])
@@ -365,7 +365,7 @@ def __eq__(self, other):
365365

366366
self.assertRaises(BadExc, a.count, BadCmp())
367367

368-
@unittest.skip("TODO: RUSTPYTHON")
368+
@unittest.skip("TODO: RUSTPYTHON, TypeError: Expected at most 2 arguments (3 given)")
369369
def test_index(self):
370370
u = self.type2test([0, 1])
371371
self.assertEqual(u.index(0), 0)
@@ -408,15 +408,14 @@ def __eq__(self, other):
408408
self.assertRaises(ValueError, a.index, 0, 4*sys.maxsize,-4*sys.maxsize)
409409
self.assertRaises(ValueError, a.index, 2, 0, -10)
410410

411-
@unittest.skip("TODO: RUSTPYTHON")
412411
def test_pickle(self):
413412
lst = self.type2test([4, 5, 6, 7])
414413
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
415414
lst2 = pickle.loads(pickle.dumps(lst, proto))
416415
self.assertEqual(lst2, lst)
417416
self.assertNotEqual(id(lst2), id(lst))
418417

419-
@unittest.skip("TODO: RUSTPYTHON")
418+
@unittest.skip("TODO: RUSTPYTHON, AttributeError: module 'test.support' has no attribute 'check_free_after_iterating'")
420419
def test_free_after_iterating(self):
421420
support.check_free_after_iterating(self, iter, self.type2test)
422421
support.check_free_after_iterating(self, reversed, self.type2test)

‎Lib/test/string_tests.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ def test_replace(self):
673673
self.checkraises(TypeError, 'hello', 'replace', 42, 'h')
674674
self.checkraises(TypeError, 'hello', 'replace', 'h', 42)
675675

676-
@unittest.skip("TODO: RUSTPYTHON")
676+
@unittest.skip("TODO: RUSTPYTHON, may only apply to 32-bit platforms")
677677
@unittest.skipIf(sys.maxsize > (1 << 32) or struct.calcsize('P') != 4,
678678
'only applies to 32-bit platforms')
679679
def test_replace_overflow(self):

‎Lib/test/test_array.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ def test_tofromstring(self):
471471
nb_warnings += 1
472472
self.assertEqual(len(r), nb_warnings)
473473

474-
@unittest.skip("TODO: RUSTPYTHON")
474+
@unittest.skip("TODO: RUSTPYTHON, OverflowError: Python int too large to convert to Rust i8")
475475
def test_tofrombytes(self):
476476
a = array.array(self.typecode, 2*self.example)
477477
b = array.array(self.typecode)
@@ -1131,7 +1131,7 @@ def test_setitem(self):
11311131
a = array.array(self.typecode, self.example)
11321132
self.assertRaises(TypeError, a.__setitem__, 0, self.example[:2])
11331133

1134-
@unittest.skip("TODO: RUSTPYTHON")
1134+
@unittest.skip("TODO: RUSTPYTHON, ValueError: bad typecode")
11351135
class UnicodeTest(StringTest, unittest.TestCase):
11361136
typecode = 'u'
11371137
example = '\x01\u263a\x00\ufeff'
@@ -1424,7 +1424,7 @@ class DoubleTest(FPTest, unittest.TestCase):
14241424
typecode = 'd'
14251425
minitemsize = 8
14261426

1427-
@unittest.skip("TODO: RUSTPYTHON")
1427+
@unittest.skip("TODO: RUSTPYTHON, thread 'main' panicked at 'capacity overflow'")
14281428
def test_alloc_overflow(self):
14291429
from sys import maxsize
14301430
a = array.array('d', [-1]*65536)

‎Lib/test/test_builtin.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1571,7 +1571,7 @@ def test_construct_singletons(self):
15711571
self.assertRaises(TypeError, tp, a=1, b=2)
15721572

15731573

1574-
@unittest.skip("TODO: RUSTPYTHON")
1574+
@unittest.skip("TODO: RUSTPYTHON, AttributeError: module 'sys' has no attribute '__breakpointhook__'")
15751575
class TestBreakpoint(unittest.TestCase):
15761576
def setUp(self):
15771577
# These tests require a clean slate environment. For example, if the

‎Lib/test/test_bytes.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ def test_concat(self):
336336
self.assertRaises(TypeError, lambda: b1 + "def")
337337
self.assertRaises(TypeError, lambda: "abc" + b2)
338338

339-
@unittest.skip("TODO: RUSTPYTHON")
339+
@unittest.skip("TODO: RUSTPYTHON, thread 'main' panicked at 'capacity overflow'")
340340
def test_repeat(self):
341341
for b in b"abc", self.type2test(b"abc"):
342342
self.assertEqual(b * 3, b"abcabcabc")

‎Lib/test/test_class.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ def __eq__(self, other): return 1
494494
self.assertRaises(TypeError, hash, C2())
495495

496496

497-
@unittest.skip("TODO: RUSTPYTHON")
497+
@unittest.skip("TODO: RUSTPYTHON, segmentation fault")
498498
def testSFBug532646(self):
499499
# Test for SF bug 532646
500500

‎Lib/test/test_contains.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def test_common_tests(self):
3535

3636
self.assertRaises(TypeError, lambda: None in 'abc')
3737

38-
@unittest.skip("TODO: RUSTPYTHON")
38+
@unittest.skip("TODO: RUSTPYTHON, hangs")
3939
def test_builtin_sequence_types(self):
4040
# a collection of tests on builtin sequence types
4141
a = range(10)

‎Lib/test/test_copy.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ def test_deepcopy_list(self):
374374
self.assertIsNot(x, y)
375375
self.assertIsNot(x[0], y[0])
376376

377-
@unittest.skip("TODO: RUSTPYTHON")
377+
@unittest.skip("TODO: RUSTPYTHON, segmentation fault")
378378
def test_deepcopy_reflexive_list(self):
379379
x = []
380380
x.append(x)
@@ -402,7 +402,7 @@ def test_deepcopy_tuple_of_immutables(self):
402402
y = copy.deepcopy(x)
403403
self.assertIs(x, y)
404404

405-
@unittest.skip("TODO: RUSTPYTHON")
405+
@unittest.skip("TODO: RUSTPYTHON, segmentation fault")
406406
def test_deepcopy_reflexive_tuple(self):
407407
x = ([],)
408408
x[0].append(x)
@@ -420,7 +420,7 @@ def test_deepcopy_dict(self):
420420
self.assertIsNot(x, y)
421421
self.assertIsNot(x["foo"], y["foo"])
422422

423-
@unittest.skip("TODO: RUSTPYTHON")
423+
@unittest.skip("TODO: RUSTPYTHON, segmentation fault")
424424
def test_deepcopy_reflexive_dict(self):
425425
x = {}
426426
x['foo'] = x

‎Lib/test/test_importlib/extension/test_loader.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def setUp(self):
2222
def load_module(self, fullname):
2323
return self.loader.load_module(fullname)
2424

25-
@unittest.skip("TODO: RUSTPYTHON")
25+
@unittest.skip("TODO: RUSTPYTHON, AttributeError: 'NoneType' object has no attribute 'rpartition'")
2626
def test_load_module_API(self):
2727
# Test the default argument for load_module().
2828
self.loader.load_module()
@@ -59,7 +59,7 @@ def test_module(self):
5959
# No extension module in a package available for testing.
6060
test_lacking_parent = None
6161

62-
@unittest.skip("TODO: RUSTPYTHON")
62+
@unittest.skip("TODO: RUSTPYTHON, AttributeError: 'NoneType' object has no attribute 'rpartition'")
6363
def test_module_reuse(self):
6464
with util.uncache(util.EXTENSIONS.name):
6565
module1 = self.load_module(util.EXTENSIONS.name)
@@ -75,7 +75,7 @@ def test_unloadable(self):
7575
self.load_module(name)
7676
self.assertEqual(cm.exception.name, name)
7777

78-
@unittest.skip("TODO: RUSTPYTHON")
78+
@unittest.skip("TODO: RUSTPYTHON, AttributeError: 'NoneType' object has no attribute 'rpartition'")
7979
def test_is_package(self):
8080
self.assertFalse(self.loader.is_package(util.EXTENSIONS.name))
8181
for suffix in self.machinery.EXTENSION_SUFFIXES:
@@ -87,7 +87,7 @@ def test_is_package(self):
8787
Source_LoaderTests
8888
) = util.test_both(LoaderTests, machinery=machinery)
8989

90-
@unittest.skip("TODO: RUSTPYTHON")
90+
@unittest.skip("TODO: RUSTPYTHON, AssertionError")
9191
class MultiPhaseExtensionModuleTests(abc.LoaderTests):
9292
"""Test loading extension modules with multi-phase initialization (PEP 489)
9393
"""

‎Lib/test/test_importlib/frozen/test_loader.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_module(self):
3434
self.assertEqual(output, 'Hello world!\n')
3535
self.assertTrue(hasattr(module, '__spec__'))
3636

37-
@unittest.skip("TODO: RUSTPYTHON")
37+
@unittest.skip("TODO: RUSTPYTHON, ImportError: '__phello__' is not a frozen module")
3838
def test_package(self):
3939
name = '__phello__'
4040
module, output = self.exec_module(name)
@@ -47,7 +47,7 @@ def test_package(self):
4747
expected=value))
4848
self.assertEqual(output, 'Hello world!\n')
4949

50-
@unittest.skip("TODO: RUSTPYTHON")
50+
@unittest.skip("TODO: RUSTPYTHON, ImportError: '__phello__.spam' is not a frozen module")
5151
def test_lacking_parent(self):
5252
name = '__phello__.spam'
5353
with util.uncache('__phello__'):
@@ -107,7 +107,7 @@ def test_module(self):
107107
self.assertEqual(stdout.getvalue(), 'Hello world!\n')
108108
self.assertFalse(hasattr(module, '__file__'))
109109

110-
@unittest.skip("TODO: RUSTPYTHON")
110+
@unittest.skip("TODO: RUSTPYTHON, ImportError: '__phello__' is not a frozen module")
111111
def test_package(self):
112112
with util.uncache('__phello__'), captured_stdout() as stdout:
113113
with warnings.catch_warnings():
@@ -126,7 +126,7 @@ def test_package(self):
126126
self.assertEqual(stdout.getvalue(), 'Hello world!\n')
127127
self.assertFalse(hasattr(module, '__file__'))
128128

129-
@unittest.skip("TODO: RUSTPYTHON")
129+
@unittest.skip("TODO: RUSTPYTHON, ImportError: '__phello__.spam' is not a frozen module")
130130
def test_lacking_parent(self):
131131
with util.uncache('__phello__', '__phello__.spam'), \
132132
captured_stdout() as stdout:
@@ -204,7 +204,7 @@ def test_get_source(self):
204204
result = self.machinery.FrozenImporter.get_source('__hello__')
205205
self.assertIsNone(result)
206206

207-
@unittest.skip("TODO: RUSTPYTHON")
207+
@unittest.skip("TODO: RUSTPYTHON, ImportError: '__phello__' is not a frozen module")
208208
def test_is_package(self):
209209
# Should be able to tell what is a package.
210210
test_for = (('__hello__', False), ('__phello__', True),

0 commit comments

Comments
 (0)