fix more

ShaharNaveh · ShaharNaveh · commit 7ab95fdf90af · 2026-06-14T15:03:31.000+03:00
diff --git a/benches/execution.rs b/benches/execution.rs
@@ -30,7 +30,7 @@ fn bench_rustpython_code(b: &mut Bencher, name: &str, source: &str) {
         // Note: bench_cpython is both compiling and executing the code.
         // As such we compile the code in the benchmark loop as well.
         b.iter(|| {
-            let code = vm.compile(source, Mode::Exec, name.to_owned()).unwrap();
+            let code = vm.compile(source, Mode::Exec, name).unwrap();
             let scope = vm.new_scope_with_builtins();
             let res: PyResult = vm.run_code_obj(code.clone(), scope);
             vm.unwrap_pyresult(res);
diff --git a/benches/microbenchmarks.rs b/benches/microbenchmarks.rs
@@ -118,10 +118,10 @@ fn bench_rustpython_code(group: &mut BenchmarkGroup<WallTime>, bench: &MicroBenc
     let interp = builder.add_native_modules(&defs).build();
     interp.enter(|vm| {
         let setup_code = vm
-            .compile(&bench.setup, Mode::Exec, bench.name.to_owned())
+            .compile(&bench.setup, Mode::Exec, &bench.name)
             .expect("Error compiling setup code");
         let bench_code = vm
-            .compile(&bench.code, Mode::Exec, bench.name.to_owned())
+            .compile(&bench.code, Mode::Exec, &bench.name)
             .expect("Error compiling bench code");
 
         let bench_func = |scope| {
diff --git a/crates/stdlib/src/_opcode.rs b/crates/stdlib/src/_opcode.rs
@@ -192,7 +192,7 @@ mod tests {
     ///
     /// Memory addresses in the output are replaced with `0xdeadbeef` for consistency.
     fn dis(source: &str) -> String {
-        let fname = String::from("<?>");
+        const FNAME: &str = "<?>";
 
         let builder = vm::Interpreter::builder(Default::default());
         let stdlib_defs = crate::stdlib_module_defs(&builder.ctx);
@@ -204,7 +204,7 @@ mod tests {
         interp.enter(|vm| {
             let scope = vm.new_scope_with_builtins();
             let code_obj = vm
-                .compile(source.trim(), Mode::Exec, fname.clone())
+                .compile(source.trim(), Mode::Exec, FNAME)
                 .map_err(|err| vm.new_syntax_error(&err, Some(source)))
                 .unwrap();
             scope.globals.set_item("code", code_obj.into(), vm).unwrap();
@@ -227,7 +227,7 @@ output = re.sub(r'(<code object \w+ at )0x[0-9a-fA-F]+', r'\g<1>0xdeadbeef', tmp
 "#;
 
             let py_code_obj = vm
-                .compile(py_source, Mode::Exec, fname)
+                .compile(py_source, Mode::Exec, FNAME)
                 .map_err(|err| vm.new_syntax_error(&err, Some(py_source)))
                 .unwrap();
 
diff --git a/crates/vm/src/vm/context.rs b/crates/vm/src/vm/context.rs
@@ -699,7 +699,7 @@ impl Context {
     where
         F: IntoPyGetterFunc<T>,
     {
-        let getset = PyGetSet::new(&name, class).with_get(f);
+        let getset = PyGetSet::new(name, class).with_get(f);
         PyRef::new_ref(getset, self.types.getset_type.to_owned(), None)
     }
 
@@ -714,7 +714,7 @@ impl Context {
         G: IntoPyGetterFunc<T>,
         S: IntoPySetterFunc<U>,
     {
-        let getset = PyGetSet::new(&name, class).with_get(g).with_set(s);
+        let getset = PyGetSet::new(name, class).with_get(g).with_set(s);
         PyRef::new_ref(getset, self.types.getset_type.to_owned(), None)
     }
 
diff --git a/crates/vm/src/vm/mod.rs b/crates/vm/src/vm/mod.rs
@@ -2285,7 +2285,7 @@ mod tests {
 
                 let source = "from dir_module.dir_module_inner import value2";
                 let code_obj = vm
-                    .compile(source, vm::compiler::Mode::Exec, "<embedded>".to_owned())
+                    .compile(source, vm::compiler::Mode::Exec, "<embedded>")
                     .map_err(|err| vm.new_syntax_error(&err, Some(source)))
                     .unwrap();
 
diff --git a/examples/hello_embed.rs b/examples/hello_embed.rs
@@ -5,7 +5,7 @@ fn main() -> vm::PyResult<()> {
         let scope = vm.new_scope_with_builtins();
         let source = r#"print("Hello World!")"#;
         let code_obj = vm
-            .compile(source, vm::compiler::Mode::Exec, "<embedded>".to_owned())
+            .compile(source, vm::compiler::Mode::Exec, "<embedded>")
             .map_err(|err| vm.new_syntax_error(&err, Some(source)))?;
 
         vm.run_code_obj(code_obj, scope)?;
diff --git a/examples/mini_repl.rs b/examples/mini_repl.rs
@@ -65,7 +65,7 @@ def fib(n):
         // this line also automatically prints the output
         // (note that this is only the case when compiler::Mode::Single is passed to vm.compile)
         match vm
-            .compile(&input, vm::compiler::Mode::Single, "<embedded>".to_owned())
+            .compile(&input, vm::compiler::Mode::Single, "<embedded>")
             .map_err(|err| vm.new_syntax_error(&err, Some(&input)))
             .and_then(|code_obj| vm.run_code_obj(code_obj, scope.clone()))
         {

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,7 @@ impl Context {`
`699`	`699`	`where`
`700`	`700`	`F: IntoPyGetterFunc<T>,`
`701`	`701`	`{`
`702`		`- let getset = PyGetSet::new(&name, class).with_get(f);`
	`702`	`+ let getset = PyGetSet::new(name, class).with_get(f);`
`703`	`703`	`PyRef::new_ref(getset, self.types.getset_type.to_owned(), None)`
`704`	`704`	`}`
`705`	`705`
`@@ -714,7 +714,7 @@ impl Context {`
`714`	`714`	`G: IntoPyGetterFunc<T>,`
`715`	`715`	`S: IntoPySetterFunc<U>,`
`716`	`716`	`{`
`717`		`- let getset = PyGetSet::new(&name, class).with_get(g).with_set(s);`
	`717`	`+ let getset = PyGetSet::new(name, class).with_get(g).with_set(s);`
`718`	`718`	`PyRef::new_ref(getset, self.types.getset_type.to_owned(), None)`
`719`	`719`	`}`
`720`	`720`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ def fib(n):`
`65`	`65`	`// this line also automatically prints the output`
`66`	`66`	`// (note that this is only the case when compiler::Mode::Single is passed to vm.compile)`
`67`	`67`	`match vm`
`68`		`- .compile(&input, vm::compiler::Mode::Single, "<embedded>".to_owned())`
	`68`	`+ .compile(&input, vm::compiler::Mode::Single, "<embedded>")`
`69`	`69`	`.map_err(\|err\| vm.new_syntax_error(&err, Some(&input)))`
`70`	`70`	`.and_then(\|code_obj\| vm.run_code_obj(code_obj, scope.clone()))`
`71`	`71`	`{`