style: drop(Box::from_raw)

discord9 · discord9 · commit 711e5a2a3f7c · 2022-09-24T22:20:31.000+08:00
diff --git a/vm/src/builtins/iter.rs b/vm/src/builtins/iter.rs
@@ -6,7 +6,6 @@ use super::{PyInt, PyTupleRef, PyType};
 use crate::{
     class::PyClassImpl,
     function::ArgCallable,
-    
     protocol::{PyIterReturn, PySequence, PySequenceMethods},
     types::{IterNext, IterNextIterable},
     Context, Py, PyObject, PyObjectRef, PyPayload, PyResult, VirtualMachine,
diff --git a/vm/src/object/core.rs b/vm/src/object/core.rs
@@ -15,11 +15,12 @@ use super::{
     ext::{AsObject, PyResult},
     payload::PyObjectPayload,
 };
+#[cfg(not(feature = "gc"))]
+use crate::common::refcount::RefCount;
 use crate::common::{
     atomic::{OncePtr, PyAtomic, Radium},
     linked_list::{Link, LinkedList, Pointers},
     lock::{PyMutex, PyMutexGuard, PyRwLock},
-    refcount::RefCount,
 };
 #[cfg(feature = "gc")]
 use crate::object::gc::{GcHeader, GcObjPtr, GcStatus, GcTrace, TracerFn};
@@ -455,7 +456,7 @@ impl WeakRefList {
     }
 
     unsafe fn dealloc(ptr: NonNull<PyMutex<WeakListInner>>) {
-        Box::from_raw(ptr.as_ptr());
+        drop(Box::from_raw(ptr.as_ptr()));
     }
 
     fn get_weak_references(&self) -> Vec<PyRef<PyWeak>> {
@@ -524,7 +525,7 @@ pub struct PyWeak {
 
 #[cfg(feature = "gc")]
 impl crate::object::gc::GcTrace for PyWeak {
-    fn trace(&self, tracer_fn: &mut crate::object::gc::TracerFn) {
+    fn trace(&self, _tracer_fn: &mut crate::object::gc::TracerFn) {
         // PyWeak doesn't own the object by define
         // FIXME(discord9): confirm this and test
     }
diff --git a/vm/src/object/gc/collector_sync.rs b/vm/src/object/gc/collector_sync.rs
@@ -193,7 +193,7 @@ impl CcSync {
                         unsafe {
                             // can drop directly because no one is refering it
                             // (unlike in collect_white where drop_in_place first and deallocate later)
-                            Box::from_raw(ptr.0.as_ptr());
+                            drop(Box::from_raw(ptr.0.as_ptr()));
                             /*
                             drop_value(ptr.0);
                             free(ptr.0);
