apply review

youknowone · youknowone · commit 639e89adc5ee · 2025-12-16T13:49:58.000+09:00
diff --git a/crates/derive-impl/src/pyclass.rs b/crates/derive-impl/src/pyclass.rs
@@ -1614,7 +1614,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
     }];
     let mut payload = None;
 
-    let mut has_constructor = false;
     for attr in attr {
         match attr {
             NestedMeta::Meta(Meta::List(MetaList { path, nested, .. })) => {
@@ -1639,9 +1638,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
                                     "Try `#[pyclass(with(Constructor, ...))]` instead of `#[pyclass(with(DefaultConstructor, ...))]`. DefaultConstructor implicitly implements Constructor."
                                 )
                             }
-                            if path.is_ident("Constructor") {
-                                has_constructor = true;
-                            }
                             (
                                 quote!(<Self as #path>::__extend_py_class),
                                 quote!(<Self as #path>::__OWN_METHOD_DEFS),
@@ -1694,7 +1690,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
             attr => bail_span!(attr, "Unknown pyimpl attribute"),
         }
     }
-    let _ = has_constructor;
 
     Ok(ExtractedImplAttrs {
         payload,
diff --git a/crates/vm/src/builtins/type.rs b/crates/vm/src/builtins/type.rs
@@ -443,17 +443,6 @@ impl PyType {
     }
 
     fn set_new(slots: &PyTypeSlots, base: &Option<PyTypeRef>) {
-        // if self.slots.new.load().is_none()
-        //     && self
-        //         .base
-        //         .as_ref()
-        //         .map(|base| base.class().is(ctx.types.object_type))
-        //         .unwrap_or(false)
-        //     && self.slots.flags.contains(PyTypeFlags::HEAPTYPE)
-        // {
-        //     self.slots.flags |= PyTypeFlags::DISALLOW_INSTANTIATION;
-        // }
-
         if slots.flags.contains(PyTypeFlags::DISALLOW_INSTANTIATION) {
             slots.new.store(None)
         } else if slots.new.load().is_none() {

Original file line number	Diff line number	Diff line change
`@@ -1614,7 +1614,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac`
`1614`	`1614`	`}];`
`1615`	`1615`	`let mut payload = None;`
`1616`	`1616`
`1617`		`- let mut has_constructor = false;`
`1618`	`1617`	`for attr in attr {`
`1619`	`1618`	`match attr {`
`1620`	`1619`	`NestedMeta::Meta(Meta::List(MetaList { path, nested, .. })) => {`
`@@ -1639,9 +1638,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac`
`1639`	`1638`	"Try `#[pyclass(with(Constructor, ...))]` instead of `#[pyclass(with(DefaultConstructor, ...))]`. DefaultConstructor implicitly implements Constructor."
`1640`	`1639`	`)`
`1641`	`1640`	`}`
`1642`		`- if path.is_ident("Constructor") {`
`1643`		`- has_constructor = true;`
`1644`		`- }`
`1645`	`1641`	`(`
`1646`	`1642`	`quote!(<Self as #path>::__extend_py_class),`
`1647`	`1643`	`quote!(<Self as #path>::__OWN_METHOD_DEFS),`
`@@ -1694,7 +1690,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac`
`1694`	`1690`	`attr => bail_span!(attr, "Unknown pyimpl attribute"),`
`1695`	`1691`	`}`
`1696`	`1692`	`}`
`1697`		`- let _ = has_constructor;`
`1698`	`1693`
`1699`	`1694`	`Ok(ExtractedImplAttrs {`
`1700`	`1695`	`payload,`