Skip to content

Commit 5bdb10b

Browse files
committed
Fix CI: remove passing expectedFailures, mark blake2 vectors
- Remove expectedFailure from test_inspect.test_signature_on_mangled_parameters - Remove expectedFailure from test_hmac.test_with_fallback - Remove expectedFailure from test_positional_only_arg.test_mangling - Remove expectedFailure from test_smtplib.testAUTH_CRAM_MD5 - Remove expectedFailure from test_smtplib.test_auth_function - Add expectedFailure to test_hashlib blake2 vector tests (key param unsupported)
1 parent b0623b6 commit 5bdb10b

File tree

5 files changed

+2
-5
lines changed

5 files changed

+2
-5
lines changed

Lib/test/test_hashlib.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -875,6 +875,7 @@ def test_case_blake2b_all_parameters(self):
875875
inner_size=7,
876876
last_node=True)
877877

878+
@unittest.expectedFailure # TODO: RUSTPYTHON, blake2 key parameter not supported
878879
@requires_blake2
879880
def test_blake2b_vectors(self):
880881
for msg, key, md in read_vectors('blake2b'):
@@ -920,6 +921,7 @@ def test_case_blake2s_all_parameters(self):
920921
inner_size=7,
921922
last_node=True)
922923

924+
@unittest.expectedFailure # TODO: RUSTPYTHON, blake2 key parameter not supported
923925
@requires_blake2
924926
def test_blake2s_vectors(self):
925927
for msg, key, md in read_vectors('blake2s'):

Lib/test/test_hmac.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1583,7 +1583,6 @@ def digest(self):
15831583
hmac.HMAC(b'a', b'b', digestmod=MockCrazyHash)
15841584
self.fail('Expected warning about small block_size')
15851585

1586-
@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: module '_hashlib' has no attribute 'hmac_digest'
15871586
@hashlib_helper.requires_hashdigest('sha256')
15881587
def test_with_fallback(self):
15891588
cache = getattr(hashlib, '__builtin_constructor_cache')

Lib/test/test_inspect/test_inspect.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5161,7 +5161,6 @@ def test():
51615161
sig = test.__signature__ = inspect.Signature(parameters=(spam_param,))
51625162
self.assertEqual(sig, inspect.signature(test))
51635163

5164-
@unittest.expectedFailure # TODO: RUSTPYTHON; Ellipsis)
51655164
def test_signature_on_mangled_parameters(self):
51665165
class Spam:
51675166
def foo(self, __p1:1=2, *, __p2:2=3):

Lib/test/test_positional_only_arg.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ def f(something,/,**kwargs):
338338

339339
self.assertEqual(f(42), (42, {}))
340340

341-
@unittest.expectedFailure # TODO: RUSTPYTHON
342341
def test_mangling(self):
343342
class X:
344343
def f(self, __a=42, /):

Lib/test/test_smtplib.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,7 +1176,6 @@ def auth_buggy(challenge=None):
11761176
finally:
11771177
smtp.close()
11781178

1179-
@unittest.expectedFailure # TODO: RUSTPYTHON
11801179
@hashlib_helper.requires_hashdigest('md5', openssl=True)
11811180
def testAUTH_CRAM_MD5(self):
11821181
self.serv.add_feature("AUTH CRAM-MD5")
@@ -1229,7 +1228,6 @@ def testAUTH_multiple(self):
12291228
self.assertEqual(resp, (235, b'Authentication Succeeded'))
12301229
smtp.close()
12311230

1232-
@unittest.expectedFailure # TODO: RUSTPYTHON
12331231
def test_auth_function(self):
12341232
supported = {'PLAIN', 'LOGIN'}
12351233
try:

0 commit comments

Comments
 (0)