Fix pr-format CI to fail on formatting changes

youknowone · youknowone · commit 4a14e73dc4bb · 2026-03-12T23:42:35.000+09:00
Add git diff --exit-code step to fail the check when
formatters produce changes. Previously reviewdog only
posted suggestions without failing the workflow.
diff --git a/.github/workflows/pr-format.yaml b/.github/workflows/pr-format.yaml
@@ -47,7 +47,15 @@ jobs:
       - name: Run generate_opcode_metadata.py
         run: python scripts/generate_opcode_metadata.py
 
+      - name: Check for formatting changes
+        run: |
+          if ! git diff --exit-code; then
+            echo "::error::Formatting changes detected. Please run 'cargo fmt --all', 'ruff format', and 'ruff check --select I --fix' locally."
+            exit 1
+          fi
+
       - name: Post formatting suggestions
+        if: failure()
         uses: reviewdog/action-suggester@v1
         with:
           tool_name: auto-format
