clippy

ShaharNaveh · ShaharNaveh · commit 3e628e9f73c5 · 2025-09-20T18:45:18.000+02:00
diff --git a/compiler/codegen/src/ir.rs b/compiler/codegen/src/ir.rs
@@ -182,7 +182,7 @@ impl CodeInfo {
                         *arg = new_arg;
                     }
                     let (extras, lo_arg) = arg.split();
-                    locations.extend(std::iter::repeat_n(info.location.clone(), arg.instr_size()));
+                    locations.extend(std::iter::repeat_n(info.location, arg.instr_size()));
                     instructions.extend(
                         extras
                             .map(|byte| CodeUnit::new(Instruction::ExtendedArg, byte))
diff --git a/compiler/src/lib.rs b/compiler/src/lib.rs
@@ -57,8 +57,8 @@ impl CompileError {
 
     pub fn location(&self) -> Option<SourceLocation> {
         match self {
-            Self::Codegen(codegen_error) => codegen_error.location.clone(),
-            Self::Parse(parse_error) => Some(parse_error.location.clone()),
+            Self::Codegen(codegen_error) => codegen_error.location,
+            Self::Parse(parse_error) => Some(parse_error.location),
         }
     }
 
diff --git a/vm/src/frame.rs b/vm/src/frame.rs
@@ -171,7 +171,7 @@ impl Frame {
     }
 
     pub fn current_location(&self) -> SourceLocation {
-        self.code.locations[self.lasti() as usize - 1].clone()
+        self.code.locations[self.lasti() as usize - 1]
     }
 
     pub fn lasti(&self) -> u32 {
@@ -388,7 +388,7 @@ impl ExecutingFrame<'_> {
                         // 2. Add new entry with current execution position (filename, lineno, code_object) to traceback.
                         // 3. Unwind block stack till appropriate handler is found.
 
-                        let loc = frame.code.locations[idx].clone();
+                        let loc = frame.code.locations[idx];
                         let next = exception.__traceback__();
                         let new_traceback = PyTraceback::new(
                             next,

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ impl CodeInfo {`
`182`	`182`	`*arg = new_arg;`
`183`	`183`	`}`
`184`	`184`	`let (extras, lo_arg) = arg.split();`
`185`		`- locations.extend(std::iter::repeat_n(info.location.clone(), arg.instr_size()));`
	`185`	`+ locations.extend(std::iter::repeat_n(info.location, arg.instr_size()));`
`186`	`186`	`instructions.extend(`
`187`	`187`	`extras`
`188`	`188`	`.map(\|byte\| CodeUnit::new(Instruction::ExtendedArg, byte))`
Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,8 @@ impl CompileError {`
`57`	`57`
`58`	`58`	`pub fn location(&self) -> Option<SourceLocation> {`
`59`	`59`	`match self {`
`60`		`- Self::Codegen(codegen_error) => codegen_error.location.clone(),`
`61`		`- Self::Parse(parse_error) => Some(parse_error.location.clone()),`
	`60`	`+ Self::Codegen(codegen_error) => codegen_error.location,`
	`61`	`+ Self::Parse(parse_error) => Some(parse_error.location),`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ impl Frame {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`pub fn current_location(&self) -> SourceLocation {`
`174`		`- self.code.locations[self.lasti() as usize - 1].clone()`
	`174`	`+ self.code.locations[self.lasti() as usize - 1]`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`pub fn lasti(&self) -> u32 {`
`@@ -388,7 +388,7 @@ impl ExecutingFrame<'_> {`
`388`	`388`	`// 2. Add new entry with current execution position (filename, lineno, code_object) to traceback.`
`389`	`389`	`// 3. Unwind block stack till appropriate handler is found.`
`390`	`390`
`391`		`- let loc = frame.code.locations[idx].clone();`
	`391`	`+ let loc = frame.code.locations[idx];`
`392`	`392`	`let next = exception.__traceback__();`
`393`	`393`	`let new_traceback = PyTraceback::new(`
`394`	`394`	`next,`