Fix double-set of gc_finalized preventing __del__ from being called

youknowone · youknowone · commit 35ee888ae4e0 · 2026-03-03T21:42:36.000+09:00
gc_state set gc_finalized before calling try_call_finalizer, but
try_call_finalizer internally checks gc_finalized and skips __del__
if already set. Remove the redundant set_gc_finalized call.
diff --git a/crates/vm/src/gc_state.rs b/crates/vm/src/gc_state.rs
@@ -542,13 +542,11 @@ impl GcState {
             }
         }
 
-        // 6d: Call __del__ on unreachable objects (skip already-finalized)
+        // 6d: Call __del__ on unreachable objects (skip already-finalized).
+        // try_call_finalizer() internally checks gc_finalized() and sets it,
+        // so we must NOT set it beforehand.
         for obj_ref in &unreachable_refs {
-            let obj = obj_ref.as_ref();
-            if !obj.gc_finalized() {
-                obj.set_gc_finalized();
-                obj_ref.try_call_finalizer();
-            }
+            obj_ref.try_call_finalizer();
         }
 
         // Detect resurrection

Original file line number	Diff line number	Diff line change
`@@ -542,13 +542,11 @@ impl GcState {`
`542`	`542`	`}`
`543`	`543`	`}`
`544`	`544`
`545`		`- // 6d: Call __del__ on unreachable objects (skip already-finalized)`
	`545`	`+ // 6d: Call __del__ on unreachable objects (skip already-finalized).`
	`546`	`+ // try_call_finalizer() internally checks gc_finalized() and sets it,`
	`547`	`+ // so we must NOT set it beforehand.`
`546`	`548`	`for obj_ref in &unreachable_refs {`
`547`		`- let obj = obj_ref.as_ref();`
`548`		`- if !obj.gc_finalized() {`
`549`		`- obj.set_gc_finalized();`
`550`		`- obj_ref.try_call_finalizer();`
`551`		`- }`
	`549`	`+ obj_ref.try_call_finalizer();`
`552`	`550`	`}`
`553`	`551`
`554`	`552`	`// Detect resurrection`