slots: remove duplicate #[pymethod] from descriptors and fix io.rs

youknowone · claude · youknowone · commit 2f297e43e14e · 2025-12-30T01:40:26.000+09:00
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/crates/vm/src/builtins/getset.rs b/crates/vm/src/builtins/getset.rs
@@ -118,7 +118,6 @@ impl PyGetSet {
             )))
         }
     }
-    #[pymethod]
     fn __set__(
         zelf: PyObjectRef,
         obj: PyObjectRef,
@@ -127,7 +126,7 @@ impl PyGetSet {
     ) -> PyResult<()> {
         Self::descr_set(&zelf, obj, PySetterValue::Assign(value), vm)
     }
-    #[pymethod]
+
     fn __delete__(zelf: PyObjectRef, obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {
         Self::descr_set(&zelf, obj, PySetterValue::Delete, vm)
     }
diff --git a/crates/vm/src/builtins/property.rs b/crates/vm/src/builtins/property.rs
@@ -125,7 +125,6 @@ impl PyProperty {
             }
         }
     }
-    #[pymethod]
     fn __set__(
         zelf: PyObjectRef,
         obj: PyObjectRef,
@@ -134,7 +133,7 @@ impl PyProperty {
     ) -> PyResult<()> {
         Self::descr_set(&zelf, obj, PySetterValue::Assign(value), vm)
     }
-    #[pymethod]
+
     fn __delete__(zelf: PyObjectRef, obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {
         Self::descr_set(&zelf, obj, PySetterValue::Delete, vm)
     }
diff --git a/crates/vm/src/exception_group.rs b/crates/vm/src/exception_group.rs
@@ -202,11 +202,6 @@ pub(super) mod types {
             )))
         }
 
-        #[pymethod]
-        fn __repr__(zelf: PyObjectRef, vm: &VirtualMachine) -> PyResult<PyStrRef> {
-            Self::slot_repr(&zelf, vm)
-        }
-
         #[pyslot]
         fn slot_repr(zelf: &PyObject, vm: &VirtualMachine) -> PyResult<PyStrRef> {
             let zelf = zelf
diff --git a/crates/vm/src/stdlib/io.rs b/crates/vm/src/stdlib/io.rs
@@ -1616,7 +1616,8 @@ mod _io {
             let (raw, BufferSize { buffer_size }): (PyObjectRef, _) =
                 args.bind(vm).map_err(|e| {
                     let str_repr = e
-                        .__str__(vm)
+                        .as_object()
+                        .str(vm)
                         .map(|s| s.as_str().to_owned())
                         .unwrap_or_else(|_| "<error getting exception str>".to_owned());
                     let msg = format!("{}() {}", Self::CLASS_NAME, str_repr);

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ impl PyGetSet {`
`118`	`118`	`)))`
`119`	`119`	`}`
`120`	`120`	`}`
`121`		`- #[pymethod]`
`122`	`121`	`fn __set__(`
`123`	`122`	`zelf: PyObjectRef,`
`124`	`123`	`obj: PyObjectRef,`
`@@ -127,7 +126,7 @@ impl PyGetSet {`
`127`	`126`	`) -> PyResult<()> {`
`128`	`127`	`Self::descr_set(&zelf, obj, PySetterValue::Assign(value), vm)`
`129`	`128`	`}`
`130`		`- #[pymethod]`
	`129`	`+`
`131`	`130`	`fn __delete__(zelf: PyObjectRef, obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {`
`132`	`131`	`Self::descr_set(&zelf, obj, PySetterValue::Delete, vm)`
`133`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,6 @@ impl PyProperty {`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`	`}`
`128`		`- #[pymethod]`
`129`	`128`	`fn __set__(`
`130`	`129`	`zelf: PyObjectRef,`
`131`	`130`	`obj: PyObjectRef,`
`@@ -134,7 +133,7 @@ impl PyProperty {`
`134`	`133`	`) -> PyResult<()> {`
`135`	`134`	`Self::descr_set(&zelf, obj, PySetterValue::Assign(value), vm)`
`136`	`135`	`}`
`137`		`- #[pymethod]`
	`136`	`+`
`138`	`137`	`fn __delete__(zelf: PyObjectRef, obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {`
`139`	`138`	`Self::descr_set(&zelf, obj, PySetterValue::Delete, vm)`
`140`	`139`	`}`