initial slot inheritance

youknowone · arihant2math · commit 21273f7a100c · 2025-04-20T14:39:08.000-07:00
Signed-off-by: Ashwin Naren &lt;arihant2math@gmail.com&gt;
diff --git a/vm/src/builtins/type.rs b/vm/src/builtins/type.rs
@@ -214,6 +214,7 @@ impl PyType {
         if slots.basicsize == 0 {
             slots.basicsize = base.slots.basicsize;
         }
+        slots.inherits(&mro);
 
         if let Some(qualname) = attrs.get(identifier!(ctx, __qualname__)) {
             if !qualname.fast_isinstance(ctx.types.str_type) {
diff --git a/vm/src/types/slot.rs b/vm/src/types/slot.rs
@@ -110,6 +110,46 @@ impl PyTypeSlots {
             ..Default::default()
         }
     }
+
+    pub fn inherits(&mut self, mro: &[PyTypeRef]) {
+        macro_rules! inherit {
+            ($name:ident) => {
+                if self.$name.is_none() {
+                    for ty in mro {
+                        if let Some(func) = ty.slots.$name {
+                            self.$name = Some(func);
+                            break;
+                        }
+                    }
+                }
+            };
+            ($name:ident, "atomic") => {
+                if self.$name.load().is_none() {
+                    for ty in mro {
+                        if let Some(func) = ty.slots.$name.load() {
+                            self.$name.store(Some(func));
+                            break;
+                        }
+                    }
+                }
+            };
+        }
+        inherit!(as_sequence, "atomic");
+        inherit!(as_mapping, "atomic");
+        inherit!(hash, "atomic");
+        inherit!(call, "atomic");
+        inherit!(getattro, "atomic");
+        inherit!(setattro, "atomic");
+        inherit!(as_buffer);
+        inherit!(richcompare, "atomic");
+        inherit!(iter, "atomic");
+        inherit!(iternext, "atomic");
+        inherit!(descr_get, "atomic");
+        inherit!(descr_set, "atomic");
+        inherit!(init, "atomic");
+        inherit!(new, "atomic");
+        inherit!(del, "atomic");
+    }
 }
 
 impl std::fmt::Debug for PyTypeSlots {

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ impl PyType {`
`214`	`214`	`if slots.basicsize == 0 {`
`215`	`215`	`slots.basicsize = base.slots.basicsize;`
`216`	`216`	`}`
	`217`	`+ slots.inherits(&mro);`
`217`	`218`
`218`	`219`	`if let Some(qualname) = attrs.get(identifier!(ctx, __qualname__)) {`
`219`	`220`	`if !qualname.fast_isinstance(ctx.types.str_type) {`