Skip to content

Commit 1827af1

Browse files
fanninpmfanninpm
committed
Skip tests that pollute the environment for some reason
1 parent 17cc559 commit 1827af1

13 files changed

Lines changed: 249 additions & 0 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,33 @@ env:
105105
test_unpack
106106
test_weakref
107107
test_yield_from
108+
ENV_POLLUTING_TESTS_COMMON: >-
109+
test_raise
110+
test_ssl
111+
test_sys
112+
ENV_POLLUTING_TESTS_LINUX: >-
113+
test.test_multiprocessing_fork.test_processes
114+
test.test_multiprocessing_fork.test_threads
115+
test.test_multiprocessing_forkserver.test_processes
116+
test.test_multiprocessing_forkserver.test_threads
117+
test.test_multiprocessing_spawn.test_processes
118+
test.test_multiprocessing_spawn.test_threads
119+
test_file_eintr
120+
test_subprocess
121+
ENV_POLLUTING_TESTS_MACOS: >-
122+
test_multiprocessing_forkserver.test_manager
123+
test.test_multiprocessing_forkserver.test_misc
124+
test.test_multiprocessing_forkserver.test_processes
125+
test.test_multiprocessing_forkserver.test_threads
126+
test.test_multiprocessing_spawn.test_manager
127+
test.test_multiprocessing_spawn.test_misc
128+
test.test_multiprocessing_spawn.test_processes
129+
test.test_multiprocessing_spawn.test_threads
130+
test_ftplib
131+
test_logging
132+
test_multiprocessing_main_handling
133+
test_subprocess
134+
ENV_POLLUTING_TESTS_WINDOWS: >-
108135
# Python version targeted by the CI.
109136
PYTHON_VERSION: "3.13.1"
110137
X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR: C:\Program Files\OpenSSL\lib\VC\x64\MD
@@ -278,26 +305,81 @@ jobs:
278305

279306
- if: runner.os == 'Linux'
280307
name: run cpython platform-independent tests
308+
env:
309+
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
281310
run:
282311
target/release/rustpython -m test -j 1 -u all --slowest --fail-env-changed --timeout 600 -v ${{ env.PLATFORM_INDEPENDENT_TESTS }}
283312
timeout-minutes: 35
284313

285314
- if: runner.os == 'Linux'
286315
name: run cpython platform-dependent tests (Linux)
316+
env:
317+
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
287318
run: target/release/rustpython -m test -j 1 -u all --slowest --fail-env-changed --timeout 600 -v -x ${{ env.PLATFORM_INDEPENDENT_TESTS }}
288319
timeout-minutes: 35
289320

290321
- if: runner.os == 'macOS'
291322
name: run cpython platform-dependent tests (MacOS)
323+
env:
324+
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
292325
run: target/release/rustpython -m test -j 1 --slowest --fail-env-changed --timeout 600 -v -x ${{ env.PLATFORM_INDEPENDENT_TESTS }}
293326
timeout-minutes: 35
294327

295328
- if: runner.os == 'Windows'
296329
name: run cpython platform-dependent tests (windows partial - fixme)
330+
env:
331+
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
297332
run:
298333
target/release/rustpython -m test -j 1 --slowest --fail-env-changed --timeout 600 -v -x ${{ env.PLATFORM_INDEPENDENT_TESTS }} ${{ env.WINDOWS_SKIPS }}
299334
timeout-minutes: 45
300335

336+
- if: runner.os == 'Linux'
337+
name: run cpython tests to check if env polluters have stopped polluting (Common/Linux)
338+
shell: bash
339+
run: |
340+
for thing in ${{ env.ENV_POLLUTING_TESTS_COMMON }} ${{ env.ENV_POLLUTING_TESTS_LINUX }}; do
341+
set +e
342+
target/release/rustpython -m test -j 1 --slowest --fail-env-changed --timeout 600 -v ${thing}
343+
exit_code=$?
344+
set -e
345+
if [ ${exit_code} -ne 3 ]; then
346+
echo "Test ${thing} is no longer polluting the environment!"
347+
exit 1
348+
fi
349+
done
350+
timeout-minutes: 15
351+
352+
- if: runner.os == 'macOS'
353+
name: run cpython tests to check if env polluters have stopped polluting (Common/macOS)
354+
run: |
355+
for thing in ${{ env.ENV_POLLUTING_TESTS_COMMON }} ${{ env.ENV_POLLUTING_TESTS_MACOS }}; do
356+
set +e
357+
target/release/rustpython -m test -j 1 --slowest --fail-env-changed --timeout 600 -v ${thing}
358+
exit_code=$?
359+
set -e
360+
if [ ${exit_code} -ne 3 ]; then
361+
echo "Test ${thing} is no longer polluting the environment!"
362+
exit 1
363+
fi
364+
done
365+
timeout-minutes: 15
366+
367+
- if: runner.os == 'Windows'
368+
name: run cpython tests to check if env polluters have stopped polluting (Common/windows)
369+
shell: bash
370+
run: |
371+
for thing in ${{ env.ENV_POLLUTING_TESTS_COMMON }} ${{ env.ENV_POLLUTING_TESTS_WINDOWS }}; do
372+
set +e
373+
target/release/rustpython -m test -j 1 --slowest --fail-env-changed --timeout 600 -v ${thing}
374+
exit_code=$?
375+
set -e
376+
if [ ${exit_code} -ne 3 ]; then
377+
echo "Test ${thing} is no longer polluting the environment!"
378+
exit 1
379+
fi
380+
done
381+
timeout-minutes: 15
382+
301383
- if: runner.os != 'Windows'
302384
name: check that --install-pip succeeds
303385
run: |

‎Lib/test/test_file_eintr.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,10 @@ def test_readall(self):
186186
class CTestFileIOSignalInterrupt(TestFileIOSignalInterrupt, unittest.TestCase):
187187
modname = '_io'
188188

189+
@unittest.skipIf(
190+
'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ,
191+
"TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason"
192+
)
189193
# TODO: RUSTPYTHON - _io.FileIO.readall uses read_to_end which differs from _pyio.FileIO.readall
190194
@unittest.expectedFailure
191195
def test_readall(self):

‎Lib/test/test_importlib/resources/test_resource.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,11 @@ def test_is_file_failure_does_not_keep_open(self):
192192
def test_as_file_does_not_keep_open(self): # pragma: no cover
193193
resources.as_file(resources.files('ziptestdata') / 'binary.file')
194194

195+
import os # TODO: RUSTPYTHON see below
196+
@unittest.skipIf(
197+
'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ,
198+
"TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to tmpfile leak"
199+
)
195200
def test_entered_path_does_not_keep_open(self):
196201
"""
197202
Mimic what certifi does on import to make its bundle

‎Lib/test/test_multiprocessing_fork/test_processes.py‎

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,57 @@
33

44
install_tests_in_module_dict(globals(), 'fork', only_type="processes")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithProcessesTestCondition(WithProcessesTestCondition): # TODO: RUSTPYTHON
8+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
9+
def test_notify_all(self): super().test_notify_all() # TODO: RUSTPYTHON
10+
11+
class WithProcessesTestLock(WithProcessesTestLock): # TODO: RUSTPYTHON
12+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError')
13+
def test_repr_lock(self): super().test_repr_lock() # TODO: RUSTPYTHON
14+
15+
class WithProcessesTestManagerRestart(WithProcessesTestManagerRestart): # TODO: RUSTPYTHON
16+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError')
17+
def test_rapid_restart(self): super().test_rapid_restart() # TODO: RUSTPYTHON
18+
19+
class WithProcessesTestProcess(WithProcessesTestProcess): # TODO: RUSTPYTHON
20+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
21+
def test_args_argument(self): super().test_args_argument() # TODO: RUSTPYTHON
22+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
23+
def test_process(self): super().test_process() # TODO: RUSTPYTHON
24+
25+
class WithProcessesTestPool(WithProcessesTestPool): # TODO: RUSTPYTHON
26+
@unittest.skipIf( # TODO: RUSTPYTHON
27+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
28+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
29+
) # TODO: RUSTPYTHON
30+
def test_async_timeout(self): super().test_async_timeout() # TODO: RUSTPYTHON
31+
@unittest.skipIf( # TODO: RUSTPYTHON
32+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
33+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
34+
) # TODO: RUSTPYTHON
35+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
36+
@unittest.skipIf( # TODO: RUSTPYTHON
37+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
38+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
39+
) # TODO: RUSTPYTHON
40+
def test_traceback(self): super().test_traceback() # TODO: RUSTPYTHON
41+
42+
class WithProcessesTestPoolWorkerLifetime(WithProcessesTestPoolWorkerLifetime): # TODO: RUSTPYTHON
43+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
44+
def test_pool_worker_lifetime(self): super().test_pool_worker_lifetime() # TODO: RUSTPYTHON
45+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
46+
def test_pool_worker_lifetime_early_close(self): super().test_pool_worker_lifetime_early_close() # TODO: RUSTPYTHON
47+
48+
class WithProcessesTestQueue(WithProcessesTestQueue): # TODO: RUSTPYTHON
49+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
50+
def test_fork(self): super().test_fork() # TODO: RUSTPYTHON
51+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky timeout')
52+
def test_get(self): super().test_get() # TODO: RUSTPYTHON
53+
54+
class WithProcessesTestSharedMemory(WithProcessesTestSharedMemory): # TODO: RUSTPYTHON
55+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError')
56+
def test_shared_memory_SharedMemoryManager_basics(self): super().test_shared_memory_SharedMemoryManager_basics() # TODO: RUSTPYTHON
57+
658
if __name__ == '__main__':
759
unittest.main()

‎Lib/test/test_multiprocessing_fork/test_threads.py‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,17 @@
33

44
install_tests_in_module_dict(globals(), 'fork', only_type="threads")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithThreadsTestPool(WithThreadsTestPool): # TODO: RUSTPYTHON
8+
@unittest.skipIf( # TODO: RUSTPYTHON
9+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
10+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
11+
) # TODO: RUSTPYTHON
12+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
13+
14+
class WithThreadsTestManagerRestart(WithThreadsTestManagerRestart): # TODO: RUSTPYTHON
15+
@unittest.skipIf(sys.platform == 'linux', 'TODO: RUSTPYTHON flaky flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError')
16+
def test_rapid_restart(self): super().test_rapid_restart() # TODO: RUSTPYTHON
17+
618
if __name__ == '__main__':
719
unittest.main()

‎Lib/test/test_multiprocessing_forkserver/test_processes.py‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,35 @@
33

44
install_tests_in_module_dict(globals(), 'forkserver', only_type="processes")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithProcessesTestLock(WithProcessesTestLock): # TODO: RUSTPYTHON
8+
@unittest.skipIf( # TODO: RUSTPYTHON
9+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
10+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
11+
) # TODO: RUSTPYTHON
12+
def test_repr_lock(self): super().test_repr_lock() # TODO: RUSTPYTHON
13+
@unittest.skipIf( # TODO: RUSTPYTHON
14+
sys.platform == 'linux', # TODO: RUSTPYTHON
15+
'TODO: RUSTPYTHON flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError'
16+
) # TODO: RUSTPYTHON
17+
def test_repr_rlock(self): super().test_repr_rlock() # TODO: RUSTPYTHON
18+
19+
class WithProcessesTestPool(WithProcessesTestPool): # TODO: RUSTPYTHON
20+
@unittest.skipIf( # TODO: RUSTPYTHON
21+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
22+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
23+
) # TODO: RUSTPYTHON
24+
def test_async_timeout(self): super().test_async_timeout() # TODO: RUSTPYTHON
25+
@unittest.skipIf( # TODO: RUSTPYTHON
26+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
27+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
28+
) # TODO: RUSTPYTHON
29+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
30+
@unittest.skipIf( # TODO: RUSTPYTHON
31+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
32+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
33+
) # TODO: RUSTPYTHON
34+
def test_traceback(self): super().test_traceback() # TODO: RUSTPYTHON
35+
636
if __name__ == '__main__':
737
unittest.main()

‎Lib/test/test_multiprocessing_forkserver/test_threads.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,13 @@
33

44
install_tests_in_module_dict(globals(), 'forkserver', only_type="threads")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithThreadsTestPool(WithThreadsTestPool): # TODO: RUSTPYTHON
8+
@unittest.skipIf( # TODO: RUSTPYTHON
9+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
10+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
11+
) # TODO: RUSTPYTHON
12+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
13+
614
if __name__ == '__main__':
715
unittest.main()

‎Lib/test/test_multiprocessing_spawn/test_processes.py‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,35 @@
33

44
install_tests_in_module_dict(globals(), 'spawn', only_type="processes")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithProcessesTestLock(WithProcessesTestLock): # TODO: RUSTPYTHON
8+
@unittest.skipIf( # TODO: RUSTPYTHON
9+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
10+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
11+
) # TODO: RUSTPYTHON
12+
def test_repr_lock(self): super().test_repr_lock() # TODO: RUSTPYTHON
13+
@unittest.skipIf( # TODO: RUSTPYTHON
14+
sys.platform == 'linux', # TODO: RUSTPYTHON
15+
'TODO: RUSTPYTHON flaky BrokenPipeError, flaky ConnectionRefusedError, flaky ConnectionResetError, flaky EOFError'
16+
) # TODO: RUSTPYTHON
17+
def test_repr_rlock(self): super().test_repr_rlock() # TODO: RUSTPYTHON
18+
19+
class WithProcessesTestPool(WithProcessesTestPool): # TODO: RUSTPYTHON
20+
@unittest.skipIf( # TODO: RUSTPYTHON
21+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
22+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
23+
) # TODO: RUSTPYTHON
24+
def test_async_timeout(self): super().test_async_timeout() # TODO: RUSTPYTHON
25+
@unittest.skipIf( # TODO: RUSTPYTHON
26+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
27+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
28+
) # TODO: RUSTPYTHON
29+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
30+
@unittest.skipIf( # TODO: RUSTPYTHON
31+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
32+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
33+
) # TODO: RUSTPYTHON
34+
def test_traceback(self): super().test_traceback() # TODO: RUSTPYTHON
35+
636
if __name__ == '__main__':
737
unittest.main()

‎Lib/test/test_multiprocessing_spawn/test_threads.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,13 @@
33

44
install_tests_in_module_dict(globals(), 'spawn', only_type="threads")
55

6+
import os, sys # TODO: RUSTPYTHON
7+
class WithThreadsTestPool(WithThreadsTestPool): # TODO: RUSTPYTHON
8+
@unittest.skipIf( # TODO: RUSTPYTHON
9+
sys.platform == 'linux' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ, # TODO: RUSTPYTHON
10+
'TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unknown reason'
11+
) # TODO: RUSTPYTHON
12+
def test_terminate(self): super().test_terminate() # TODO: RUSTPYTHON
13+
614
if __name__ == '__main__':
715
unittest.main()

‎Lib/test/test_raise.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,11 @@ def f():
464464

465465
f()
466466

467+
import os # TODO: RUSTPYTHON see below
468+
@unittest.skipIf(
469+
'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ,
470+
"TODO: RUSTPYTHON environment pollution when running rustpython -m test --fail-env-changed due to unraisable exception"
471+
)
467472
def test_3611(self):
468473
import gc
469474
# A re-raised exception in a __del__ caused the __context__

0 commit comments

Comments
 (0)