Include SHAKE algorithm names in HASHXOF repr

moreal · moreal · commit 0629e3706b7c · 2026-02-14T21:28:51.000+09:00
diff --git a/Lib/test/test_hashlib.py b/Lib/test/test_hashlib.py
@@ -462,8 +462,6 @@ def test_blocksize_name(self):
         self.check_blocksize_name('sha384', 128, 48)
         self.check_blocksize_name('sha512', 128, 64)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     @requires_sha3
     def test_blocksize_name_sha3(self):
         self.check_blocksize_name('sha3_224', 144, 28)
diff --git a/crates/stdlib/src/hashlib.rs b/crates/stdlib/src/hashlib.rs
@@ -183,7 +183,7 @@ pub mod _hashlib {
         }
     }
 
-    #[pyclass(flags(IMMUTABLETYPE))]
+    #[pyclass(with(Representable), flags(IMMUTABLETYPE))]
     impl PyHasherXof {
         fn new(name: &str, d: HashXofWrapper) -> Self {
             Self {
@@ -233,6 +233,15 @@ pub mod _hashlib {
         }
     }
 
+    impl Representable for PyHasherXof {
+        fn repr_str(zelf: &Py<Self>, _vm: &VirtualMachine) -> PyResult<String> {
+            Ok(format!(
+                "<{} _hashlib.HASHXOF object @ {:#x}>",
+                zelf.name, zelf as *const _ as usize
+            ))
+        }
+    }
+
     #[pyfunction(name = "new")]
     fn hashlib_new(args: NewHashArgs, vm: &VirtualMachine) -> PyResult<PyObjectRef> {
         match args.name.as_str().to_lowercase().as_str() {

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ pub mod _hashlib {`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`
`186`		`- #[pyclass(flags(IMMUTABLETYPE))]`
	`186`	`+ #[pyclass(with(Representable), flags(IMMUTABLETYPE))]`
`187`	`187`	`impl PyHasherXof {`
`188`	`188`	`fn new(name: &str, d: HashXofWrapper) -> Self {`
`189`	`189`	`Self {`
`@@ -233,6 +233,15 @@ pub mod _hashlib {`
`233`	`233`	`}`
`234`	`234`	`}`
`235`	`235`
	`236`	`+ impl Representable for PyHasherXof {`
	`237`	`+ fn repr_str(zelf: &Py<Self>, _vm: &VirtualMachine) -> PyResult<String> {`
	`238`	`+ Ok(format!(`
	`239`	`+ "<{} _hashlib.HASHXOF object @ {:#x}>",`
	`240`	`+ zelf.name, zelf as *const _ as usize`
	`241`	`+ ))`
	`242`	`+ }`
	`243`	`+ }`
	`244`	`+`
`236`	`245`	`#[pyfunction(name = "new")]`
`237`	`246`	`fn hashlib_new(args: NewHashArgs, vm: &VirtualMachine) -> PyResult<PyObjectRef> {`
`238`	`247`	`match args.name.as_str().to_lowercase().as_str() {`