apply review

youknowone · youknowone · commit 00e4c924b781 · 2026-01-02T23:17:09.000+09:00
diff --git a/crates/stdlib/src/multiprocessing.rs b/crates/stdlib/src/multiprocessing.rs
@@ -230,6 +230,9 @@ mod _multiprocessing {
 
     impl Drop for SemHandle {
         fn drop(&mut self) {
+            // Guard against default/uninitialized state.
+            // Note: SEM_FAILED is (sem_t*)-1, not null, but valid handles are never null
+            // and SEM_FAILED is never stored (error is returned immediately on sem_open failure).
             if !self.raw.is_null() {
                 // SEM_CLOSE(sem) sem_close(sem)
                 unsafe {
@@ -433,9 +436,8 @@ mod _multiprocessing {
                     ));
                 }
                 // if (self->count > 1) { --self->count; Py_RETURN_NONE; }
-                let current = self.count.load(Ordering::Acquire);
-                if current > 1 {
-                    self.count.store(current - 1, Ordering::Release);
+                if self.count.load(Ordering::Acquire) > 1 {
+                    self.count.fetch_sub(1, Ordering::Release);
                     return Ok(());
                 }
                 // assert(self->count == 1);
