Skip to content

Commit f6fc3ae

Browse files
authored
RK-5120 - allow whitespaces in todos + update readme screenshot and text (#19)
* RK-5120 - add todo doesnt trim whitespace, just special chars (for bug hunt) * update screenshot and text in readme * typo * circleci fix
1 parent 9670dc6 commit f6fc3ae

6 files changed

Lines changed: 4 additions & 5 deletions

File tree

‎.circleci/config.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ references:
3939
run:
4040
command: |
4141
mkdir -p ~/.ssh/ && echo -e "Host github.com\n\tStrictHostKeyChecking no\n" > ~/.ssh/config
42-
sudo apt-get update && sudo apt-get install python-setuptools python-dev build-essential libpq-dev libffi6 libffi-dev libssl-dev
43-
sudo easy_install pip
42+
sudo apt update && sudo apt-get install python-setuptools python-dev build-essential libpq-dev libffi6 libffi-dev libssl-dev python-pip
4443
pip install --upgrade --user setuptools
4544
git clone git@github.com:Rookout/build_tools.git
4645
pip install -r build_tools/requirements.txt --user

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ docker run -p 8080:8080 -e "ROOKOUT_TOKEN=[Your Rookout Token]" rookout/tutorial
8383
- Open the file `src/main/java/com/rookout/tutorial/TodoController.java`
8484
![TodoController.java](/img/screenshots/java-tutorial_1.png)
8585

86-
- Add a Snapshot Breakpoint to the `addTodo` function by clicking next the the line number in the file viewer
86+
- Add a Breakpoint to the `addTodo` function by clicking next the line number in the file viewer
8787
![Snapshot Breakpoint](/img/screenshots/java-tutorial_2.png)
8888

89-
- Looking at the right-hand pane **Breakpoints**, you will see the Breakpoint and the line number where you added it - it should be <span style="color: #73CD1F;">**GREEN**</span>
89+
- Click on the **Breakpoints** tab in the left pane, and you will see the Breakpoint and the line number where you added it - it should be solid purple.
9090
![Valid Breakpoint](/img/screenshots/java-tutorial_3.png)
9191
- **If this is not the case, [check our troubleshooting guide](https://docs.rookout.com/docs/breakpoints-status.html)**
9292

104 KB
Loading
3.77 KB
Loading
42.6 KB
Loading

‎src/main/java/com/rookout/tutorial/TodoController.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public ResponseEntity<?> addTodo(@RequestBody TodoRecord newTodoRecord) {
2323
newTodoRecord.setId(UUID.randomUUID().toString());
2424
logger.info("Adding a new todo: {}", newTodoRecord);
2525
// The bug in here in is for the bughunt example
26-
String todoTitle = newTodoRecord.getTitle().replaceAll("[^a-zA-Z0-9]+", "");
26+
String todoTitle = newTodoRecord.getTitle().replaceAll("[^a-zA-Z0-9\\s]+", "");
2727
newTodoRecord.setTitle(todoTitle);
2828
todos.add(newTodoRecord);
2929
Map<String, String> entities = new HashMap<>();

0 commit comments

Comments
 (0)