BUG: Fix hard-coded radius value for parachute added mass calculation (#889)

Copilot · Gui-FernandesBR · MateusStano · commit 54b976c4cdda · 2026-03-18T21:51:54.000-03:00
* Fix hard-coded radius value for parachute added mass calculation Calculate radius from cd_s using a typical hemispherical parachute drag coefficient (1.4) when radius is not explicitly provided. This fixes drift distance calculations for smaller parachutes like drogues. Formula: R = sqrt(cd_s / (Cd * π)) Closes #860 Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Address code review: improve docstrings and add explicit None defaults Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Add CHANGELOG entry for PR #889 Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Update rocket.add_parachute to use radius=None for consistency Changed the default radius from 1.5 to None in the add_parachute method to match the Parachute class behavior. This ensures consistent automatic radius calculation from cd_s across both APIs. Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation Fix hard-coded radius value for parachute added mass calculation Calculate radius from cd_s using a typical hemispherical parachute drag coefficient (1.4) when radius is not explicitly provided. This fixes drift distance calculations for smaller parachutes like drogues. Formula: R = sqrt(cd_s / (Cd * π)) Closes #860 Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Add CHANGELOG entry for PR #889 Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Refactor Parachute class to remove hard-coded radius value and introduce drag_coefficient parameter for radius estimation MNT: Extract noise initialization to fix pylint too-many-statements in Parachute.__init__ Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> * Refactor environment method access in controller test for clarity * fix pylint * fix comments * avoid breaking change with drag_coefficient * reafactors Parachute.__init__ method * fix tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com> Co-authored-by: Gui-FernandesBR <guilherme_fernandes@usp.br>
diff --git a/tests/integration/simulation/test_flight.py b/tests/integration/simulation/test_flight.py
@@ -716,6 +716,21 @@ def invalid_controller_9_params(  # pylint: disable=unused-argument
             clamp=True,
         )
 
+def make_controller_test_environment_access(methods_called):
+    def _call_env_methods(environment, altitude_asl):
+        _ = environment.elevation
+        methods_called["elevation"] = True
+        _ = environment.wind_velocity_x(altitude_asl)
+        methods_called["wind_velocity_x"] = True
+        _ = environment.wind_velocity_y(altitude_asl)
+        methods_called["wind_velocity_y"] = True
+        _ = environment.speed_of_sound(altitude_asl)
+        methods_called["speed_of_sound"] = True
+        _ = environment.pressure(altitude_asl)
+        methods_called["pressure"] = True
+        _ = environment.temperature(altitude_asl)
+        methods_called["temperature"] = True
+
 def make_controller_test_environment_access(methods_called):
     def _call_env_methods(environment, altitude_asl):
         _ = environment.elevation
