Skip to content

Commit 3717d86

Browse files
committed
ENH: simplify pull request template
1 parent 0d46825 commit 3717d86

1 file changed

Lines changed: 29 additions & 26 deletions

File tree

.github/pull_request_template.md

Lines changed: 29 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,51 @@
1-
## Pull request checklist
1+
<!-- You are awesome! Your contribution to RocketPy is fundamental in our endeavour to create a next generation solution for rocketry trajectory simulation! -->
22

3-
Please check if your PR fulfills the following requirements:
4-
- [ ] Tests for the changes have been added (for bug fixes / features)
5-
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
6-
- [ ] Build (`python setup.py install`) was run locally and any changes were pushed
7-
- [ ] Lint (`black rocketpy`) has passed locally and any fixes were made for failures
8-
- [ ] All tests (`pytest --runslow`) have passed locally
3+
<!-- You may use this template to describe your Pull Request. But if you believe there is a better way to express yourself, don't hesitate! -->
94

105
## Pull request type
11-
<!-- Please do not submit updates to dependencies unless it fixes an issue. -->
12-
<!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. -->
136

147
Please check the type of change your PR introduces:
15-
- [ ] Bugfix
16-
- [ ] Feature
17-
- [ ] Code style update (formatting, renaming)
18-
- [ ] Refactoring (no functional changes, no api changes)
19-
- [ ] Build related changes
20-
- [ ] Documentation content changes
21-
- [ ] Other (please describe):
8+
- [ ] Code base additions (bugfix, features)
9+
- [ ] Code maintenance (refactoring, formatting, renaming)
10+
- [ ] ReadMe, Docs and GitHub maintenance
11+
- [ ] Other (please describe):
12+
13+
## Pull request checklist
14+
15+
Please check if your PR fulfills the following requirements, depending on the type of PR:
16+
17+
- ReadMe, Docs and GitHub maintenance:
18+
- [ ] Spelling has been verified
19+
- [ ] Code docs are working correctly
20+
21+
- Code base maintenance (for bug fixes / features):
22+
- [ ] Docs have been reviewed and added / updated if needed
23+
- [ ] Lint (`black rocketpy`) has passed locally and any fixes were made
24+
- [ ] All tests (`pytest --runslow`) have passed locally
25+
26+
- Code base additions (for bug fixes / features):
27+
- [ ] Tests for the changes have been added
28+
- [ ] Docs have been reviewed and added / updated if needed
29+
- [ ] Lint (`black rocketpy`) has passed locally and any fixes were made
30+
- [ ] All tests (`pytest --runslow`) have passed locally
2231

2332
## What is the current behavior?
2433
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
2534

26-
RocketPy's code did not have any unit tests setup.
27-
35+
Enter text here...
2836

2937
## What is the new behavior?
3038
<!-- Please describe the behavior or changes that are being added by this PR. -->
3139

32-
-
33-
-
40+
Enter text here...
3441

3542
## Does this introduce a breaking change?
43+
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
3644

3745
- [ ] Yes
3846
- [ ] No
3947

40-
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
41-
42-
4348
## Other information
44-
4549
<!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
4650

47-
-
48-
-
51+
Enter text here...

0 commit comments

Comments
 (0)