chore(functions/firebase): fix samples + tests not running (GoogleCloudPlatform#1967)

Ace Nassri · web-flow · commit 26dfbe9bef04 · 2020-09-09T13:36:43.000-07:00
* Fix potential infinite loop in Firestore sample

* Fix broken tests D:

* Add kokoro file for Firebase

* Fix nit
diff --git a/.kokoro/functions/firebase.cfg b/.kokoro/functions/firebase.cfg
@@ -0,0 +1,13 @@
+# Format: //devtools/kokoro/config/proto/build.proto
+
+# Set the folder in which the tests are run
+env_vars: {
+    key: "PROJECT"
+    value: "functions/firebase"
+}
+
+# Tell the trampoline which build file to use.
+env_vars: {
+    key: "TRAMPOLINE_BUILD_FILE"
+    value: "github/nodejs-docs-samples/.kokoro/build.sh"
+}
diff --git a/functions/firebase/index.js b/functions/firebase/index.js
@@ -89,16 +89,23 @@ const firestore = new Firestore({
 
 // Converts strings added to /messages/{pushId}/original to uppercase
 exports.makeUpperCase = (event) => {
-  const {resource} = event;
+  const resource = event.value.name;
   const affectedDoc = firestore.doc(resource.split('/documents/')[1]);
 
   const curValue = event.value.fields.original.stringValue;
   const newValue = curValue.toUpperCase();
-  console.log(`Replacing value: ${curValue} --> ${newValue}`);
 
-  return affectedDoc.set({
-    original: newValue,
-  });
+  if (curValue !== newValue) {
+    console.log(`Replacing value: ${curValue} --> ${newValue}`);
+
+    return affectedDoc.set({
+      original: newValue,
+    });
+  } else {
+    // Value is already upper-case
+    // Don't perform a(nother) write to avoid infinite loops
+    console.log('Value is already upper-case.')
+  }
 };
 // [END functions_firebase_reactive]
 
diff --git a/functions/firebase/test/index.test.js b/functions/firebase/test/index.test.js
@@ -121,12 +121,10 @@ describe('functions_firebase_auth', () => {
     const date = Date.now();
     const event = {
       resource: 'resource',
-      data: {
-        uid: 'me',
-        email: 'me@example.com',
-        metadata: {
-          createdAt: date,
-        },
+      uid: 'me',
+      email: 'me@example.com',
+      metadata: {
+        createdAt: date,
       },
     };
 
@@ -183,11 +181,9 @@ describe('functions_firebase_remote_config', () => {
     const sample = getSample();
 
     const event = {
-      data: {
-        updateOrigin: 'CONSOLE',
-        updateType: 'INCREMENTAL_UPDATE',
-        versionNumber: '1',
-      },
+      updateOrigin: 'CONSOLE',
+      updateType: 'INCREMENTAL_UPDATE',
+      versionNumber: '1',
     };
 
     sample.program.helloRemoteConfig(event);
@@ -206,6 +202,7 @@ describe('functions_firebase_reactive', () => {
     const sample = getSample();
 
     const value = {
+      name: 'foo/documents/bar',
       fields: {
         original: {
           stringValue: 'abc'
@@ -214,16 +211,37 @@ describe('functions_firebase_reactive', () => {
     };
 
     const event = {
-      resource: 'foo/documents/bar',
       eventType: 'type',
-      data: {
-        value: value,
-      },
+      value: value,
     };
 
-    sample.program.makeUpperCase(event, context);
+    sample.program.makeUpperCase(event);
 
     assert.strictEqual(console.log.calledWith('Replacing value: abc --> ABC'), true);
     assert.strictEqual(sample.mocks.firestore.doc.calledWith('bar'), true);
+    assert.strictEqual(sample.mocks.firestore.set.callCount, 1);
+  });
+
+  it('should do nothing if value is already capitalized', () => {
+    const sample = getSample();
+
+    const value = {
+      name: 'foo/documents/bar',
+      fields: {
+        original: {
+          stringValue: 'ABC'
+        }
+      }
+    };
+
+    const event = {
+      eventType: 'type',
+      value: value,
+    };
+
+    sample.program.makeUpperCase(event);
+
+    assert.strictEqual(console.log.calledWith('Value is already upper-case.'), true);
+    assert.strictEqual(sample.mocks.firestore.set.callCount, 0);
   });
 });
