Added tests for IntPtrComparer.

KN4CK3R · KN4CK3R · commit 873b31b1ba21 · 2019-04-24T15:52:33.000+02:00
diff --git a/ReClass.NET/Util/IntPtrComparer.cs b/ReClass.NET/Util/IntPtrComparer.cs
@@ -1,5 +1,6 @@
 ﻿using System;
 using System.Collections.Generic;
+using ReClassNET.Extensions;
 
 namespace ReClassNET.Util
 {
@@ -9,7 +10,7 @@ public class IntPtrComparer : IComparer<IntPtr>
 
 		public int Compare(IntPtr x, IntPtr y)
 		{
-			return x.ToInt64().CompareTo(y.ToInt64());
+			return x.CompareTo(y);
 		}
 	}
 }
diff --git a/ReClass.NET_Tests/ReClass.NET_Tests.csproj b/ReClass.NET_Tests/ReClass.NET_Tests.csproj
@@ -74,6 +74,7 @@
     <Compile Include="Util\DirectedGraphTest.cs" />
     <Compile Include="Util\GrowingListTest.cs" />
     <Compile Include="Util\HexadecimalFormatterTest.cs" />
+    <Compile Include="Util\IntPtrComparerTest.cs" />
     <Compile Include="Util\NumberFormatTest.cs" />
     <Compile Include="Util\PathUtilTest.cs" />
     <Compile Include="Util\XElementSerializerTest.cs" />
diff --git a/ReClass.NET_Tests/Util/IntPtrComparerTest.cs b/ReClass.NET_Tests/Util/IntPtrComparerTest.cs
@@ -0,0 +1,33 @@
+﻿using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using NFluent;
+using ReClassNET.Util;
+using Xunit;
+
+namespace ReClass.NET_Tests.Util
+{
+	public class IntPtrComparerTest
+	{
+		public static TheoryData<IntPtr, IntPtr, bool> GetTestCompareData() => new TheoryData<IntPtr, IntPtr, bool>
+		{
+			{ IntPtr.Zero, IntPtr.Zero, false },
+			{ (IntPtr)0x1, IntPtr.Zero, false },
+			{ (IntPtr)0x1, (IntPtr)0x10, true },
+			{ (IntPtr)0x1, unchecked((IntPtr)(int)0xFFFFFFFF), true },
+			{ unchecked((IntPtr)(int)0xFFFFFFFF), unchecked((IntPtr)(int)0xFFFFFFFF), false },
+			{ unchecked((IntPtr)(int)0xFFFFFFFF), IntPtr.Zero, false }
+		};
+
+		[Theory]
+		[MemberData(nameof(GetTestCompareData))]
+		public void TestCompare(IntPtr lhs, IntPtr rhs, bool lhsIsSmaller)
+		{
+			var comparer = IntPtrComparer.Instance;
+
+			Check.That(comparer.Compare(lhs, rhs) < 0).IsEqualTo(lhsIsSmaller);
+		}
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
	`3`	`+using ReClassNET.Extensions;`
`3`	`4`
`4`	`5`	`namespace ReClassNET.Util`
`5`	`6`	`{`
`@@ -9,7 +10,7 @@ public class IntPtrComparer : IComparer<IntPtr>`
`9`	`10`
`10`	`11`	`public int Compare(IntPtr x, IntPtr y)`
`11`	`12`	`{`
`12`		`- return x.ToInt64().CompareTo(y.ToInt64());`
	`13`	`+ return x.CompareTo(y);`
`13`	`14`	`}`
`14`	`15`	`}`
`15`	`16`	`}`