The Add/InsertBytes method should not be part of the container class.

KN4CK3R · KN4CK3R · commit 3dd093cf8ea2 · 2019-01-17T16:04:25.000+01:00
diff --git a/ReClass.NET/Nodes/BaseContainerNode.cs b/ReClass.NET/Nodes/BaseContainerNode.cs
@@ -169,7 +169,7 @@ public void InsertBytes(BaseNode position, int size)
 		/// <summary>Inserts <paramref name="size"/> bytes at the specified position.</summary>
 		/// <param name="index">Zero-based position.</param>
 		/// <param name="size">The number of bytes to insert.</param>
-		public void InsertBytes(int index, int size)
+		protected void InsertBytes(int index, int size)
 		{
 			List<BaseNode> dummy = null;
 			InsertBytes(index, size, ref dummy);
@@ -179,7 +179,7 @@ public void InsertBytes(int index, int size)
 		/// <param name="index">Zero-based position.</param>
 		/// <param name="size">The number of bytes to insert.</param>
 		/// <param name="createdNodes">[in,out] A list with the created nodes.</param>
-		public virtual void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
+		protected virtual void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
 			if (index < 0 || index > nodes.Count || size == 0)
 			{
diff --git a/ReClass.NET/Nodes/ClassNode.cs b/ReClass.NET/Nodes/ClassNode.cs
@@ -206,7 +206,7 @@ public void UpdateAddress(RemoteProcess process)
 			}
 		}
 
-		public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
+		protected override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
 			base.InsertBytes(index, size, ref createdNodes);
 
diff --git a/ReClass.NET/Nodes/VTableNode.cs b/ReClass.NET/Nodes/VTableNode.cs
@@ -112,7 +112,7 @@ public override int CalculateDrawnHeight(ViewInfo view)
 
 		public override bool ReplaceChildNode(int index, Type nodeType, ref List<BaseNode> createdNodes) => false;
 
-		public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
+		protected override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
 			if (index < 0 || index > nodes.Count || size == 0)
 			{

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ public void InsertBytes(BaseNode position, int size)`
`169`	`169`	`/// <summary>Inserts <paramref name="size"/> bytes at the specified position.</summary>`
`170`	`170`	`/// <param name="index">Zero-based position.</param>`
`171`	`171`	`/// <param name="size">The number of bytes to insert.</param>`
`172`		`- public void InsertBytes(int index, int size)`
	`172`	`+ protected void InsertBytes(int index, int size)`
`173`	`173`	`{`
`174`	`174`	`List<BaseNode> dummy = null;`
`175`	`175`	`InsertBytes(index, size, ref dummy);`
`@@ -179,7 +179,7 @@ public void InsertBytes(int index, int size)`
`179`	`179`	`/// <param name="index">Zero-based position.</param>`
`180`	`180`	`/// <param name="size">The number of bytes to insert.</param>`
`181`	`181`	`/// <param name="createdNodes">[in,out] A list with the created nodes.</param>`
`182`		`- public virtual void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
	`182`	`+ protected virtual void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
`183`	`183`	`{`
`184`	`184`	`if (index < 0 \|\| index > nodes.Count \|\| size == 0)`
`185`	`185`	`{`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ public void UpdateAddress(RemoteProcess process)`
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`
`209`		`- public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
	`209`	`+ protected override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
`210`	`210`	`{`
`211`	`211`	`base.InsertBytes(index, size, ref createdNodes);`
`212`	`212`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public override int CalculateDrawnHeight(ViewInfo view)`
`112`	`112`
`113`	`113`	`public override bool ReplaceChildNode(int index, Type nodeType, ref List<BaseNode> createdNodes) => false;`
`114`	`114`
`115`		`- public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
	`115`	`+ protected override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)`
`116`	`116`	`{`
`117`	`117`	`if (index < 0 \|\| index > nodes.Count \|\| size == 0)`
`118`	`118`	`{`