Add comprehensive tests for Speaker and DistanceSensor classes#140
Merged
Conversation
- test_speaker_default_values: Tests basic Speaker initialization with default freq (440Hz) and volume (0) - test_speaker_alt_values: Tests custom initial_freq and initial_volume parameters with delta tolerance for PWM frequency variations - test_speaker_note_conversion: Tests _to_freq() method for string notes, MIDI notes, and direct frequency values - test_speaker_play_single_note: Tests playing a single note and verifies volume is 0 after playback - test_speaker_play_note_list: Tests playing a sequence of notes with durations - test_distance_sensor_basic: Tests DistanceSensor initialization with default max_distance (1.0m) - test_distance_sensor_custom_max_distance: Tests custom max_distance parameter Speaker tests use pins 15-19, DistanceSensor tests use pins 22-25 to avoid conflicts. Uses assertAlmostEqual with delta=10 for PWM frequency assertions to account for hardware limitations.
Contributor
Author
|
Fixes #10 |
MarcScott
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speaker tests use pins 15-19, DistanceSensor tests use pins 22-25 to avoid conflicts.
Uses assertAlmostEqual with delta=10 for PWM frequency assertions to account for hardware limitations.